Document deployment pull error handling strategy#80
Open
miru-agents wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added clarifying documentation to the
pull_deploymentsfunction explaining its error handling approach and the rationale behind it.Key Changes
pull_deploymentsintentionally short-circuits on the first per-deployment error rather than collecting errors and continuingImplementation Details
The comment clarifies an important distinction from
pull_content_for_cfg_insts, which has different error handling semantics. This documentation ensures future maintainers understand the deliberate design choice to fail fast on deployment ingestion errors, protecting against inconsistent local state that could lead to unintended config instance removal during apply runs.https://claude.ai/code/session_01LC5Gcb1hq4ArTRmHWKHvpg