Skip to content

fix: normalize uppercase version prefix and harden version resolve lookup #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ben-miru merged 1 commit into from
May 17, 2026
Merged

fix: normalize uppercase version prefix and harden version resolve lookup #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions __tests__/versions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,14 @@ describe('sanitize', () => {
test('trims whitespace and adds v prefix', () => {
expect(sanitize(' 0.9.0 ')).toBe('v0.9.0')
})

test('normalizes uppercase V prefix to lowercase', () => {
expect(sanitize('V1.2.3')).toBe('v1.2.3')
})

test('trims whitespace and normalizes uppercase V prefix', () => {
expect(sanitize(' V0.9.0 ')).toBe('v0.9.0')
})
})

describe('resolve', () => {
Expand Down Expand Up @@ -70,4 +78,16 @@ describe('resolve', () => {
test('passes through unknown partial version as-is', () => {
expect(resolve('v1.2')).toBe('v1.2')
})

test('does not resolve inherited prototype key "toString"', () => {
expect(resolve('toString')).toBe('toString')
})

test('does not resolve inherited prototype key "constructor"', () => {
expect(resolve('constructor')).toBe('constructor')
})

test('does not resolve inherited prototype key "hasOwnProperty"', () => {
expect(resolve('hasOwnProperty')).toBe('hasOwnProperty')
})
})
4 changes: 2 additions & 2 deletions dist/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/index.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions src/versions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export const sanitize = (version: string): string => {
if (!version || version.toLowerCase() === 'latest') {
return 'latest'
}
return `v${version.replace(/^v/, '')}`
return `v${version.replace(/^v/i, '')}`
}

/**
Expand All @@ -28,5 +28,5 @@ export const resolve = (version: string): string => {
'v0.9': 'v0.9.2',
'v0.10': LATEST_VERSION
}
return mappings[version] || version
return Object.hasOwn(mappings, version) ? mappings[version] : version
}