From 71fd80e0bc2fd006a59fdc90f539485b959f9bed Mon Sep 17 00:00:00 2001 From: Jean-Kevin KPADEY Date: Wed, 8 Jul 2026 23:35:24 +0200 Subject: [PATCH] fix(entities): remove Objects.requireNonNull from AbstractTrend constructor Removes the Objects.requireNonNull(type) call from the AbstractTrend constructor which could throw NullPointerException, leaving the object partially initialized and vulnerable to finalizer attacks (CT_CONSTRUCTOR_THROW). The type field is assigned directly now. Since WeatherChangeType is an enum and all subclasses pass concrete values, null is never expected. --- .../main/java/io/github/mivek/model/trend/AbstractTrend.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/metarParser-entities/src/main/java/io/github/mivek/model/trend/AbstractTrend.java b/metarParser-entities/src/main/java/io/github/mivek/model/trend/AbstractTrend.java index 8502d4df..01320a6f 100644 --- a/metarParser-entities/src/main/java/io/github/mivek/model/trend/AbstractTrend.java +++ b/metarParser-entities/src/main/java/io/github/mivek/model/trend/AbstractTrend.java @@ -3,7 +3,6 @@ import io.github.mivek.enums.WeatherChangeType; import io.github.mivek.model.AbstractWeatherContainer; import java.util.Locale; -import java.util.Objects; import org.apache.commons.lang3.builder.ToStringBuilder; /** @@ -22,7 +21,7 @@ public abstract class AbstractTrend extends AbstractWeatherContainer { */ protected AbstractTrend(final WeatherChangeType type) { super(); - this.type = Objects.requireNonNull(type); + this.type = type; } /**