Skip to content

CI: integration container tests the released dotf, not the PR's built binary #734

Description

@mlorentedev

Problem

tests/Dockerfile.integration copies the repo and runs setup-linux.sh, which installs dotf via scripts/install-dotf.sh — and that downloads the pinned release artifact rather than building from the PR's ./cli source. On top of that, dotf is not on the bats-time PATH (the verify-setup.bats ENTRYPOINT does not source the login profile).

Consequences:

Proposed fix

  • Build dotf from ./cli inside the integration image (or inject the CI-built binary) and put it on PATH before setup-linux.sh runs, so install-dotf.sh sees the current build and setup exercises the PR's code.
  • Ensure dotf is on the bats-time PATH so the verify-setup.bats guards actually run (drop the command -v dotf ... || skip fallbacks once guaranteed).

Evidence

BUG-029 (#696) PR #732: the two [#696] machine.json guards skip in the container; the seed logic is covered by Go unit tests + the dotf doctor repo-dir check instead. Related: CLI-031 golden characterization tests (#672).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions