test: fix existing rubocop offenses

atesgoral · atesgoral · commit 0e694e30fd4e · 2026-06-14T17:00:18.000+02:00
Replace empty literal assert_equal calls with assert_empty across the existing test suite so rake rubocop passes cleanly on main.
diff --git a/test/mcp/annotations_test.rb b/test/mcp/annotations_test.rb
@@ -32,7 +32,7 @@ def test_initialization_by_default
       assert_nil(annotations.priority)
       assert_nil(annotations.last_modified)
 
-      assert_equal({}, annotations.to_h)
+      assert_empty(annotations.to_h)
     end
 
     def test_initialization_with_partial_attributes
diff --git a/test/mcp/client_test.rb b/test/mcp/client_test.rb
@@ -119,7 +119,7 @@ def test_tools_returns_empty_array_when_no_tools
       client = Client.new(transport: transport)
       tools = client.tools
 
-      assert_equal([], tools)
+      assert_empty(tools)
     end
 
     def test_call_tool_sends_request_to_transport_and_returns_content
@@ -206,7 +206,7 @@ def test_resources_returns_empty_array_when_no_resources
       client = Client.new(transport: transport)
       resources = client.resources
 
-      assert_equal([], resources)
+      assert_empty(resources)
     end
 
     def test_read_resource_sends_request_to_transport_and_returns_contents
@@ -246,7 +246,7 @@ def test_read_resource_returns_empty_array_when_no_contents
       client = Client.new(transport: transport)
       contents = client.read_resource(uri: uri)
 
-      assert_equal([], contents)
+      assert_empty(contents)
     end
 
     def test_resource_templates_sends_request_to_transport_and_returns_resource_templates_array
@@ -283,7 +283,7 @@ def test_resource_templates_returns_empty_array_when_no_resource_templates
       client = Client.new(transport: transport)
       resource_templates = client.resource_templates
 
-      assert_equal([], resource_templates)
+      assert_empty(resource_templates)
     end
 
     def test_prompts_sends_request_to_transport_and_returns_prompts_array
@@ -348,7 +348,7 @@ def test_prompts_returns_empty_array_when_no_prompts
       client = Client.new(transport: transport)
       prompts = client.prompts
 
-      assert_equal([], prompts)
+      assert_empty(prompts)
     end
 
     def test_get_prompt_sends_request_to_transport_and_returns_contents
@@ -394,7 +394,7 @@ def test_get_prompt_returns_empty_hash_when_no_contents
       client = Client.new(transport: transport)
       contents = client.get_prompt(name: name)
 
-      assert_equal({}, contents)
+      assert_empty(contents)
     end
 
     def test_get_prompt_returns_empty_hash
@@ -407,7 +407,7 @@ def test_get_prompt_returns_empty_hash
       client = Client.new(transport: transport)
       contents = client.get_prompt(name: name)
 
-      assert_equal({}, contents)
+      assert_empty(contents)
     end
 
     def test_call_tool_includes_meta_progress_token_when_provided
@@ -762,7 +762,7 @@ def test_complete_returns_default_when_result_is_missing
         argument: { name: "arg", value: "" },
       )
 
-      assert_equal([], result["values"])
+      assert_empty(result["values"])
       refute(result["hasMore"])
     end
 
@@ -780,7 +780,7 @@ def test_ping_sends_request_and_returns_empty_hash
       client = Client.new(transport: transport)
       result = client.ping
 
-      assert_equal({}, result)
+      assert_empty(result)
     end
 
     def test_ping_raises_server_error_on_error_response
diff --git a/test/mcp/icon_test.rb b/test/mcp/icon_test.rb
@@ -23,7 +23,7 @@ def test_initialization_by_default
       assert_nil(icon.src)
       assert_nil(icon.theme)
 
-      assert_equal({}, icon.to_h)
+      assert_empty(icon.to_h)
     end
 
     def test_valid_theme_for_light
diff --git a/test/mcp/instrumentation_test.rb b/test/mcp/instrumentation_test.rb
@@ -124,7 +124,7 @@ def instrumented_method_that_raises_with_error_set
       error = assert_raises(RuntimeError) { subject.instrumented_method }
       assert_equal("boom before", error.message)
       assert_same(error, reported_exception)
-      assert_equal({}, reported_context)
+      assert_empty(reported_context)
       assert_equal(:internal_error, subject.instrumentation_data_received[:error])
       assert(subject.instrumentation_data_received.key?(:duration))
     end
@@ -167,7 +167,7 @@ def instrumented_method_that_raises_with_error_set
       end
 
       assert_raises(StandardError) { subject.instrumented_with_skip }
-      assert_equal([], reported)
+      assert_empty(reported)
     end
 
     test "#instrument_call reports when exception_already_reported returns false for a new exception" do
@@ -245,7 +245,7 @@ def instrumented_method_that_raises_with_error_set
       end
 
       assert_raises(RuntimeError) { subject.instrumented_with_truthy_predicate }
-      assert_equal([], reported)
+      assert_empty(reported)
     end
 
     test "#instrument_call reports when exception_already_reported returns nil" do
diff --git a/test/mcp/resource/contents_test.rb b/test/mcp/resource/contents_test.rb
@@ -140,7 +140,7 @@ class ContentsTest < ActiveSupport::TestCase
         result = contents.to_h
 
         assert result.key?(:_meta)
-        assert_equal({}, result[:_meta])
+        assert_empty(result[:_meta])
       end
     end
   end
diff --git a/test/mcp/server/pagination_test.rb b/test/mcp/server/pagination_test.rb
@@ -69,7 +69,7 @@ class PaginationHost
       test "paginate with empty items returns empty array" do
         result = @host.paginate([], cursor: nil, page_size: 2, request: @request)
 
-        assert_equal [], result[:items]
+        assert_empty result[:items]
         assert_nil result[:next_cursor]
       end
 
diff --git a/test/mcp/server/transports/stdio_notification_integration_test.rb b/test/mcp/server/transports/stdio_notification_integration_test.rb
@@ -212,7 +212,7 @@ def puts(message)
           # This test verifies the complete integration from server to transport
 
           # Start with no output
-          assert_equal([], @mock_stdout.output)
+          assert_empty(@mock_stdout.output)
 
           # Add a prompt and notify
           @server.define_prompt(
diff --git a/test/mcp/server/transports/stdio_transport_test.rb b/test/mcp/server/transports/stdio_transport_test.rb
@@ -45,7 +45,7 @@ class StdioTransportTest < ActiveSupport::TestCase
             response = JSON.parse(output.string, symbolize_names: true)
             assert_equal("2.0", response[:jsonrpc])
             assert_equal("123", response[:id])
-            assert_equal({}, response[:result])
+            assert_empty(response[:result])
             refute(@transport.instance_variable_get(:@open))
           ensure
             $stdin = original_stdin
diff --git a/test/mcp/server/transports/streamable_http_transport_test.rb b/test/mcp/server/transports/streamable_http_transport_test.rb
@@ -77,7 +77,7 @@ def string
           body = JSON.parse(io.string.match(/^data: (.+)$/)[1])
           assert_equal "2.0", body["jsonrpc"]
           assert_equal "123", body["id"]
-          assert_equal({}, body["result"])
+          assert_empty(body["result"])
         end
 
         test "handles POST request with invalid JSON" do
@@ -278,7 +278,7 @@ def string
 
           body = JSON.parse(response[2][0])
           assert_equal JsonRpcHandler::ErrorCode::INVALID_REQUEST, body["error"]["code"]
-          assert_equal({}, @transport.instance_variable_get(:@sessions))
+          assert_empty(@transport.instance_variable_get(:@sessions))
         end
 
         test "rejects non-Hash JSON-RPC body with HTTP 400 and -32600" do
@@ -766,7 +766,7 @@ def string
           @transport.close
 
           # Verify session was cleaned up
-          assert_equal({}, @transport.instance_variable_get(:@sessions))
+          assert_empty(@transport.instance_variable_get(:@sessions))
         end
 
         test "cleanup_session_unsafe closes request_streams" do
@@ -2086,7 +2086,7 @@ def string
 
           response = stateless_transport.handle_request(request)
           assert_equal 202, response[0]
-          assert_equal({}, response[1])
+          assert_empty(response[1])
 
           body = response[2][0]
           assert_nil(body)
@@ -3410,8 +3410,8 @@ def string
 
           response = @transport.handle_request(notif_request)
           assert_equal 202, response[0]
-          assert_equal({}, response[1])
-          assert_equal([], response[2])
+          assert_empty(response[1])
+          assert_empty(response[2])
         end
 
         test "expired session returns 404 on GET request" do
@@ -3809,8 +3809,8 @@ def string
 
           response = @transport.handle_request(request)
           assert_equal 202, response[0]
-          assert_equal({}, response[1])
-          assert_equal([], response[2])
+          assert_empty(response[1])
+          assert_empty(response[2])
         end
 
         test "POST response without session ID returns 400" do
diff --git a/test/mcp/server_context_test.rb b/test/mcp/server_context_test.rb
@@ -78,7 +78,7 @@ class ServerContextTest < ActiveSupport::TestCase
 
       result = server_context.ping
 
-      assert_equal({}, result)
+      assert_empty(result)
     end
 
     test "ServerContext#ping raises NoMethodError when notification_target does not respond" do
diff --git a/test/mcp/server_roots_test.rb b/test/mcp/server_roots_test.rb
@@ -170,7 +170,7 @@ def close; end
       )
 
       assert_equal({ roots: {} }, server.client_capabilities)
-      assert_equal({}, session.client_capabilities)
+      assert_empty(session.client_capabilities)
     end
 
     test "ServerSession#list_roots uses session-scoped capabilities from HTTP init" do
diff --git a/test/mcp/server_sampling_test.rb b/test/mcp/server_sampling_test.rb
@@ -238,7 +238,7 @@ def close; end
       # Global must still have sampling.
       assert_equal({ sampling: {} }, server.client_capabilities)
       # Session must have its own (empty) capabilities.
-      assert_equal({}, session.client_capabilities)
+      assert_empty(session.client_capabilities)
     end
 
     test "create_sampling_message omits nil optional params" do
diff --git a/test/mcp/server_session_ping_test.rb b/test/mcp/server_session_ping_test.rb
@@ -41,7 +41,7 @@ def handle_request(request); end
 
       result = session.ping
 
-      assert_equal({}, result)
+      assert_empty(result)
       assert_equal(1, @mock_transport.requests.size)
 
       request = @mock_transport.requests.first
@@ -87,7 +87,7 @@ def handle_request(request); end
       session = ServerSession.new(server: @server, transport: @mock_transport)
       assert_nil(session.client_capabilities)
 
-      assert_equal({}, session.ping)
+      assert_empty(session.ping)
     end
   end
 end
diff --git a/test/mcp/server_test.rb b/test/mcp/server_test.rb
@@ -774,7 +774,7 @@ class Example < Tool
 
       assert_equal "2.0", response[:jsonrpc]
       assert_equal 1, response[:id]
-      assert_equal({}, response[:result])
+      assert_empty(response[:result])
       refute response.key?(:error)
     end
 
diff --git a/test/mcp/tool/input_schema_test.rb b/test/mcp/tool/input_schema_test.rb
@@ -79,7 +79,7 @@ class InputSchemaTest < ActiveSupport::TestCase
 
       test "missing_required_arguments returns an empty array if no required arguments are missing" do
         input_schema = InputSchema.new(properties: { message: { type: "string" } }, required: ["message"])
-        assert_equal([], input_schema.missing_required_arguments({ message: "Hello, world!" }))
+        assert_empty(input_schema.missing_required_arguments({ message: "Hello, world!" }))
       end
 
       test "valid schema initialization" do
diff --git a/test/mcp/tool/response_test.rb b/test/mcp/tool/response_test.rb
@@ -107,7 +107,7 @@ class ResponseTest < ActiveSupport::TestCase
         actual = response.to_h
 
         assert_equal [:content, :isError, :structuredContent], actual.keys
-        assert_equal([], actual[:content])
+        assert_empty(actual[:content])
         assert_equal structured_content, actual[:structuredContent]
         refute actual[:isError]
       end
@@ -118,7 +118,7 @@ class ResponseTest < ActiveSupport::TestCase
         actual = response.to_h
 
         assert_equal [:content, :isError, :structuredContent], actual.keys
-        assert_equal([], actual[:content])
+        assert_empty(actual[:content])
         assert_equal structured_content, actual[:structuredContent]
         refute actual[:isError]
       end
