Fix sandbox mount prompt regex scanning

Change-Id: I3be5fd219283020e88121c24cfa8d888915cd2d3

Author: heimanba

packages/sdk/src/internal/utils/sandbox-mount.ts

@@ -26,6 +26,26 @@ function quoteShellWord(value: string): string {
 	return `'${value.replaceAll("'", `'"'"'`)}'`;
 }
 
+function stripUrlQueryAndFragment(value: string): string {
+	const queryIndex = value.indexOf("?");
+	const fragmentIndex = value.indexOf("#");
+	if (queryIndex === -1) {
+		return fragmentIndex === -1 ? value : value.slice(0, fragmentIndex);
+	}
+	if (fragmentIndex === -1) return value.slice(0, queryIndex);
+	return value.slice(0, Math.min(queryIndex, fragmentIndex));
+}
+
+function stripGitSuffix(value: string): string {
+	return value.toLowerCase().endsWith(".git") ? value.slice(0, -4) : value;
+}
+
+function lastRemotePathSegment(value: string): string {
+	const lastSlash = value.lastIndexOf("/");
+	const lastColon = value.lastIndexOf(":");
+	return value.slice(Math.max(lastSlash, lastColon) + 1).trim();
+}
+
 export function providerMountPrefix(provider: string): string | undefined {
 	return PROVIDER_MOUNT_PREFIXES[provider];
 }
@@ -62,12 +82,7 @@ export function resolveRepositoryMountPath(provider: string, resource: SessionGi
 		return resource.mount_path;
 	}
 	// Accept URL remotes as well as scp-like SSH remotes such as git@host:team/repo.git.
-	const repositoryName = resource.url
-		.replace(/[?#].*$/, "")
-		.split(/[/:]/)
-		.filter(Boolean)
-		.at(-1)
-		?.replace(/\.git$/i, "");
+	const repositoryName = stripGitSuffix(lastRemotePathSegment(stripUrlQueryAndFragment(resource.url)));
 	if (!repositoryName) {
 		throw new UserError(`Cannot derive a ${provider} Git repository mount path from URL '${resource.url}'.`);
 	}
@@ -95,13 +110,32 @@ export function prependFileHint(prompt: string, files: MountedFile[] | undefined
 	return `${hint}\n\n${prompt}`;
 }
 
-const FILE_MENTION_SENTINEL_RE = /\u27E6file:(.+?)\u27E7/g;
+const FILE_MENTION_START = "\u27E6file:";
+const FILE_MENTION_END = "\u27E7";
 
 /** 将 prompt 内 ⟦file:mountPath⟧ 占位符替换为 provider 感知的真实 sandbox 路径 */
 export function rewriteFileMentions(prompt: string, provider: string): string {
-	return prompt.replace(FILE_MENTION_SENTINEL_RE, (_match, mountPath: string) =>
-		resolveSandboxMountPath(provider, mountPath),
-	);
+	let cursor = 0;
+	let rewritten = "";
+
+	while (cursor < prompt.length) {
+		const start = prompt.indexOf(FILE_MENTION_START, cursor);
+		if (start === -1) {
+			rewritten += prompt.slice(cursor);
+			break;
+		}
+		const mountPathStart = start + FILE_MENTION_START.length;
+		const end = prompt.indexOf(FILE_MENTION_END, mountPathStart);
+		if (end === -1) {
+			rewritten += prompt.slice(cursor);
+			break;
+		}
+		rewritten += prompt.slice(cursor, start);
+		rewritten += resolveSandboxMountPath(provider, prompt.slice(mountPathStart, end));
+		cursor = end + FILE_MENTION_END.length;
+	}
+
+	return rewritten;
 }
 
 /** 发送给 provider 前统一处理：先替换 mention 占位符，再 prepend 文件 hint */

packages/sdk/tests/unit/sandbox-mount.test.ts

@@ -90,6 +90,19 @@ describe("rewriteFileMentions", () => {
 		expect(rewriteFileMentions(prompt, "bailian")).toBe("see /mnt/uploads/a.png here");
 	});
 
+	test("rewrites multiple sentinels with a linear scanner", () => {
+		const prompt = [`first ${"\u27E6file:uploads/a.png\u27E7"}`, `second ${"\u27E6file:uploads/b.png\u27E7"}`].join(
+			" and ",
+		);
+		expect(rewriteFileMentions(prompt, "qoder")).toBe("first /data/uploads/a.png and second /data/uploads/b.png");
+	});
+
+	test("leaves unterminated sentinels unchanged", () => {
+		const longTail = "x".repeat(10_000);
+		const prompt = `before ${"\u27E6file:uploads/a.png"}${longTail}`;
+		expect(rewriteFileMentions(prompt, "bailian")).toBe(prompt);
+	});
+
 	test("no sentinel → unchanged", () => {
 		expect(rewriteFileMentions("hello", "bailian")).toBe("hello");
 	});
@@ -125,6 +138,23 @@ describe("prepareInitialSessionPrompt", () => {
 		expect(out.endsWith("implement the feature")).toBe(true);
 	});
 
+	test("derives repository names without regex query or fragment stripping", () => {
+		const out = prepareInitialSessionPrompt(
+			"inspect it",
+			bindings([
+				{
+					type: "github_repository",
+					url: "https://git.example.com/team/repo.git?token=abc#readme",
+					authorization_token: "do-not-leak",
+				},
+			]),
+			"qoder",
+		);
+		expect(out).toContain("`/data/workspace/repo`");
+		expect(out).not.toContain("token=abc");
+		expect(out).not.toContain("readme");
+	});
+
 	test("shell-quotes an explicit repository mount path", () => {
 		const out = prepareInitialSessionPrompt(
 			"inspect it",