Skip to content

bug: develop transitions action:develop→action:review even when the agent produced no PR (stop-and-ask outcome) #116

Description

@ellen-goc

Summary

askcc develop unconditionally runs _swap_issue_labels (-action:develop +action:review) and _update_project_field (Status→in-review) after the agent finishes — even when the develop agent deliberately stopped without creating a branch, commits, or a PR (e.g. it discovered the work is already complete, or is blocked on unresolved decisions and asked for direction). The result is a false review state: an issue labeled action:review/in-review with no PR to review, which downstream automation and reviewers then have to detect and manually revert.

The post-develop verification added for #69 checks git status / project verification commands, but does not verify that a PR (or at least a pushed branch with commits) actually exists before transitioning.

Two instances on 2026-07-14 (JST)

  1. weyucou/kadaiko-climbinggym-tracker#4 — agent verified the migration was already complete in the initial commit and correctly declined to open an empty PR. Log:

    Post-develop git status: (clean)
    _run_project_verification: No verification commands detected ... skipping
    _swap_issue_labels: Transitioned labels: -action:develop +action:review on issue #4
    _update_project_field: Updated 'Status' ... for issue #4
    

    Same issue had already been reverted from an identical false state on 2026-07-12.

  2. Conformance check MCP tool: ibuki check (pillar 5) weyucou/ibuki#3 — agent found the work blocked on a pillar-1 dependency + 4 open design decisions and stopped to ask for direction (its final output was an options question, not a PR). Log showed Post-develop git status: ?? .claude/ then the same unconditional transition. Second occurrence of the false state on this issue as well.

Expected

Before transitioning labels/status, verify develop produced a reviewable artifact — e.g. gh pr list --head <branch> returns a PR, or at minimum new commits exist on a pushed non-main branch. If not, leave action:develop/planned in place (optionally comment that develop ended without a PR).

Environment

askcc via ~/.local/bin/askcc (uv tool install), invoked as askcc --cwd <repo> develop -g <issue-url> through ellen-core's detached wrapper.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions