Skip to content

Fix audit Pigeon callback completion#1029

Open
Ashish-Kumar-Dash wants to merge 1 commit into
mosip:masterfrom
Ashish-Kumar-Dash:fix/audit-pigeon-callback
Open

Fix audit Pigeon callback completion#1029
Ashish-Kumar-Dash wants to merge 1 commit into
mosip:masterfrom
Ashish-Kumar-Dash:fix/audit-pigeon-callback

Conversation

@Ashish-Kumar-Dash
Copy link
Copy Markdown

Summary

Ensured the audit Pigeon call always completes by returning [result.success(null)] in a finally block and logging unknown audit IDs so await calls never hang. This change is isolated to the Android host implementation where the callback is owned: [AuditDetailsApi.java:36-52]
Fixes made-

  • Always complete the Audit Pigeon callback to prevent await hangs
  • Log unknown audit event IDs for easier diagnostics

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 29, 2026

Warning

Rate limit exceeded

@Ashish-Kumar-Dash has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 57 minutes and 35 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 698c4be0-77de-4205-930d-240aad008150

📥 Commits

Reviewing files that changed from the base of the PR and between aef4fb6 and 71a2d03.

📒 Files selected for processing (1)
  • android/app/src/main/java/io/mosip/registration_client/api_services/AuditDetailsApi.java
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 57 minutes and 35 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Ashish Kumar Dash ashishdash2410@gmail.com
Signed-off-by: Ashish Kumar Dash <ashishdash2410@gmail.com>
@Ashish-Kumar-Dash Ashish-Kumar-Dash force-pushed the fix/audit-pigeon-callback branch from d16ef31 to 71a2d03 Compare April 29, 2026 19:52
@Ashish-Kumar-Dash
Copy link
Copy Markdown
Author

@Pragya279 @SachinPremkumar I found this observation while going through the codebase and since it's a small effort change, raised a PR directly. This change ensures audit telemetry calls never hang the Flutter UI because the Pigeon callback now always completes. It makes telemetry reliable, which is critical for user flows and aligns with the DMP project’s telemetry goals. It also surfaces unknown audit IDs for easier tracking of event coverage. Do let me know your thoughts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant