Fix audit Pigeon callback completion#1029
Conversation
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 57 minutes and 35 seconds.Comment |
Signed-off-by: Ashish Kumar Dash ashishdash2410@gmail.com Signed-off-by: Ashish Kumar Dash <ashishdash2410@gmail.com>
d16ef31 to
71a2d03
Compare
|
@Pragya279 @SachinPremkumar I found this observation while going through the codebase and since it's a small effort change, raised a PR directly. This change ensures audit telemetry calls never hang the Flutter UI because the Pigeon callback now always completes. It makes telemetry reliable, which is critical for user flows and aligns with the DMP project’s telemetry goals. It also surfaces unknown audit IDs for easier tracking of event coverage. Do let me know your thoughts |
Summary
Ensured the audit Pigeon call always completes by returning [result.success(null)] in a finally block and logging unknown audit IDs so await calls never hang. This change is isolated to the Android host implementation where the callback is owned: [AuditDetailsApi.java:36-52]
Fixes made-