RCF-888: Add not uploaded server status filter#1031
Open
officialasishkumar wants to merge 2 commits into
Open
Conversation
Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
✅ Files skipped from review due to trivial changes (7)
WalkthroughAdds a "NOT UPLOADED" server-status filter option and centralizes packet-filtering logic in the provider via a Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@lib/ui/export_packet/widgets/server_status_dropdown.dart`:
- Around line 28-30: Replace the hardcoded "NOT UPLOADED" string in the
DropdownMenuItem used for ExportPacketsProvider.notUploadedServerStatusFilter
with the localized string from AppLocalizations; locate the DropdownMenuItem in
server_status_dropdown.dart (the item whose value is
ExportPacketsProvider.notUploadedServerStatusFilter) and change its child Text
to use AppLocalizations.of(context).<keyName> (add a new key like notUploaded in
the AppLocalizations ARB and regenerate localization files if needed) so the UI
reads the localized string instead of the literal.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: a51a45d5-39e6-483e-b731-a96d6bd3a2ec
📒 Files selected for processing (2)
lib/provider/export_packet_provider.dartlib/ui/export_packet/widgets/server_status_dropdown.dart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RCF-888
Fixes #925
Summary
NOT UPLOADEDoption to the Manage Applications server status filter.Validation
git diff --checkFlutter/Dart tooling was not available in the local shell, so formatter/analyzer checks could not be run locally.
Summary by CodeRabbit
New Features
Improvements
Localization