RCF-1283 added config propertys for password validation and document size

[MadhuMosip]

Summary by CodeRabbit

• New Features

  • Password validation and password input enable/disable now use a configurable length fetched from the platform.
  • Document uploads enforce a configurable file-size limit (default 2 MB) with client-side checks and user-facing error messages.
  • DOB entry enforces a configurable maximum age, updates date-picker bounds, and adds age-aware validation with autovalidation.

• Localization

  • Added localized messages for file-size and age-limit errors across multiple languages.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Adds three runtime parameters (password length, document size, DOB max age) end-to-end: new constants and cache getters, Pigeon host APIs and Android implementations, Dart SPI/implementations, provider/state updates, UI validation/enforcement changes, DI update, and new localized strings.

Changes

Cohort / File(s)	Summary
Configuration Constants android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java	Added PWORD_LENGTH, DOC_SIZE, and MAX_AGE constants.
Repository Cache Methods android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java	Added getters getCachedStringPasswordLength(), getCachedStringDocumentSize(), and getCachedStringDOBAgeLimit().
Pigeon Interfaces pigeon/auth_response.dart, pigeon/document_category.dart, pigeon/demographics_data.dart	Added host API methods getPasswordLength(), getDocumentSize(), and getDOBMaxAge() returning String.
Android Host Implementations android/app/src/main/java/io/mosip/registration_client/api_services/AuthenticationApi.java, .../DocumentCategoryApi.java, .../DemographicsDetailsApi.java	Implemented getPasswordLength, getDocumentSize, and getDOBMaxAge reading from GlobalParamRepository; added globalParamRepository field and constructor update in DemographicsDetailsApi.
Host DI Update android/app/src/main/java/io/mosip/registration_client/HostApiModule.java	getDemographicsDetailsApi signature updated to accept and pass GlobalParamRepository.
Dart Platform SPI Interfaces lib/platform_spi/auth_service.dart, lib/platform_spi/document_category_service.dart, lib/platform_spi/demographic_service.dart	Added abstract methods Future<String> getPasswordLength(), getDocumentSize(), and getDOBMaxAge().
Dart Platform Implementations lib/platform_android/auth_service_impl.dart, lib/platform_android/document_category_impl.dart, lib/platform_android/demographic_service_impl.dart	Implemented async calls to Pigeon host APIs with exception handling; return String (empty on failure).
State / Provider lib/provider/auth_provider.dart	Added _passwordLength field, passwordLength getter, and getPasswordLength() that fetches and notifies listeners.
Login UI lib/ui/login_page.dart	Replaced hardcoded password-length threshold with dynamic authProvider.passwordLength (fallback 50) for validation and password input enable/disable.
Document Upload UI lib/ui/process_ui/widgets/document_upload_control.dart	Added maxFileSize (default 2 MB), _fetchMaxFileSize(), client-side size validation rejecting oversized Uint8List with localized doc_size_exceeded message.
DOB / Age UI lib/ui/process_ui/widgets/age_date_control.dart	Added maxAge (default 150), _getDOBMaxAge() to fetch limit, dynamic minDate and validation enforcing age ≤ maxAge, UI alignment and autovalidation tweaks.
Localization assets/l10n/*.arb (app_en.arb, app_ar.arb, app_fr.arb, app_hi.arb, app_kn.arb, app_ta.arb)	Added doc_size_exceeded and age_should_not_be_greater translations with placeholder metadata in multiple languages.

Sequence Diagram(s)

sequenceDiagram
    participant UI as Flutter UI
    participant Provider as AuthProvider / Doc UI
    participant SPI as Dart Platform SPI
    participant Host as Android Pigeon Host API
    participant Repo as GlobalParamRepository

    UI->>Provider: request config (passwordLength / docSize / maxAge)
    Provider->>SPI: getPasswordLength()/getDocumentSize()/getDOBMaxAge()
    SPI->>Host: Pigeon API call (async)
    Host->>Repo: read cached param (PWORD_LENGTH / DOC_SIZE / MAX_AGE)
    Repo-->>Host: return value (String)
    Host-->>SPI: result.success(value)
    SPI-->>Provider: Future resolves with value
    Provider-->>UI: notify listeners (update validation / UI)

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

• Files to focus on:
  • lib/ui/process_ui/widgets/age_date_control.dart — date parsing, age calculation, minDate logic, localized error.
  • lib/ui/process_ui/widgets/document_upload_control.dart — byte/MB conversions, init timing of maxFileSize, error messaging.
  • lib/provider/auth_provider.dart & lib/ui/login_page.dart — parsing passwordLength, fallback and null-safety.
  • Android DI/constructor change — HostApiModule and DemographicsDetailsApi wiring.

Poem

🐰 A nibble of config, a hop and a cheer,
Limits fetched from cache now whisper near.
Passwords, files, and ages align just right,
Host and UI chatter through day and night.
Tiny paws validate — hop, all is bright!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding configuration properties for password validation and document size validation. It aligns well with the changeset which adds constants, repository methods, API methods, and UI validation logic for these features across multiple files.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

♻️ Duplicate comments (3)

assets/l10n/app_hi.arb (1)

335-336: Align doc_size_existed with other parameterized messages

Same note as in the English/Kannada ARBs: consider adding an @doc_size_existed block that defines the size placeholder (type and example) so generation/tooling stays consistent across locales.

assets/l10n/app_fr.arb (1)

335-336: Keep placeholder metadata consistent for doc_size_existed

The French text correctly mirrors the other locales. As with the other ARBs, consider adding an @doc_size_existed entry describing the {size} placeholder for clarity and generator support.

assets/l10n/app_ta.arb (1)

344-345: Match doc_size_existed placeholder metadata with other locales

The Tamil translation and {size} placeholder align with the other languages. As with the other ARBs, consider adding an @doc_size_existed entry defining the size placeholder to keep metadata and generators uniform.

🧹 Nitpick comments (9)

assets/l10n/app_kn.arb (1)

335-336: Add optional placeholder metadata for {size}

The new doc_size_existed key looks fine. For consistency with other parameterized messages in this ARB, consider adding an @doc_size_existed block declaring the size placeholder (e.g., type String, example like "5 MB"), so tooling and future contributors have clearer context.

assets/l10n/app_en.arb (1)

335-336: Consider metadata and wording polish for doc_size_existed

The key and usage are clear. Two optional tweaks:

• Add an @doc_size_existed section describing the size placeholder for parity with other parameterized messages.
• If you ever revisit text, File size must not exceed {size} (or similar) reads a bit more naturally, but current wording is acceptable.

pigeon/document_category.dart (1)

8-10: Pigeon API addition looks good; verify regeneration and null-handling

The new @async String getDocumentSize(); fits the existing DocumentCategoryApi pattern. Please double‑check that:

• Pigeon codegen has been re-run so Flutter/Android stubs include this method.
• The native implementation returns a non-null value (e.g., empty string or default) when the DOC_SIZE global param is missing, to avoid unexpected null in the Dart layer.

If document_size is conceptually numeric (e.g., bytes/MB), you might later consider exposing it as an int to avoid parsing in Flutter, but the current string contract is workable.

lib/platform_android/auth_service_impl.dart (1)

140-151: Consider initializing the late variable for defensive programming.

The implementation follows the existing pattern in this file, but the late String passwordLength; could throw if an exception occurs before assignment. Consider initializing with a default value:

-    late String passwordLength;
+    String passwordLength = "";

This would align with the error handling approach in lib/platform_android/document_category_impl.dart (line 24) and prevent potential runtime errors.

Note: This pattern exists throughout the file, so this is a broader codebase consideration rather than an issue specific to this change.

android/app/src/main/java/io/mosip/registration_client/api_services/AuthenticationApi.java (1)

269-277: Consider fixing the error message capitalization.

The implementation correctly follows the pattern of other getter methods in this class. However, the error message has inconsistent capitalization:

-            Log.e(getClass().getSimpleName(), "Getting password Length failed!" + Arrays.toString(e.getStackTrace()));
+            Log.e(getClass().getSimpleName(), "Getting password length failed!" + Arrays.toString(e.getStackTrace()));

Compare with line 265: "Getting user role failed!" which uses lowercase.

Otherwise, the error handling and repository delegation are correct.

android/app/src/main/java/io/mosip/registration_client/api_services/DocumentCategoryApi.java (1)

96-105: getDocumentSize implementation is fine; consider tightening logging/exception handling

The method correctly degrades to "" on failure, which fits the client-side fallback behavior. Two small optional improvements:

• Prefer Log.e(tag, msg, e) instead of Arrays.toString(e.getStackTrace()) for clearer logs and to match common Android practices.
• If you know what getCachedStringDocumentSize() can throw (e.g., IO/JSON/config errors), consider catching more specific exceptions to avoid hiding unrelated issues.

lib/ui/process_ui/widgets/document_upload_control.dart (2)

51-67: Async _fetchMaxFileSize is correct; guard against setState-after-dispose and clarify units

The fetch and parsing logic looks good and falls back cleanly to the 2MB default. Two follow-ups to consider:

• Add a mounted guard before calling setState since this is async; otherwise you can hit setState() called after dispose() if the widget is torn down while the platform call is in flight:

Future<void> _fetchMaxFileSize() async {
  try {
    final sizeStr = await registrationTaskProvider.documentCategory.getDocumentSize();
    if (!mounted) return;
    if (sizeStr.isNotEmpty) {
      final size = int.tryParse(sizeStr);
      if (size != null && size > 0) {
        setState(() => maxFileSize = size);
      }
    }
  } catch (e) {
    debugPrint('Failed to fetch document size limit: $e');
  }
}

• Confirm that mosip.registration.document_size is defined in bytes (not KB/MB) so that the comparison with Uint8List.lengthInBytes remains correct.

Also applies to: 88-89

---

190-199: File-size validation works; consider messaging the limit rather than the actual size

The null guard and Uint8List check are good, and rejecting files larger than maxFileSize before calling the provider is correct.

One UX nit: you’re passing the uploaded file’s size into doc_size_existed, not the configured limit:

final msg = AppLocalizations.of(context)!
    .doc_size_existed(getReadableFileSize(item.lengthInBytes));

If the localized string is phrased as “Max allowed size is {size}”, you likely want getReadableFileSize(maxFileSize) instead so the user sees the limit, not just how big their file was. If the message is “You tried to upload a file of size {size}…”, then the current behavior is fine.

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java (1)

120-121: Make new config keys final to match other constants

PWORD_LENGTH and DOC_SIZE are used as constant keys and don’t appear to need mutation. To align with the rest of this class and prevent accidental reassignment, consider:

-    public static String PWORD_LENGTH = "mosip.registration.username_pwd_length";
-    public static String DOC_SIZE = "mosip.registration.document_size";
+    public static final String PWORD_LENGTH = "mosip.registration.username_pwd_length";
+    public static final String DOC_SIZE = "mosip.registration.document_size";

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 99fba14 and 4f32096.

📒 Files selected for processing (19)

• android/app/src/main/java/io/mosip/registration_client/api_services/AuthenticationApi.java (1 hunks)
• android/app/src/main/java/io/mosip/registration_client/api_services/DocumentCategoryApi.java (1 hunks)
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java (1 hunks)
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java (1 hunks)
• assets/l10n/app_ar.arb (1 hunks)
• assets/l10n/app_en.arb (1 hunks)
• assets/l10n/app_fr.arb (1 hunks)
• assets/l10n/app_hi.arb (1 hunks)
• assets/l10n/app_kn.arb (1 hunks)
• assets/l10n/app_ta.arb (1 hunks)
• lib/platform_android/auth_service_impl.dart (1 hunks)
• lib/platform_android/document_category_impl.dart (1 hunks)
• lib/platform_spi/auth_service.dart (1 hunks)
• lib/platform_spi/document_category_service.dart (1 hunks)
• lib/provider/auth_provider.dart (3 hunks)
• lib/ui/login_page.dart (3 hunks)
• lib/ui/process_ui/widgets/document_upload_control.dart (3 hunks)
• pigeon/auth_response.dart (1 hunks)
• pigeon/document_category.dart (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java (1)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java (1)

• RegistrationConstants (9-122)

🔇 Additional comments (11)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java (1)

161-167: New cached getters are consistent with existing repository patterns

Both getCachedStringPasswordLength() and getCachedStringDocumentSize() follow the same style as other string accessors in this class and correctly use the new RegistrationConstants keys. No issues from this side.

lib/platform_spi/document_category_service.dart (1)

6-7: Interface extension aligns with Pigeon API; ensure non-null contract is upheld

Adding Future<String> getDocumentSize(); here cleanly exposes the new capability. Since the return type is non-nullable, please confirm the platform implementation always maps missing config or errors to a concrete string (e.g., empty string or a default limit) rather than propagating null, to keep callers’ logic simple.

lib/ui/login_page.dart (3)

110-110: LGTM! Password length initialization is correctly placed.

The password length is fetched during app data initialization, ensuring the dynamic configuration is available before the login UI is rendered.

---

281-284: Good defensive programming with the fallback value.

The password validation correctly uses int.tryParse with a fallback to 50, which handles cases where the configuration value might be missing, empty, or invalid. This maintains backward compatibility with the original hardcoded limit.

---

517-517: Consistent dynamic validation in the disabled state check.

The password length limit is applied consistently in both the validation logic (line 281) and the disabled state check. This ensures a unified user experience.

pigeon/auth_response.dart (1)

43-44: LGTM! Clean API extension.

The new getPasswordLength() method follows the established pattern of other async methods in the AuthResponseApi interface.

lib/platform_spi/auth_service.dart (1)

34-34: LGTM! Interface extension is well-defined.

The new getPasswordLength() method is properly defined in the platform SPI, maintaining consistency with the existing method signatures.

assets/l10n/app_ar.arb (1)

335-336: LGTM! Localization entry is properly formatted.

The new doc_size_existed key supports dynamic file size validation messages with a {size} placeholder. The Arabic translation is correctly formatted.

lib/provider/auth_provider.dart (1)

37-37: LGTM! Provider implementation follows established patterns.

The password length state management is implemented consistently:

• Private field initialized with a sensible default (empty string)
• Public getter for external access
• Async fetch method that updates state and notifies listeners

This aligns with the pattern used for other configuration values like idleTime and forgotPasswordUrl.

Also applies to: 61-61, 248-252

lib/platform_android/document_category_impl.dart (1)

22-33: LGTM! Implementation is consistent and defensive.

The getDocumentSize() method correctly follows the same pattern as getDocumentCategories():

• Initializes with a default value (empty string)
• Handles both PlatformException and general exceptions
• Returns a safe default on failure

This defensive initialization prevents potential runtime errors.

lib/ui/process_ui/widgets/document_upload_control.dart (1)

69-72: SnackBar-based _showError is straightforward and appropriate

Using ScaffoldMessenger.of(context).showSnackBar with a red background is a reasonable UX pattern here and keeps error display localized to this widget.

[coderabbitai]

Actionable comments posted: 3

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

lib/ui/process_ui/widgets/age_date_control.dart (1)

353-359: Age field missing maxAge validation.

The date field validates against maxAge, but the age input field does not. A user can enter an age greater than maxAge directly in the age field, bypassing the validation. The _getDateFromAge method will then calculate a date outside the valid range.

Apply this diff to add consistent validation:

                        validator: (value) {
                          if (widget.field.required == true && (value == null || value.isEmpty)) {
                            return AppLocalizations.of(context)!
                                .select_value_message;
                          }
+                         if (value != null && value.isNotEmpty) {
+                           final age = int.tryParse(value);
+                           if (age != null && age > maxAge) {
+                             return AppLocalizations.of(context)!.age_should_not_be_greater(maxAge);
+                           }
+                         }
                          return null;
                        },

🧹 Nitpick comments (2)

assets/l10n/app_hi.arb (1)

335-337: New Hindi strings look good; consider adding placeholder metadata for consistency

The translations for doc_size_existed and age_should_not_be_greater read correctly in Hindi and the {size} / {age} placeholders are used in a standard way. For consistency with other entries that define placeholders (e.g., @number_of_application, @language_mandatory), you may want to add matching @doc_size_existed and @age_should_not_be_greater blocks specifying placeholder types and example values, if your tooling relies on that metadata.

lib/ui/process_ui/widgets/age_date_control.dart (1)

308-310: Use debugPrint instead of print.

For consistency with the rest of the codebase and to ensure the output is properly stripped in release builds, use debugPrint instead of print.

                            } catch (e) {
-                             print(e);
+                             debugPrint('Date parse error: $e');
                            }

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4f32096 and 0a8174b.

📒 Files selected for processing (14)

• android/app/src/main/java/io/mosip/registration_client/HostApiModule.java (1 hunks)
• android/app/src/main/java/io/mosip/registration_client/api_services/DemographicsDetailsApi.java (3 hunks)
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java (1 hunks)
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java (1 hunks)
• assets/l10n/app_ar.arb (1 hunks)
• assets/l10n/app_en.arb (1 hunks)
• assets/l10n/app_fr.arb (1 hunks)
• assets/l10n/app_hi.arb (1 hunks)
• assets/l10n/app_kn.arb (1 hunks)
• assets/l10n/app_ta.arb (1 hunks)
• lib/platform_android/demographic_service_impl.dart (1 hunks)
• lib/platform_spi/demographic_service.dart (1 hunks)
• lib/ui/process_ui/widgets/age_date_control.dart (6 hunks)
• pigeon/demographics_data.dart (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (5)

• assets/l10n/app_fr.arb
• assets/l10n/app_kn.arb
• assets/l10n/app_en.arb
• assets/l10n/app_ta.arb
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java

🧰 Additional context used

🧬 Code graph analysis (2)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java (1)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java (1)

• RegistrationConstants (9-123)

android/app/src/main/java/io/mosip/registration_client/api_services/DemographicsDetailsApi.java (1)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java (1)

• GlobalParamRepository (21-198)

🔇 Additional comments (8)

pigeon/demographics_data.dart (1)

48-51: LGTM!

The new getDOBMaxAge() method follows the existing Pigeon interface pattern with the @async annotation and appropriate return type.

lib/platform_spi/demographic_service.dart (1)

38-39: LGTM!

The new getDOBMaxAge() method signature aligns with the existing interface contract and the implementation in DemographicServiceImpl.

lib/platform_android/demographic_service_impl.dart (1)

167-178: LGTM!

The implementation follows the established error-handling pattern used throughout this file, with appropriate PlatformException and general exception handling, returning an empty string on failure.

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java (1)

161-171: LGTM!

The three new getter methods follow the established pattern of other getCachedString* methods in this repository. They correctly delegate to globalParamMap.get() using the appropriate constants.

android/app/src/main/java/io/mosip/registration_client/api_services/DemographicsDetailsApi.java (1)

34-41: LGTM on dependency injection.

The GlobalParamRepository dependency is properly injected via the constructor, consistent with the existing pattern for other dependencies in this class.

lib/ui/process_ui/widgets/age_date_control.dart (2)

41-41: LGTM on default maxAge initialization.

The default value of 150 is a reasonable fallback while the actual configured value is being fetched asynchronously.

---

158-161: LGTM on capturing maxAge for closure.

Capturing maxAge into localMaxAge before passing to the modal ensures the picker uses a consistent value even if maxAge changes during the modal's lifecycle.

android/app/src/main/java/io/mosip/registration_client/HostApiModule.java (1)

169-171: LGTM!

The dependency injection change is implemented correctly and follows the established pattern used by other provider methods in this module (e.g., AuthenticationApi at line 122, BiometricsDetailsApi at line 146). The addition of GlobalParamRepository properly enables DemographicsDetailsApi to access the new configurable parameters for DOB validation.

[coderabbitai]

Actionable comments posted: 1

♻️ Duplicate comments (1)

assets/l10n/app_ar.arb (1)

335-351: Metadata addition is correct; consider global rename of doc_size_existed only if you want to fix the typo.

The new Arabic messages and placeholder metadata are structurally correct and consistent with other locales. If you still want to address the earlier‑flagged naming typo (doc_size_existed → doc_size_exceeded or similar), it should be done in a single sweep across all locales and Dart/Android usages to avoid broken lookups; otherwise it’s fine to keep as‑is for stability.

🧹 Nitpick comments (1)

android/app/src/main/java/io/mosip/registration_client/api_services/DemographicsDetailsApi.java (1)

34-35: Consider making the field private final for consistency.

The registrationService field at line 30 is declared as private final, which is the recommended practice for injected dependencies. Consider applying the same pattern here.

Apply this diff:

-    GlobalParamRepository globalParamRepository;
+    private final GlobalParamRepository globalParamRepository;

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0a8174b and 5afdabb.

📒 Files selected for processing (8)

• android/app/src/main/java/io/mosip/registration_client/api_services/DemographicsDetailsApi.java (3 hunks)
• assets/l10n/app_ar.arb (1 hunks)
• assets/l10n/app_en.arb (1 hunks)
• assets/l10n/app_fr.arb (1 hunks)
• assets/l10n/app_hi.arb (1 hunks)
• assets/l10n/app_kn.arb (1 hunks)
• assets/l10n/app_ta.arb (1 hunks)
• lib/ui/process_ui/widgets/age_date_control.dart (6 hunks)

🚧 Files skipped from review as they are similar to previous changes (4)

• assets/l10n/app_en.arb
• assets/l10n/app_ta.arb
• assets/l10n/app_hi.arb
• lib/ui/process_ui/widgets/age_date_control.dart

🧰 Additional context used

🧬 Code graph analysis (1)

android/app/src/main/java/io/mosip/registration_client/api_services/DemographicsDetailsApi.java (1)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java (1)

• GlobalParamRepository (21-198)

🔇 Additional comments (4)

android/app/src/main/java/io/mosip/registration_client/api_services/DemographicsDetailsApi.java (2)

21-21: LGTM!

The import is necessary for the new GlobalParamRepository dependency.

---

37-41: LGTM!

The constructor properly injects and assigns the GlobalParamRepository dependency.

assets/l10n/app_fr.arb (1)

335-351: New French validation messages and metadata look consistent.

Keys, messages, and placeholder metadata follow the existing ARB patterns and align with other locales; ARB structure is valid as well.

assets/l10n/app_kn.arb (1)

335-351: Kannada messages and placeholder metadata are well‑formed and aligned with other locales.

Structure, key names, and placeholder types match the established pattern; no issues from an i18n/ARB standpoint.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (2)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java (2)

120-120: Consider clarifying the config key name.

The constant name PWORD_LENGTH suggests password-specific validation, but the config key mosip.registration.username_pwd_length implies it might apply to both username and password. Based on the context (used by AuthenticationApi.getPasswordLength()), this appears to be password-specific. Consider renaming the config key to mosip.registration.password_length for clarity.

Apply this diff to improve naming clarity:

-    public static final String PWORD_LENGTH = "mosip.registration.username_pwd_length";
+    public static final String PWORD_LENGTH = "mosip.registration.password_length";

---

122-122: Use more specific naming for DOB age limit.

The constant name MAX_AGE is too generic. Based on the usage context (getCachedStringDOBAgeLimit()), this represents the maximum DOB age limit. Consider renaming to DOB_MAX_AGE and updating the config key to mosip.registration.dob.max_age for better clarity. Also, remove the extra space before String.

Apply this diff:

-    public static final  String MAX_AGE = "mosip.registration.max_age";
+    public static final String DOB_MAX_AGE = "mosip.registration.dob.max_age";

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a8437e6 and d7663ac.

📒 Files selected for processing (8)

• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java (1 hunks)
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java (1 hunks)
• assets/l10n/app_ar.arb (1 hunks)
• assets/l10n/app_en.arb (1 hunks)
• assets/l10n/app_fr.arb (1 hunks)
• assets/l10n/app_hi.arb (1 hunks)
• assets/l10n/app_kn.arb (1 hunks)
• assets/l10n/app_ta.arb (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (6)

• assets/l10n/app_fr.arb
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java
• assets/l10n/app_ar.arb
• assets/l10n/app_hi.arb
• assets/l10n/app_ta.arb
• assets/l10n/app_kn.arb

🔇 Additional comments (2)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java (1)

121-121: LGTM!

The constant naming and config key are clear and consistent.

assets/l10n/app_en.arb (1)

344-351: LGTM!

The age validation localization entry is well-structured with a clear message and appropriate placeholder type (int).

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (4)

assets/l10n/app_fr.arb (2)

336-343: Consider consistent indentation and adding a description field.

The metadata block uses different indentation spacing compared to existing entries in the file (e.g., lines 65-72 use 4/6/8 spaces vs. 7/9/11 here). Additionally, other metadata blocks include a "description" field which is missing here.

Apply this diff for consistency:

 "doc_size_exceeded": "La taille du fichier dépasse la limite de {size}",
 "@doc_size_exceeded": {
-     "placeholders": {
-       "size": {
-         "type": "String"
-       }
-     }
+    "description": "Document size exceeded message",
+    "placeholders": {
+      "size": {
+        "type": "String"
+      }
+    }
 },

---

344-351: Consider consistent indentation and adding a description field.

Similar to the previous entry, the metadata block uses inconsistent indentation and lacks a "description" field present in other entries.

Apply this diff for consistency:

 "age_should_not_be_greater": "L'âge ne doit pas dépasser {age} ans.",
 "@age_should_not_be_greater": {
-     "placeholders": {
-          "age": {
-          "type": "int"
-          }
-     }
+    "description": "Age validation message",
+    "placeholders": {
+      "age": {
+        "type": "int"
+      }
+    }
 }

lib/ui/process_ui/widgets/document_upload_control.dart (1)

191-199: Consider showing the size limit in the error message.

The validation logic correctly enforces the file size limit. However, the error message only displays the actual file size, not the maximum allowed size. Including both values would provide clearer guidance to users.

Consider updating the error message:

     if (item is Uint8List) {
       if (item.lengthInBytes > maxFileSize) {
         final msg = AppLocalizations.of(context)!
-            .doc_size_exceeded(getReadableFileSize(item.lengthInBytes));
+            .doc_size_exceeded("${getReadableFileSize(item.lengthInBytes)} / ${getReadableFileSize(maxFileSize)}");
         _showError(msg);
         return;
       }

Alternatively, consider adding a separate localization key that accepts both parameters.

assets/l10n/app_en.arb (1)

336-343: LGTM: New document size validation message.

The localization entry is correctly structured. The key name accurately reflects the validation ("exceeded" vs past typo "existed"), and the String type for the size placeholder appropriately supports formatted values like "5 MB".

For consistency with the rest of the file, consider standardizing indentation to 2 spaces per level:

  "@doc_size_exceeded": {
-     "placeholders": {
-       "size": {
-         "type": "String"
-       }
-     }
+    "placeholders": {
+      "size": {
+        "type": "String"
+      }
+    }
  },

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eed0dbd and 74ffdcc.

📒 Files selected for processing (7)

• assets/l10n/app_ar.arb (1 hunks)
• assets/l10n/app_en.arb (1 hunks)
• assets/l10n/app_fr.arb (1 hunks)
• assets/l10n/app_hi.arb (1 hunks)
• assets/l10n/app_kn.arb (1 hunks)
• assets/l10n/app_ta.arb (1 hunks)
• lib/ui/process_ui/widgets/document_upload_control.dart (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• assets/l10n/app_ta.arb
• assets/l10n/app_ar.arb

🔇 Additional comments (9)

assets/l10n/app_kn.arb (2)

335-335: LGTM!

The localization key for scheduled job settings is correctly added.

---

336-351: LGTM! Technical implementation is correct.

The ARB structure, placeholder syntax, and metadata definitions are properly implemented:

• doc_size_exceeded uses String type for {size}, appropriate for formatted values like "10MB"
• age_should_not_be_greater uses int type for {age}, appropriate for numeric values

Note: I cannot verify the accuracy of the Kannada translations. Ensure these strings have been reviewed by a native speaker or localization team.

lib/ui/process_ui/widgets/document_upload_control.dart (4)

51-52: LGTM! Reasonable default fallback.

The 2MB default provides a sensible fallback if the API call to fetch the configured limit fails or hasn't completed yet.

---

53-67: LGTM! Proper async handling and validation.

The method correctly fetches the document size limit, validates it's positive, and handles errors gracefully with appropriate logging.

---

69-72: LGTM! Clean error display helper.

The error snackbar implementation is straightforward and uses appropriate styling for error messages.

---

88-88: Inconsistency with AI summary regarding second API call.

The AI summary states that _fetchMaxFileSize is invoked "during initialization (initState) and again after loading document type data." However, the code only shows a single call here in initState (line 88). There is no second invocation after myGetDocumentCategoryFuture completes or after the document type data loads.

If fetching the document size limit after loading document types is intended behavior, the second call may be missing.

assets/l10n/app_hi.arb (1)

336-351: LGTM! Proper localization format.

The new localization keys are correctly structured with appropriate placeholder types and proper Hindi translations. The doc_size_exceeded key is properly utilized in the document upload validation, and both keys follow the existing ARB file conventions.

assets/l10n/app_en.arb (2)

335-335: LGTM: Trailing comma addition.

Adding the trailing comma is good practice for JSON/ARB files, ensuring consistency when new entries are added.

---

344-351: LGTM: New age validation message properly integrated.

Both new localization keys are correctly referenced in the Dart codebase:

• age_should_not_be_greater is used in age_date_control.dart with the maxAge parameter
• doc_size_exceeded is used in document_upload_control.dart with the file size parameter

For consistency, align the indentation to 2 spaces per level. The placeholders and nested fields currently use 5 and 10 spaces respectively instead of the standard 4 and 6 spaces.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 74ffdcc and 8e360ff.

📒 Files selected for processing (8)

• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java (1 hunks)
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java (1 hunks)
• assets/l10n/app_ar.arb (1 hunks)
• assets/l10n/app_en.arb (1 hunks)
• assets/l10n/app_fr.arb (1 hunks)
• assets/l10n/app_hi.arb (1 hunks)
• assets/l10n/app_kn.arb (1 hunks)
• assets/l10n/app_ta.arb (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (5)

• assets/l10n/app_kn.arb
• assets/l10n/app_ar.arb
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java
• assets/l10n/app_hi.arb
• assets/l10n/app_fr.arb

🔇 Additional comments (4)

assets/l10n/app_en.arb (1)

333-348: LGTM! Clean localization additions.

Both localization entries are well-structured with appropriate placeholder types:

• doc_size_exceeded: String placeholder for formatted size values (e.g., "10MB")
• age_should_not_be_greater: int placeholder for numeric age values

The messages are clear and follow the established ARB format.

assets/l10n/app_ta.arb (1)

342-357: LGTM! Consistent Tamil translations.

The localization entries maintain consistency with the English version:

• Placeholder names (size, age) match across locales
• Placeholder types (String, int) are consistent
• Metadata structure follows the established pattern

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java (2)

120-120: Verify the config key name matches its actual scope.

The constant name PWORD_LENGTH suggests this config controls password length only, but the key value "mosip.registration.username_pwd_length" suggests it applies to both username and password length. According to the context, this is used by getPasswordLength() for password validation.

Please confirm whether this config key is intended for password only, or both username and password. If it's password-only, consider whether the config key name should be updated for clarity, or if this name is maintained for backward compatibility with existing configuration.

---

120-122: Constants added correctly for new configuration parameters.

The three new configuration constants follow the existing pattern and naming convention in the file. They appropriately support password validation, document size limits, and DOB age validation throughout the application.