[MOSIP-42820] prechecks enabled and severbaseurl to be dynamic

[Ivanmeneges]

Summary by CodeRabbit

Release Notes

• Chores
  • Updated build workflow trigger mechanism to use manual dispatch with configurable base URL input
  • Enhanced build validation pipeline with additional pre-build and code quality checks
  • Streamlined build artifact generation and output structure
  • Removed external code analysis tool integration from build process
  • Updated build orchestration and dependency management

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

These changes restructure GitHub Actions workflows for the Android Registration Client. The build-android.yml receives a minor indentation adjustment. The push_trigger.yml undergoes substantial restructuring: renamed to "ARC Build With Pre-Checks," switches from automatic push/pull_request triggers to manual workflow_dispatch with a serverBaseURL input parameter, adds DCO validation, reworks CodeQL analysis, replaces build checks with pre-build validation and APK build stages, and removes SonarCloud integration.

Changes

Cohort / File(s)	Summary
Indentation adjustment ​.github/workflows/build-android.yml	Indented inputs block under workflow_dispatch from two to four spaces, restructuring YAML hierarchy.
Workflow restructuring and trigger migration ​.github/workflows/push_trigger.yml	Renamed workflow to "ARC Build With Pre-Checks"; replaced push/pull_request triggers with workflow_dispatch input for dynamic serverBaseURL; added DCO validation job; reworked CodeQL analysis with v4 checkout and Android-specific build; replaced Android Build Check with Pre-Build Validation and Build APK stages; added npm install and dynamic serverBaseURL substitution via sed; removed SonarCloud/SonarQube job; updated artifact naming to arc-apk.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20–30 minutes

• Attention areas:
  • Job dependency chain and sequencing changes (dco-check → codeql → prebuild → build-apk)
  • Dynamic serverBaseURL substitution logic and input handling
  • CodeQL initialization changes for Android context (path adjustments, gradle command changes)
  • Artifact naming and upload path adjustments
  • Verification that removed SonarCloud step doesn't break downstream processes

Possibly related PRs

• mosip/android-registration-client#631: Modifies the same CI workflows, introducing dynamic serverBaseURL input and pre-check/CodeQL-style build validation with similar substitution logic.

Poem

🐰 Workflows now dispatch by hand,
With pre-checks standing firm and grand,
DCO guards the sacred code,
APKs dance on the build road,
SonarCloud fades, but hopes remain—
Hop hop! The checks flow smooth as rain. 🌟

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main changes: enabling pre-checks and making serverBaseURL dynamic. Both aspects are significant modifications to the workflow files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

.github/workflows/push_trigger.yml (1)

13-24: Pin DCO check image tag to a specific version.

Line 22 uses ghcr.io/viperproject/dco-check:latest, which can change between workflow runs. For reproducibility and security, pin this to a specific version (e.g., v2.6.0).

-      - name: Validate DCO
-        uses: docker://ghcr.io/viperproject/dco-check:latest
+      - name: Validate DCO
+        uses: docker://ghcr.io/viperproject/dco-check:v2.6.0

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 99fba14 and 06bb1cc.

📒 Files selected for processing (2)

• .github/workflows/build-android.yml (1 hunks)
• .github/workflows/push_trigger.yml (1 hunks)

🔇 Additional comments (5)

.github/workflows/build-android.yml (1)

6-9: Verify serverBaseURL default consistency across workflows.

The default value here (https://api.default.example.com) differs from push_trigger.yml (api-internal.sandbox.xyz.net). Additionally, the sed pattern on line 27 replaces api-internal.sandbox.xyz.net, so the https-prefixed default won't match the replacement target. Confirm whether both defaults are intentional given the structural differences between these workflows.

.github/workflows/push_trigger.yml (4)

4-9: Verify impact of trigger change: workflow is now manual-only.

This workflow no longer runs automatically on push/pull_request events; it is now triggered exclusively via workflow_dispatch. This is a significant behavioral change. Ensure all stakeholders are aware that Android builds no longer run on every commit and require manual triggering. Confirm this aligns with the PR objectives to enable on-demand prechecks.

---

74-75: Clarify the purpose of npm install in an Android Gradle build.

Line 75 installs npm dependencies, but this workflow appears to be a pure Gradle-based Android build with no visible Node.js/Flutter dependencies or package.json file. Confirm whether npm is genuinely required for the build, or if this is leftover from a previous configuration.

---

77-80: Verify serverBaseURL sed pattern matches actual build files.

The sed command replaces api-internal.sandbox.xyz.net across all *build.gradle files. Confirm that:

1. This pattern actually exists in your build.gradle files
2. The serverBaseURL input is used correctly (currently a bare domain without https://)
3. Any build configuration that requires the full URL (e.g., https://...) is handled appropriately

---

82-93: Artifact is a debug build; confirm this is intentional.

This workflow builds and uploads app-debug.apk (line 93), whereas build-android.yml produces app-release.apk. Confirm that debug builds are appropriate for this on-demand workflow, or consider building release variants if needed for distribution.