RCF-1301 Added config properties

[MadhuMosip]

mosip.registration.disk_space_size
mosip.kernel.prid.length
mosip.kernel.uin.length
mosip.kernel.vid.length

Summary by CodeRabbit

• New Features

  • Configurable length validation for Application ID (PRID), UIN, and VID enforced across inputs, QR scanning, and fetch flows.
  • Disk space threshold is configurable with a sensible default.
  • Registrations can be auto‑approved when supervisor approval is disabled.

• Documentation

  • Added localized validation message for Application ID length in English, Arabic, French, Hindi, Kannada, and Tamil.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Adds configurable PRID/UIN/VID lengths and disk-space/supervisor flags end-to-end: new constants, repository getters, pigeon APIs and Android implementations, Dart platform/provider methods, UI validators updated to use configured lengths, plus localization entries and supervisor auto-approve behavior.

Changes

Cohort / File(s)	Summary
Configuration Constants android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java	Added constants: DISK_SPACE, PRID_LENGTH, UIN_LENGTH, VID_LENGTH, SUPERVISOR_APPROVAL_CONFIG_FLAG.
Repository Access Layer android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java	Added integer cached getters: getCachedIntegerDiskSpaceSize(), getCachedIntegerPRIDLength(), getCachedIntegerUINLength(), getCachedIntegerVIDLength().
Service Layer (Android) android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/RegistrationServiceImpl.java	Use dynamic disk-space threshold (with DEFAULT_MIN_SPACE_REQUIRED_MB fallback) and add supervisor-auto-approve path when flag disabled.
Platform Bridge (Pigeon) pigeon/global_config_settings.dart	Added async API defs: getPRIDLength(), getUINLength(), getVIDLength().
Android Platform Implementation android/app/src/main/java/io/mosip/registration_client/api_services/GlobalConfigSettingsApi.java	Implemented getPRIDLength, getUINLength, getVIDLength returning cached integers with error logging and callback results.
Dart Platform Implementation lib/platform_android/global_config_service_impl.dart	Added platform-call methods: getPRIDLength(), getUINLength(), getVIDLength() with PlatformException and generic error handling.
Platform Service Interface lib/platform_spi/global_config_service.dart	Added interface methods: Future<int> getPRIDLength(), getUINLength(), getVIDLength().
State Management Provider lib/provider/global_provider.dart	Added _pridLength, _uinLength, _vidLength, public getters and async fetchers with defaults (14, 10, 16); call notifyListeners() on update.
Application ID Validation UI lib/ui/process_ui/widgets/pre_reg_data_control.dart	Replace hard-coded 14-digit check with dynamic pridLength validation; added form validation before fetch and QR flows; show localized validator alerts on invalid length.
UIN/VID Validation UI lib/ui/process_ui/widgets/update_field_selector.dart	Added async initializer to fetch UIN/VID lengths; validator enforces configured lengths (with defaults) and digit-only checks.
Localization Strings assets/l10n/.../app_*.arb	Added prid_length_greater key and @prid_length_greater metadata (placeholder length as int) across locales (ar, en, fr, hi, kn, ta).

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant UI as UI Widget
    participant Provider as GlobalProvider
    participant Service as GlobalConfigService
    participant Platform as Platform Channel
    participant AndroidAPI as GlobalConfigSettingsApi
    participant Repo as GlobalParamRepository

    UI->>Provider: request PRID/UIN/VID length
    activate Provider
    Provider->>Service: getPRIDLength()/getUINLength()/getVIDLength()
    activate Service
    Service->>Platform: platform call getPRIDLength()/getUINLength()/getVIDLength()
    activate Platform
    Platform->>AndroidAPI: dispatch getPRIDLength()/getUINLength()/getVIDLength()
    activate AndroidAPI
    AndroidAPI->>Repo: getCachedIntegerPRIDLength()/...
    Repo-->>AndroidAPI: cached integer value
    AndroidAPI-->>Platform: return via callback (success/error)
    deactivate AndroidAPI
    Platform-->>Service: deliver result
    deactivate Platform
    Service-->>Provider: return int
    deactivate Service
    Provider->>Provider: apply default if needed, store value, notifyListeners
    Provider-->>UI: updated configured length
    UI->>UI: validate input against configured length

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• RCF-1283 - Added config properties for hardcoded values #650 — Adds global-parameter constants and cached getters touching RegistrationConstants and GlobalParamRepository.
• RCF-1301 Added config properties #665 — Modifies global configuration plumbing and getters similar to this change.

Suggested reviewers

• SachinPremkumar
• ase-101

Poem

🐰 I nibble configs late at night,

Digits now bend to a new light,
PRID, UIN, VID hop in a row,
Validators sing as numbers grow,
A little rabbit cheers the show.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title 'RCF-1301 Added config properties' accurately reflects the main changes in the changeset. The PR adds new configuration properties (disk_space_size, prid.length, uin.length, vid.length) along with supporting API methods and validation logic across Android and Dart layers.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 48297e6 and 07e5e27.

📒 Files selected for processing (3)

• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/RegistrationServiceImpl.java

🚧 Files skipped from review as they are similar to previous changes (1)

• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java

🧰 Additional context used

🧬 Code graph analysis (2)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java (1)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java (1)

• RegistrationConstants (9-149)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/RegistrationServiceImpl.java (1)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java (1)

• RegistrationConstants (9-149)

🔇 Additional comments (4)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/RegistrationServiceImpl.java (4)

50-50: LGTM!

The import is correctly added to support the auto-approval logic introduced later in the file.

---

101-101: LGTM!

The constant rename to DEFAULT_MIN_SPACE_REQUIRED_MB accurately reflects its new role as a fallback value when dynamic configuration returns zero.

---

646-652: Dynamic disk space validation implemented correctly.

The logic properly retrieves the configured disk space requirement and falls back to 50 MB when the configuration returns zero. This provides sensible default behavior while allowing configuration flexibility.

Note: This depends on getCachedIntegerDiskSpaceSize(), which can throw NumberFormatException if the configuration value is malformed (flagged separately in GlobalParamRepository review).

---

324-330: LGTM! Auto-approval logic is correctly implemented.

The logic properly checks the supervisor approval configuration flag and auto-approves registrations when the flag is not set to "Y". The null check and case-insensitive comparison ensure robust handling of configuration values.

The placement after registration insertion and before pre-registration cleanup is appropriate.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

lib/ui/process_ui/widgets/pre_reg_data_control.dart (1)

289-331: Fix invalid logic: Fetch is called even when length validation fails.

When the length validation fails (lines 298-315), the code shows an error dialog, then proceeds to call fetchPreRegistrationDetail, and finally clears the data. This is incorrect—if the ID is invalid, the fetch should not be attempted at all.

🔎 Proposed fix to skip fetch on invalid length

                           if (!isValidLength) {
                             globalProvider.preRegControllerRefresh = true;
                             showDialog(
                               context: context,
                               builder: (BuildContext context) => ValidatorAlert(
                                 errorMessage: AppLocalizations.of(context)!.application_id_not_exist,
                                 subError: AppLocalizations.of(context)!.correct_application_id
                               ),
                             );
-                            await context.read<
-                                RegistrationTaskProvider>()
-                                .fetchPreRegistrationDetail(
-                                preRegIdController.text);
-
-                            globalProvider.clearMap();
-                            globalProvider.clearScannedPages();
                             globalProvider.preRegControllerRefresh = false;
+                            return; // Exit early, don't fetch
                           } else {
                           globalProvider.preRegControllerRefresh = true;

🧹 Nitpick comments (2)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java (1)

216-230: LGTM! Repository getters follow existing patterns.

The four new getter methods are consistent with existing code in this file. They retrieve cached configuration values for disk space size and ID lengths (PRID, UIN, VID).

Optional: Consider adding null handling or defaults for robustness.

These methods return null if the configuration keys are not present in globalParamMap. While this is consistent with other getters like getCachedStringInvalidLoginTime(), you might want to consider providing default values (similar to getMaxLanguageCount()) to prevent potential NullPointerException issues in calling code.

For example:

public String getCachedStringPRIDLength(){
    return globalParamMap.getOrDefault(RegistrationConstants.PRID_LENGTH, "14");
}

However, this depends on whether the calling code is designed to handle defaults elsewhere or whether null is the intended behavior to signal missing configuration.

lib/ui/process_ui/widgets/pre_reg_data_control.dart (1)

238-250: Validator checks for length exceeding configured value.

The validator returns an error if value.length > globalProvider.pridLength, but the button-click validation (line 293) checks for exact match with !=. Consider whether the validator should also check for exact length match to provide consistent feedback.

🔎 Proposed fix for consistent validation

                     validator: (value) {
                       if (value == null || value.isEmpty) {
                         return null; // Empty validation handled by button click
                       }
                       if (globalProvider.pridLength != null) {
-                        // Check if length matches configured value
-                        if (value.length > globalProvider.pridLength!) {
+                        // Check if length doesn't match configured value
+                        if (value.length != globalProvider.pridLength!) {
                           return AppLocalizations.of(context)!
-                              .prid_length_greater(globalProvider.pridLength!);
+                              .valid_application_id; // or create new message for incorrect length
                         }
                       }
                       return null;
                     },

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d57feea and bd4eac9.

📒 Files selected for processing (16)

• android/app/src/main/java/io/mosip/registration_client/api_services/GlobalConfigSettingsApi.java
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/RegistrationServiceImpl.java
• assets/l10n/app_ar.arb
• assets/l10n/app_en.arb
• assets/l10n/app_fr.arb
• assets/l10n/app_hi.arb
• assets/l10n/app_kn.arb
• assets/l10n/app_ta.arb
• lib/platform_android/global_config_service_impl.dart
• lib/platform_spi/global_config_service.dart
• lib/provider/global_provider.dart
• lib/ui/process_ui/widgets/pre_reg_data_control.dart
• lib/ui/process_ui/widgets/update_field_selector.dart
• pigeon/global_config_settings.dart

🧰 Additional context used

🧬 Code graph analysis (1)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java (1)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java (1)

• RegistrationConstants (9-140)

🔇 Additional comments (15)

assets/l10n/app_fr.arb (1)

318-325: LGTM! Localization entry correctly added.

The French localization for the PRID length validation message is properly structured with the correct placeholder type (int) and follows ARB conventions.

assets/l10n/app_kn.arb (1)

318-325: LGTM! Kannada localization properly added.

The localization entry follows the same structure as other locale files and correctly defines the length placeholder.

pigeon/global_config_settings.dart (1)

15-20: LGTM! API methods correctly defined.

The three new async methods for retrieving PRID, UIN, and VID lengths follow the existing HostApi pattern and are properly annotated. The String return type is consistent with other configuration getters in this interface.

assets/l10n/app_ar.arb (1)

318-325: LGTM! Arabic localization correctly added.

The localization entry is consistent with other locale files and properly structured.

assets/l10n/app_hi.arb (1)

318-325: LGTM! Hindi localization properly added.

The entry follows the established pattern across all locale files.

assets/l10n/app_en.arb (1)

318-325: LGTM! Base language localization correctly added.

The English localization entry is clear, grammatically correct, and properly structured with the required metadata.

assets/l10n/app_ta.arb (1)

327-334: LGTM! Tamil localization correctly added.

The final locale file addition is consistent with all other localization files in this PR.

lib/platform_spi/global_config_service.dart (1)

14-18: LGTM!

The three new interface methods follow consistent naming conventions and return types, properly extending the configuration service API surface.

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/RegistrationServiceImpl.java (2)

632-645: LGTM!

The dynamic disk space configuration retrieval is well-implemented with appropriate error handling, fallback to default, and warning logs on parse failure.

---

99-99: 50 MB is a configurable default, but verification data on typical packet sizes is unavailable.

The default minimum space requirement of 50 MB is not a hard limit—it's configurable via the global parameter mosip.registration.disk_space_size (line 632-640). The implementation properly handles configuration overrides with graceful fallback to the default.

However, the underlying concern remains valid: without documented specifications for typical registration packet sizes (biometric data, documents, temporary files), it's unclear whether 50 MB is an appropriate default. Pre-registration packets have a 200 KB threshold, but full registration packets may be significantly larger. Consider documenting the rationale for this default or providing deployment guidance on recommended configurations for different device storage constraints.

lib/platform_android/global_config_service_impl.dart (1)

74-111: LGTM with a note on error handling.

The three new methods follow the established pattern in this file. However, returning an empty string on failure makes it impossible to distinguish between "configuration not set" and "error occurred." The provider layer appropriately handles this by applying defaults when the string is empty.

android/app/src/main/java/io/mosip/registration_client/api_services/GlobalConfigSettingsApi.java (1)

89-120: LGTM!

The three new API methods follow the established pattern in this class, with consistent error handling and logging. They properly delegate to the repository layer and handle exceptions gracefully.

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java (1)

135-138: LGTM!

The four new configuration key constants follow the established naming conventions and property key patterns used throughout the file.

lib/ui/process_ui/widgets/pre_reg_data_control.dart (1)

358-400: QR scanner validation logic is correct.

The QR code scanner properly validates the scanned data length before proceeding to fetch, and falls back to 14 digits if the config is not loaded. This is the correct approach.

lib/ui/process_ui/widgets/update_field_selector.dart (1)

203-218: The dual acceptance of both UIN and VID lengths is intentional. The backend can configure these lengths independently, and the code explicitly validates against both. In MOSIP systems, VID serves as a valid alternative to UIN for authentication and identity services—this is by design. Consider clarifying the field label or help text to indicate both formats are acceptable if user confusion is a concern, but no functional changes are needed.

Likely an incorrect or invalid review comment.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/RegistrationServiceImpl.java (2)

645-654: Add validation for non-positive configured values.

The parsing logic handles NumberFormatException, but negative or zero values like "-10" or "0" would be accepted, potentially allowing registrations without adequate disk space.

🔎 Proposed fix to validate positive values

 if (diskSpaceSizeConfig != null && !diskSpaceSizeConfig.trim().isEmpty()) {
     try {
-        minSpaceRequiredMB = Integer.parseInt(diskSpaceSizeConfig.trim());
+        int parsedValue = Integer.parseInt(diskSpaceSizeConfig.trim());
+        if (parsedValue > 0) {
+            minSpaceRequiredMB = parsedValue;
+        } else {
+            Log.w(TAG, "Disk space size must be positive: " + diskSpaceSizeConfig + ", using default: " + DEFAULT_MIN_SPACE_REQUIRED_MB + " MB");
+        }
     } catch (NumberFormatException e) {
         Log.w(TAG, "Invalid disk space size configuration: " + diskSpaceSizeConfig + ", using default: " + DEFAULT_MIN_SPACE_REQUIRED_MB + " MB", e);
     }
 }

---

656-658: Consider adding null check for getExternalCacheDir().

The getExternalCacheDir() method can return null when external storage is unavailable or not mounted, which would cause a NullPointerException. While this is pre-existing code, the changed validation logic now depends on it.

🔎 Proposed defensive fix

+java.io.File externalCacheDir = context.getExternalCacheDir();
+if (externalCacheDir == null) {
+    Log.w(TAG, "External cache directory unavailable, skipping disk space check");
+    // Or throw an exception if external storage is mandatory
+} else {
-long externalSpace = context.getExternalCacheDir().getUsableSpace();
+    long externalSpace = externalCacheDir.getUsableSpace();
-if ((externalSpace / (1024 * 1024)) < minSpaceRequiredMB)
-    throw new ClientCheckedException(context, R.string.err_006);
+    if ((externalSpace / (1024 * 1024)) < minSpaceRequiredMB)
+        throw new ClientCheckedException(context, R.string.err_006);
+}

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2e8f60f and 6f14234.

📒 Files selected for processing (8)

• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/RegistrationServiceImpl.java
• assets/l10n/app_ar.arb
• assets/l10n/app_en.arb
• assets/l10n/app_fr.arb
• assets/l10n/app_hi.arb
• assets/l10n/app_kn.arb
• assets/l10n/app_ta.arb

🚧 Files skipped from review as they are similar to previous changes (6)

• assets/l10n/app_ar.arb
• assets/l10n/app_fr.arb
• assets/l10n/app_en.arb
• assets/l10n/app_ta.arb
• assets/l10n/app_kn.arb
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java

🔇 Additional comments (3)

assets/l10n/app_hi.arb (1)

318-325: LGTM! Localization entry correctly structured.

The new PRID length validation message is properly implemented with:

• Correct placeholder syntax {length} for dynamic length values
• Proper metadata defining the int type placeholder
• Appropriate Hindi translation conveying the exact length requirement

This integrates well with the PR's objective to add configurable length validation for PRID/UIN/VID.

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/RegistrationServiceImpl.java (2)

50-50: LGTM!

The new import for PacketClientStatus supports the auto-approval feature, and renaming the constant to DEFAULT_MIN_SPACE_REQUIRED_MB clearly communicates its role as a fallback value.

Also applies to: 101-101

---

323-329: Auto-approval logic is correctly implemented.

The short-circuit evaluation properly handles the null case, and the logic correctly auto-approves when supervisor approval is disabled (flag is null or not "Y"). Constants SUPERVISOR_APPROVAL_CONFIG_FLAG and ENABLE are correctly defined in RegistrationConstants.java.

[coderabbitai]

Actionable comments posted: 1

♻️ Duplicate comments (1)

lib/ui/process_ui/widgets/update_field_selector.dart (1)

52-54: Race condition: Async initialization in initState allows validation before lengths are loaded.

This issue was previously flagged. The _initializeUINVIDLength() method is called asynchronously in initState() without blocking the build. During the window before lengths are fetched, the validator at lines 230-232 will skip length validation (since expectedLength will be null), allowing invalid inputs to pass.

Also applies to: 94-106

🧹 Nitpick comments (1)

lib/ui/process_ui/widgets/update_field_selector.dart (1)

213-238: Consider more specific error messages for different validation failures.

The validator returns the same generic message (appLocalizations.valid_uin) for three distinct validation failures:

• Empty input (line 214)
• Invalid length (line 231)
• Non-digit characters (line 236)

More specific error messages would improve user experience by clearly indicating what needs to be corrected (e.g., "UIN must be exactly 10 digits", "UIN must contain only digits").

🔎 Example of more specific validation messages

                      validator: (value) {
                        if (value == null || value.isEmpty) {
-                          return appLocalizations.valid_uin;
+                          return appLocalizations.enter_uin; // or a specific "required" message
                        }

                        // Determine validation length based on available field subType in UI spec
                        int? expectedLength;

                        if (idSubType == "uin") {
                          expectedLength = uinLength;
                        } else if (idSubType == "vid") {
                          expectedLength = vidLength;
                        } else {
                          // Default to UIN length if no specific ID subType found
                          expectedLength = uinLength;
                        }

                        // Check if length matches the expected length
                        if (expectedLength != null && value.length != expectedLength) {
-                          return appLocalizations.valid_uin;
+                          return appLocalizations.invalid_length; // e.g., "Must be {length} digits"
                        }

                        // Check if value contains only digits
                        if (!validation.hasMatch(value)) {
-                          return appLocalizations.valid_uin;
+                          return appLocalizations.digits_only; // e.g., "Must contain only digits"
                        }

                        return null;
                      },

Note: This would require adding new localization keys for the specific error messages.

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 878af6e and 2e32a4f.

📒 Files selected for processing (1)

• lib/ui/process_ui/widgets/update_field_selector.dart

🔇 Additional comments (2)

lib/ui/process_ui/widgets/update_field_selector.dart (2)

39-39: LGTM: Regex correctly updated for dynamic length validation.

The regex now validates digit-only input without enforcing a fixed length, which aligns with the new dynamic length validation in the validator method.

---

42-44: LGTM: State variables properly declared.

The nullable state variables are correctly declared to hold dynamic length configuration and ID subtype.

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In
@android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/RegistrationServiceImpl.java:
- Around line 645-651: The disk-space validation currently treats only a zero
return from getCachedIntegerDiskSpaceSize() as missing, so negative configured
values slip through; update the check in RegistrationServiceImpl by changing the
condition that sets the fallback DEFAULT_MIN_SPACE_REQUIRED_MB from "== 0" to
"<= 0" for minSpaceRequiredMB (the rest of the logic using externalSpace and
context.getExternalCacheDir().getUsableSpace() remains unchanged) so negative or
zero configurations fall back to the default.

🧹 Nitpick comments (2)

lib/provider/global_provider.dart (2)

511-527: Consider renaming methods to reflect their async initialization nature.

These methods are named like getters (getPRIDLength, getUINLength, getVIDLength) but they're actually async initializers that fetch data, apply defaults, mutate state, and trigger notifications. This naming can be misleading.

Consider renaming to better reflect their behavior:

• getPRIDLength() → fetchPRIDLength() or initializePRIDLength()
• getUINLength() → fetchUINLength() or initializeUINLength()
• getVIDLength() → fetchVIDLength() or initializeVIDLength()

This aligns with Dart conventions where get typically indicates synchronous getters or simple accessors.

♻️ Example refactor

-  getPRIDLength() async {
+  fetchPRIDLength() async {
     int length = await globalConfigService.getPRIDLength();
     _pridLength = length == 0 ? 14 : length;
     notifyListeners();
   }

-  getUINLength() async {
+  fetchUINLength() async {
     int length = await globalConfigService.getUINLength();
     _uinLength = length == 0 ? 10 : length;
     notifyListeners();
   }

-  getVIDLength() async {
+  fetchVIDLength() async {
     int length = await globalConfigService.getVIDLength();
     _vidLength = length == 0 ? 16 : length;
     notifyListeners();
   }

---

511-527: Consider adding error handling for defensive programming.

These methods lack try-catch blocks. If globalConfigService throws an exception, it will propagate unhandled and the state fields will remain null. While this may be acceptable in your codebase's patterns, adding error handling would make the code more defensive and prevent unexpected crashes.

♻️ Proposed error handling

   getPRIDLength() async {
-    int length = await globalConfigService.getPRIDLength();
-    _pridLength = length == 0 ? 14 : length;
-    notifyListeners();
+    try {
+      int length = await globalConfigService.getPRIDLength();
+      _pridLength = length == 0 ? 14 : length;
+    } catch (e) {
+      debugPrint("Error fetching PRID length: $e");
+      _pridLength = 14; // Use default on error
+    }
+    notifyListeners();
   }

Apply similar pattern to getUINLength() and getVIDLength().

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2e32a4f and 31f0b0c.

📒 Files selected for processing (7)

• android/app/src/main/java/io/mosip/registration_client/api_services/GlobalConfigSettingsApi.java
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/RegistrationServiceImpl.java
• lib/platform_android/global_config_service_impl.dart
• lib/platform_spi/global_config_service.dart
• lib/provider/global_provider.dart
• pigeon/global_config_settings.dart

🚧 Files skipped from review as they are similar to previous changes (2)

• android/app/src/main/java/io/mosip/registration_client/api_services/GlobalConfigSettingsApi.java
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java

🔇 Additional comments (8)

lib/platform_spi/global_config_service.dart (1)

14-19: LGTM! Clean API extension.

The new abstract method declarations for retrieving PRID, UIN, and VID lengths are well-defined and consistent with the existing interface pattern.

pigeon/global_config_settings.dart (1)

15-20: LGTM! Pigeon API surface properly extended.

The three new method declarations follow the existing pattern with appropriate @async annotations and return types.

lib/provider/global_provider.dart (2)

125-127: LGTM! Field declarations are clean.

The nullable integer fields for PRID, UIN, and VID lengths are appropriately declared.

---

153-156: LGTM! Getters properly expose the fields.

The public getters provide appropriate read access to the length fields.

lib/platform_android/global_config_service_impl.dart (1)

74-111: LGTM! Implementations follow established patterns with proper error handling.

All three method implementations (getPRIDLength, getUINLength, getVIDLength) are consistent with the existing getGpsEnableFlag pattern. They appropriately:

• Initialize to a safe default (0)
• Handle both PlatformException and general exceptions
• Include debug logging for troubleshooting
• Return the default on error, which aligns with the provider's fallback logic

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/RegistrationServiceImpl.java (3)

50-50: LGTM!

The import is correctly added to support the auto-approval functionality introduced later in the file.

---

101-101: LGTM!

The constant rename from MIN_SPACE_REQUIRED_MB to DEFAULT_MIN_SPACE_REQUIRED_MB better reflects its role as a fallback value when the configuration is missing or invalid.

---

323-329: Auto-approval configuration is correctly implemented.

All verification checks confirm the logic is sound:

• SUPERVISOR_APPROVAL_CONFIG_FLAG correctly maps to "mosip.registration.supervisor_approval_config_flag"
• RegistrationConstants.ENABLE is "Y" as expected
• registrationRepository.updateStatus() correctly handles null parameters (will set client_status to NULL in the database)
• PacketClientStatus.APPROVED is a valid enum value

The null check prevents NPE when the config is missing, trim() handles whitespace properly, and the inverted flag check (auto-approve when NOT enabled) is correct.

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In
@android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java:
- Around line 215-229: getCachedIntegerGlobalParam currently calls
Integer.parseInt(value) without handling NumberFormatException; modify
getCachedIntegerGlobalParam to wrap the parse in a try-catch that catches
NumberFormatException (and null checks for value), logs an informative message
including the param key and the offending value via the repository logger, and
returns 0 on error so callers (e.g., getCachedIntegerDiskSpaceSize,
getCachedIntegerPRIDLength, getCachedIntegerUINLength,
getCachedIntegerVIDLength) no longer need to handle parsing exceptions.

🧹 Nitpick comments (2)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/RegistrationServiceImpl.java (2)

324-330: Consider adding audit logging for auto-approval actions.

The auto-approval logic correctly checks if supervisor approval is explicitly disabled. However, auto-approving registrations is a significant workflow change that should be audited for compliance and security tracking.

📝 Suggested enhancement: Add audit log entry

 // Auto-approve when supervisor approval is disabled (flag not "Y")
 String supervisorApprovalFlag = globalParamRepository.getCachedStringGlobalParam(
         RegistrationConstants.SUPERVISOR_APPROVAL_CONFIG_FLAG);
 if (supervisorApprovalFlag != null && !RegistrationConstants.ENABLE.equalsIgnoreCase(supervisorApprovalFlag.trim())) {
+    Log.i(TAG, "Auto-approving registration " + this.registrationDto.getPacketId() + " (supervisor approval disabled)");
     registrationRepository.updateStatus(this.registrationDto.getPacketId(), null,
             PacketClientStatus.APPROVED.name());
 }

---

646-652: Add validation for configured disk space minimum.

The dynamic disk space threshold correctly falls back to DEFAULT_MIN_SPACE_REQUIRED_MB when the configured value is zero. However, there's no validation to prevent unreasonably low configured values (e.g., 1 MB), which could cause operational issues or unintended behavior.

♻️ Suggested enhancement: Add minimum threshold validation

 int minSpaceRequiredMB = globalParamRepository.getCachedIntegerDiskSpaceSize();
 if (minSpaceRequiredMB == 0) {
     minSpaceRequiredMB = DEFAULT_MIN_SPACE_REQUIRED_MB;
+} else if (minSpaceRequiredMB < 10) {
+    Log.w(TAG, "Configured disk space size (" + minSpaceRequiredMB + " MB) is unusually low, using default: " + DEFAULT_MIN_SPACE_REQUIRED_MB + " MB");
+    minSpaceRequiredMB = DEFAULT_MIN_SPACE_REQUIRED_MB;
 }
 
 long externalSpace = context.getExternalCacheDir().getUsableSpace();

Consider setting a reasonable minimum threshold (e.g., 10 MB) below which the default is used, as registration packets with biometrics and documents typically require significant space.

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 31f0b0c and 2ee052f.

📒 Files selected for processing (3)

• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/RegistrationServiceImpl.java

🧰 Additional context used

🧬 Code graph analysis (2)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java (1)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java (1)

• RegistrationConstants (9-149)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/RegistrationServiceImpl.java (1)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java (1)

• RegistrationConstants (9-149)

🔇 Additional comments (3)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/RegistrationServiceImpl.java (2)

50-50: LGTM: Import added for auto-approval feature.

The PacketClientStatus import is correctly added to support the new auto-approval functionality introduced at lines 324-330.

---

101-101: LGTM: Constant renamed for clarity.

Renaming MIN_SPACE_REQUIRED_MB to DEFAULT_MIN_SPACE_REQUIRED_MB accurately reflects its role as a fallback default when the configured disk space size is unavailable or zero.

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java (1)

139-143: LGTM: Configuration constants added.

The new constants follow the existing naming conventions and properly define configuration keys for disk space size, PRID/UIN/VID lengths, and supervisor approval flag. These constants are correctly referenced by the repository methods and service logic.

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In @lib/ui/process_ui/widgets/update_field_selector.dart:
- Around line 52-54: The async fetch in _initializeUINVIDLength() creates a race
where uinLength/vidLength may be null when the validator in UpdateFieldSelector
runs; add a boolean _isLoadingConfig, set it true before calling
_initializeUINVIDLength() and false when it completes (inside that method or its
future callback), then in build either show a loading indicator or disable the
form widgets when _isLoadingConfig is true; additionally make the validator
fail-safe by treating a null expectedLength as an invalid state (return a
validation error) so input cannot pass while config is unavailable.

🧹 Nitpick comments (3)

lib/ui/process_ui/widgets/update_field_selector.dart (3)

94-106: Extract hard-coded default values to named constants.

The default length values (10 for UIN, 16 for VID) are hard-coded at lines 102-103. Extracting these to named constants improves maintainability and makes the defaults more discoverable.

♻️ Proposed refactor

At the top of the class, add constants:

class _UpdateFieldSelectorState extends State<UpdateFieldSelector>
    with WidgetsBindingObserver {
  late GlobalProvider globalProvider;
  late RegistrationTaskProvider registrationTaskProvider;
  Map<String, List<Field>> fieldsMap = {};
  final RegExp inputValidation = RegExp(r'^[0-9]+$');
  TextEditingController controller = TextEditingController();
  late AppLocalizations appLocalizations = AppLocalizations.of(context)!;
  int? uinLength;
  int? vidLength;
  String? idSubType;
+ 
+ static const int _defaultUinLength = 10;
+ static const int _defaultVidLength = 16;

Then use them in the method:

  Future<void> _initializeUINVIDLength() async {
    await globalProvider.getUINLength();
    await globalProvider.getVIDLength();

    // Update local variables after fetching from backend
-   // Use default values if null: UIN = 10, VID = 16
+   // Use default values if null
    if (mounted) {
      setState(() {
-       uinLength = globalProvider.uinLength ?? 10;
-       vidLength = globalProvider.vidLength ?? 16;
+       uinLength = globalProvider.uinLength ?? _defaultUinLength;
+       vidLength = globalProvider.vidLength ?? _defaultVidLength;
      });
    }
  }

---

94-106: Consider parallelizing the async configuration fetches.

Lines 95-96 await getUINLength() and getVIDLength() sequentially. If these calls are independent (no data dependency between them), running them in parallel with Future.wait would reduce initialization time.

⚡ Proposed optimization

  Future<void> _initializeUINVIDLength() async {
-   await globalProvider.getUINLength();
-   await globalProvider.getVIDLength();
+   await Future.wait([
+     globalProvider.getUINLength(),
+     globalProvider.getVIDLength(),
+   ]);

    // Update local variables after fetching from backend
    // Use default values if null: UIN = 10, VID = 16
    if (mounted) {
      setState(() {
        uinLength = globalProvider.uinLength ?? 10;
        vidLength = globalProvider.vidLength ?? 16;
      });
    }
  }

---

213-227: Consider providing specific validation error messages.

The validator returns appLocalizations.valid_uin for all validation failures (empty input, incorrect length, non-numeric characters). Providing specific error messages would improve user experience by clearly indicating what needs to be corrected.

For example:

• "UIN/VID cannot be empty"
• "UIN/VID must be exactly {expectedLength} digits"
• "UIN/VID must contain only numbers"

✨ Example implementation with specific messages

Note: This assumes corresponding localization keys exist or would be added.

  validator: (value) {
    if (value == null || value.isEmpty) {
-     return appLocalizations.valid_uin;
+     return appLocalizations.uin_vid_required;  // "UIN/VID is required"
    }

    // Determine validation length based on available field subType in UI spec
    int? expectedLength = idSubType == "vid" ? vidLength : uinLength;
    // Check if length matches the expected length
    if (expectedLength != null && value.length != expectedLength) {
-     return appLocalizations.valid_uin;
+     return appLocalizations.uin_vid_invalid_length
+         .replaceAll('{length}', expectedLength.toString());
+     // "UIN/VID must be exactly {length} digits"
    }

    // Check if value contains only digits
    if (!inputValidation.hasMatch(value)) {
-     return appLocalizations.valid_uin;
+     return appLocalizations.uin_vid_numeric_only;  // "UIN/VID must contain only numbers"
    }

    return null;
  },

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2ee052f and 48297e6.

📒 Files selected for processing (1)

• lib/ui/process_ui/widgets/update_field_selector.dart

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2026-01-05T05:15:49.771Z

Learnt from: MadhuMosip
Repo: mosip/android-registration-client PR: 661
File: lib/ui/process_ui/widgets/update_field_selector.dart:64-72
Timestamp: 2026-01-05T05:15:49.771Z
Learning: In lib/ui/process_ui/widgets/update_field_selector.dart, ensure that the process configuration contains only one field type (either UIN or VID). Consequently, the existing idSubType determination logic (scanning the fields for the first 'uin' or 'vid' subType) is appropriate for this use case. If future changes introduce multiple field types, revise the idSubType resolution to handle both, with clear validation to prevent mixing types.

Applied to files:

• lib/ui/process_ui/widgets/update_field_selector.dart

🔇 Additional comments (3)

lib/ui/process_ui/widgets/update_field_selector.dart (3)

39-39: LGTM!

The regex pattern correctly validates digit-only input for UIN/VID fields.

---

42-44: LGTM!

The nullable state variables appropriately accommodate asynchronous initialization of UIN/VID length configuration.

---

64-72: LGTM!

The ID subType detection logic correctly identifies whether the form uses UIN or VID fields by scanning for the first matching subType. This approach is appropriate given that the process configuration contains only one field type (either UIN or VID).

Based on learnings, this single-type assumption is valid for the current use case.

[coderabbitai]

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java (1)

98-101: Add error handling for malformed configuration values.

The getCachedIntegerGlobalParam method will throw NumberFormatException if the configuration value is not a valid integer. This affects all the new getter methods (disk space, PRID/UIN/VID lengths) and could cause runtime crashes.

Consider adding error handling consistent with the parseLongWithDefault pattern (lines 276-287) that gracefully handles parse errors with logging and returns a sensible default.

🛡️ Proposed fix with error handling

 public int getCachedIntegerGlobalParam(String key) {
     String value = getCachedStringGlobalParam(key);
-    return value == null ? 0 : Integer.parseInt(value);
+    if (value == null || value.trim().isEmpty()) {
+        return 0;
+    }
+    try {
+        return Integer.parseInt(value.trim());
+    } catch (NumberFormatException e) {
+        Log.e(TAG, "Failed to parse integer value for key: " + key + ", value: " + value, e);
+        return 0;
+    }
 }

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 48297e6 and 07e5e27.

📒 Files selected for processing (3)

• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/RegistrationServiceImpl.java

🚧 Files skipped from review as they are similar to previous changes (1)

• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java

🧰 Additional context used

🧬 Code graph analysis (2)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java (1)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java (1)

• RegistrationConstants (9-149)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/RegistrationServiceImpl.java (1)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java (1)

• RegistrationConstants (9-149)

🔇 Additional comments (4)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/RegistrationServiceImpl.java (4)

50-50: LGTM!

The import is correctly added to support the auto-approval logic introduced later in the file.

---

101-101: LGTM!

The constant rename to DEFAULT_MIN_SPACE_REQUIRED_MB accurately reflects its new role as a fallback value when dynamic configuration returns zero.

---

646-652: Dynamic disk space validation implemented correctly.

The logic properly retrieves the configured disk space requirement and falls back to 50 MB when the configuration returns zero. This provides sensible default behavior while allowing configuration flexibility.

Note: This depends on getCachedIntegerDiskSpaceSize(), which can throw NumberFormatException if the configuration value is malformed (flagged separately in GlobalParamRepository review).

---

324-330: LGTM! Auto-approval logic is correctly implemented.

The logic properly checks the supervisor approval configuration flag and auto-approves registrations when the flag is not set to "Y". The null check and case-insensitive comparison ensure robust handling of configuration values.

The placement after registration insertion and before pre-registration cleanup is appropriate.