RCF-1302 Added config properties

[MadhuMosip]

mosip.registration.fields.to.retain.post.prid.fetch
mosip.registration.reg_pak_max_cnt_apprv_limit

Summary by CodeRabbit

• New Features

  • Enforced limit on registrations pending approval that can block new submissions with a user-facing error when the limit is reached.
  • Configurable retention of specific registration fields after identity fetch.

• Chores

  • Registration data cleanup now respects retention settings during pre-registration processing.
  • Added localized error messages for the approval-limit condition (en, fr, hi, ta, kn, ar, ar).

• Style

  • Internal validation variable renamed (no user-facing change).

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Adds two new global constants and cached accessors, a DTO method to retain configured fields used during pre-reg ZIP parsing, a new PacketService SPI method and implementation to validate count of registrations pending approval (enforced in pre-checks), localization entries for a new error, and a UI private variable rename.

Changes

Cohort / File(s)	Summary
Constants android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java	Added FIELDS_TO_RETAIN_ON_PRID_FETCH and REG_PAK_MAX_CNT_APPRV_LIMIT.
Global params repository android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java	Added getCachedStringFieldsToRetainOnPridFetch() and getCachedIntRegMaxCountApproveLimit() accessors.
DTO android/clientmanager/src/main/java/io/mosip/registration/clientmanager/dto/registration/RegistrationDto.java	Added retainConfiguredFields(String config) to selectively retain demographics/documents based on comma-separated config; clears maps when config empty.
Pre-reg ZIP handling android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/external/impl/PreRegZipHandlingServiceImpl.java	Replaced explicit clears with call to registrationService.getRegistrationDto().retainConfiguredFields(...) in parseDemographicJson().
Packet service SPI android/clientmanager/src/main/java/io/mosip/registration/clientmanager/spi/PacketService.java	Added isMaxNotApprovedPacketCountLimitReached() to the SPI contract.
Packet service impl android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/PacketServiceImpl.java	Implemented isMaxNotApprovedPacketCountLimitReached() — reads configured max, counts CREATED registrations, returns whether limit reached; exceptions logged.
Registration pre-checks android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/RegistrationServiceImpl.java	Calls packetService.isMaxNotApprovedPacketCountLimitReached() in doPreChecksBeforeRegistration() and throws ClientCheckedException with code REG_PKT_APPRVL_CNT_EXCEED when true.
Localizations assets/l10n/*.arb assets/l10n/app_en.arb, app_fr.arb, app_hi.arb, app_ta.arb, app_kn.arb, app_ar.arb	Added ICU select branch REG_PKT_APPRVL_CNT_EXCEED to multilingual errors messages.
UI widget lib/ui/process_ui/widgets/update_field_selector.dart	Renamed private variable inputValidation → idRegex and updated usages (no behavior change).

Sequence Diagram(s)

sequenceDiagram
    participant RegSvc as RegistrationServiceImpl
    participant PacketSPI as PacketService (SPI)
    participant PacketImpl as PacketServiceImpl
    participant GPRepo as GlobalParamRepository
    participant RegRepo as RegistrationRepository

    RegSvc->>PacketSPI: isMaxNotApprovedPacketCountLimitReached()
    PacketSPI->>PacketImpl: invoke implementation
    PacketImpl->>GPRepo: getCachedIntRegMaxCountApproveLimit()
    GPRepo-->>PacketImpl: maxCount
    PacketImpl->>RegRepo: getAllRegistrationByStatus(CREATED)
    RegRepo-->>PacketImpl: listOfCreated
    PacketImpl-->>PacketSPI: boolean limitReached
    PacketSPI-->>RegSvc: boolean limitReached
    alt limitReached == true
        RegSvc->>RegSvc: throw ClientCheckedException(REG_PKT_APPRVL_CNT_EXCEED)
    end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• RCF-1301 Added config properties #665 — similar additions to global parameter keys and cached accessors.
• RCF-1301 - Implemented config properties  #659 — related packet-count / approval-limit changes involving PacketService and registration pre-checks.

Suggested reviewers

• SachinPremkumar
• ase-101

Poem

🐰 A nibble on constants, a hop of delight,
Fields kept just so when the PRID comes in sight,
Packets now counted before you proceed,
Messages updated — approve, or take heed,
Hooray for small hops that keep things light. 🥕

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 13.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title 'RCF-1302 Added config properties' partially relates to the changeset but is overly broad and doesn't capture the main changes, which include field retention logic, packet approval count validation, and localization updates.	Consider a more descriptive title that highlights the primary changes, such as 'Add field retention and packet approval count validation' or similar, to better convey the scope of changes.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Fix all issues with AI agents

In
@android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java:
- Line 132: The constant name FIELDS_TO_RETAIN_ON_PRID_FETCH is misleading
because RegistrationDto.removeConfiguredFields() removes matching fields; rename
the constant to FIELDS_TO_REMOVE_ON_PRID_FETCH in RegistrationConstants and
update all references/usages (e.g., in RegistrationDto.removeConfiguredFields()
and any config lookups) to use the new name, keeping the property value string
if desired; alternatively, if you prefer to keep the current constant name,
change the logic in RegistrationDto.removeConfiguredFields() to retain only the
configured fields instead of removing them—pick one approach and apply the
corresponding updates consistently.

In
@android/clientmanager/src/main/java/io/mosip/registration/clientmanager/dto/registration/RegistrationDto.java:
- Around line 403-418: The removeConfiguredFields method uses a raw
Collections.EMPTY_LIST and does not trim split values; change keysToRemove
initialization to use Collections.emptyList() when config is null and otherwise
build a trimmed list from config by splitting on RegistrationConstants.COMMA
then mapping String::trim and filtering out empty strings (e.g., via
Arrays.stream(config.split(...)).map(String::trim).filter(s ->
!s.isEmpty()).collect(Collectors.toList())). Then use that keysToRemove in the
existing loop that checks and removes from demographics, documents, and
biometrics.

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9507421 and 1b9449c.

📒 Files selected for processing (4)

• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/dto/registration/RegistrationDto.java
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/external/impl/PreRegZipHandlingServiceImpl.java

🧰 Additional context used

🧬 Code graph analysis (1)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java (1)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java (1)

• RegistrationConstants (9-150)

🔇 Additional comments (2)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java (1)

250-252: LGTM!

The new accessor method follows the established pattern of other cached string getters in this class.

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/external/impl/PreRegZipHandlingServiceImpl.java (1)

248-250: Verify call order: removeConfiguredFields called after clearing demographics and documents.

removeConfiguredFields() is invoked after getDocuments().clear() and getDemographics().clear(). This means the method will only effectively operate on the biometrics map since the other two maps are already empty. If the intent is to selectively remove/retain fields from demographics or documents, this call should be placed before the clear operations.

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In
@android/clientmanager/src/main/java/io/mosip/registration/clientmanager/dto/registration/RegistrationDto.java:
- Around line 403-418: The method removeConfiguredFields currently treats the
config list as fields to remove but the config
(mosip.registration.fields.to.retain.post.prid.fetch) actually lists fields to
retain; update removeConfiguredFields to interpret config as keysToRetain:
rename keysToRemove to keysToRetain (or create a new Set/List keysToRetain from
config.split(RegistrationConstants.COMMA) using Collections.emptyList() when
null), then iterate allKeys (from
this.demographics/this.documents/this.biometrics) and remove any key where
!keysToRetain.contains(key) so only configured fields remain; keep references to
removeConfiguredFields, keysToRetain/keysToRemove, this.demographics,
this.documents, this.biometrics and RegistrationConstants.COMMA to locate the
change.

🧹 Nitpick comments (1)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/dto/registration/RegistrationDto.java (1)

404-404: Use parameterized Collections.emptyList() and handle empty string edge case.

Two issues on this line:

1. Collections.EMPTY_LIST is a raw type that generates unchecked assignment warnings. Use Collections.emptyList() instead.

2. If config is an empty string "", split(",") returns [""] (array with one empty string), not an empty array. This could cause unintended matching against keys.

Proposed fix

-        List<String> keysToRemove = config == null ? Collections.EMPTY_LIST : List.of(config.split(RegistrationConstants.COMMA));
+        List<String> keysToRemove = (config == null || config.isEmpty()) 
+            ? Collections.emptyList() 
+            : List.of(config.split(RegistrationConstants.COMMA));

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1b9449c and e699846.

📒 Files selected for processing (1)

• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/dto/registration/RegistrationDto.java

🧰 Additional context used

🧬 Code graph analysis (1)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/dto/registration/RegistrationDto.java (1)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java (1)

• RegistrationConstants (9-150)

🔇 Additional comments (1)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/dto/registration/RegistrationDto.java (1)

411-417: Consider whether observer notification is needed after field removal.

Other methods that modify demographics, documents, or biometrics (e.g., addDemographicField, removeDemographicField) call clearAndNotifyAllObservers() to signal state changes. This method modifies all three maps but does not notify observers.

If this is intentional (e.g., called as part of a larger batch operation where notification happens elsewhere), consider adding a brief comment to clarify. Otherwise, add the notification call.

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In
@android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/PacketServiceImpl.java:
- Around line 454-457: The comparison on Integer maxCount from
getCachedIntRegMaxCountApproveLimit() can NPE through auto-unboxing; update the
PacketServiceImpl block that currently does "Integer maxCount =
globalParamRepository.getCachedIntRegMaxCountApproveLimit(); if (maxCount <= 0)
{ return false; }" to first check for null (e.g., if (maxCount == null) return
false or handle as a configuration error) before performing the numeric
comparison, mirroring the null-check pattern used in
isMaxPacketCountLimitReached() and validatingLastExportDuration(); ensure the
change avoids auto-unboxing when value is null and preserves existing behavior.

🧹 Nitpick comments (1)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/spi/PacketService.java (1)

95-99: Consider renaming for consistency.

The method name validatingRegisteredPacketNotApproveCount() uses a different naming convention than the similar methods isRegisteredPacketApprovalTimeBreached() and isMaxPacketCountLimitReached(). Consider renaming to isRegisteredPacketApprovalCountLimitReached() for consistency.

That said, validatingLastExportDuration() (line 87) also uses the "validating..." prefix, so the current naming has precedent.

🔧 Optional rename for consistency

-    boolean validatingRegisteredPacketNotApproveCount();
+    boolean isRegisteredPacketApprovalCountLimitReached();

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e699846 and 2db2cd6.

📒 Files selected for processing (12)

• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/PacketServiceImpl.java
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/RegistrationServiceImpl.java
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/spi/PacketService.java
• assets/l10n/app_ar.arb
• assets/l10n/app_en.arb
• assets/l10n/app_fr.arb
• assets/l10n/app_hi.arb
• assets/l10n/app_kn.arb
• assets/l10n/app_ta.arb
• lib/ui/process_ui/widgets/update_field_selector.dart

🧰 Additional context used

🧠 Learnings (3)

📓 Common learnings

Learnt from: MadhuMosip
Repo: mosip/android-registration-client PR: 669
File: android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java:132-132
Timestamp: 2026-01-13T11:37:29.220Z
Learning: In the MOSIP registration client codebase, the configuration property `mosip.registration.fields.to.retain.post.prid.fetch` (constant `FIELDS_TO_RETAIN_ON_PRID_FETCH` in RegistrationConstants.java) is the standardized/expected name from the config system. Despite the "retain" naming, the implementation in `RegistrationDto.removeConfiguredFields()` removes the fields specified in this config. This naming is intentional and should not be changed.

📚 Learning: 2026-01-05T05:15:49.771Z

Learnt from: MadhuMosip
Repo: mosip/android-registration-client PR: 661
File: lib/ui/process_ui/widgets/update_field_selector.dart:64-72
Timestamp: 2026-01-05T05:15:49.771Z
Learning: In lib/ui/process_ui/widgets/update_field_selector.dart, ensure that the process configuration contains only one field type (either UIN or VID). Consequently, the existing idSubType determination logic (scanning the fields for the first 'uin' or 'vid' subType) is appropriate for this use case. If future changes introduce multiple field types, revise the idSubType resolution to handle both, with clear validation to prevent mixing types.

Applied to files:

• lib/ui/process_ui/widgets/update_field_selector.dart

📚 Learning: 2026-01-13T11:37:29.220Z

Learnt from: MadhuMosip
Repo: mosip/android-registration-client PR: 669
File: android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java:132-132
Timestamp: 2026-01-13T11:37:29.220Z
Learning: In the MOSIP registration client codebase, the configuration property `mosip.registration.fields.to.retain.post.prid.fetch` (constant `FIELDS_TO_RETAIN_ON_PRID_FETCH` in RegistrationConstants.java) is the standardized/expected name from the config system. Despite the "retain" naming, the implementation in `RegistrationDto.removeConfiguredFields()` removes the fields specified in this config. This naming is intentional and should not be changed.

Applied to files:

• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java

🔇 Additional comments (12)

lib/ui/process_ui/widgets/update_field_selector.dart (1)

39-39: LGTM!

The rename from inputValidation to idRegex improves code clarity by explicitly indicating this regex validates ID (UIN/VID) format. The change is consistent across declaration and usage.

Also applies to: 225-225

assets/l10n/app_en.arb (1)

305-305: LGTM!

The new REG_PKT_APPRVL_CNT_EXCEED error message is well-structured, follows existing naming conventions, and provides a clear, actionable message for users when the packet approval limit is reached. The ICU select syntax is correct.

assets/l10n/app_fr.arb (1)

305-305: LGTM!

The French translation accurately conveys the error message meaning and maintains consistency with the English source. The ICU select syntax is correct.

assets/l10n/app_kn.arb (1)

305-305: LGTM!

The Kannada localization for REG_PKT_APPRVL_CNT_EXCEED is properly added with correct ICU select syntax, maintaining consistency with other locale files.

assets/l10n/app_hi.arb (1)

305-305: LGTM!

The Hindi localization for REG_PKT_APPRVL_CNT_EXCEED is properly added with correct ICU select syntax, maintaining consistency with other locale files.

assets/l10n/app_ar.arb (1)

305-305: LGTM!

The Arabic localization for REG_PKT_APPRVL_CNT_EXCEED is properly added with correct ICU select syntax, maintaining consistency with other locale files.

assets/l10n/app_ta.arb (1)

314-314: LGTM!

The new REG_PKT_APPRVL_CNT_EXCEED error code is properly added to the ICU select statement with a Tamil translation. This aligns with the new validation check added in RegistrationServiceImpl.doPreChecksBeforeRegistration().

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java (2)

132-132: LGTM!

The new constant FIELDS_TO_RETAIN_ON_PRID_FETCH is correctly defined and follows the existing naming conventions. Based on learnings, the naming is intentional and aligns with the standardized config property from the MOSIP config system.

---

150-150: LGTM!

The new constant REG_PAK_MAX_CNT_APPRV_LIMIT follows the existing pattern (similar to REG_PAK_MAX_TIME_APPRV_LIMIT at line 135) and is correctly placed.

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java (1)

250-256: LGTM!

Both accessor methods follow the established patterns in this class:

• getCachedStringFieldsToRetainOnPridFetch() mirrors other string accessors like getCachedStringForgotPassword()
• getCachedIntRegMaxCountApproveLimit() mirrors other integer accessors like getCachedIntegerDiskSpaceSize()

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/RegistrationServiceImpl.java (1)

673-677: LGTM!

The new validation check follows the established pattern of the other pre-checks in this method. The null-safety check on packetService is correctly applied, and the error code REG_PKT_APPRVL_CNT_EXCEED matches the localization entries added in the ARB files.

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/PacketServiceImpl.java (1)

463-465: This review comment is incorrect.

The NumberFormatException catch block at lines 463-465 is reachable and valid. The repository method getCachedIntegerGlobalParam() calls Integer.parseInt(value) (line 100 in GlobalParamRepository) without handling the exception internally, allowing NumberFormatException to propagate to the caller in PacketServiceImpl. If the global parameter value is not a valid integer string, the exception will be thrown and caught by the existing handler.

Likely an incorrect or invalid review comment.

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In
@android/clientmanager/src/main/java/io/mosip/registration/clientmanager/dto/registration/RegistrationDto.java:
- Around line 403-424: In retainConfiguredFields (RegistrationDto), replace the
undefined keysToRemove with the declared keysToRetain and use it in the contains
check; specifically, update the lambda so it calls keysToRetain.contains(key)
and removes the key when true (since the config lists fields to be removed per
the intent), leaving demographics/documents/biometrics handling unchanged.

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2db2cd6 and 5c86214.

📒 Files selected for processing (2)

• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/dto/registration/RegistrationDto.java
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/external/impl/PreRegZipHandlingServiceImpl.java

🚧 Files skipped from review as they are similar to previous changes (1)

• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/external/impl/PreRegZipHandlingServiceImpl.java

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: MadhuMosip
Repo: mosip/android-registration-client PR: 669
File: android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java:132-132
Timestamp: 2026-01-13T11:37:37.805Z
Learning: In the MOSIP registration client codebase, the configuration property `mosip.registration.fields.to.retain.post.prid.fetch` (constant `FIELDS_TO_RETAIN_ON_PRID_FETCH` in RegistrationConstants.java) is the standardized/expected name from the config system. Despite the "retain" naming, the implementation in `RegistrationDto.removeConfiguredFields()` removes the fields specified in this config. This naming is intentional and should not be changed.

📚 Learning: 2026-01-13T11:37:37.805Z

Learnt from: MadhuMosip
Repo: mosip/android-registration-client PR: 669
File: android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java:132-132
Timestamp: 2026-01-13T11:37:37.805Z
Learning: In the MOSIP registration client codebase, the configuration property `mosip.registration.fields.to.retain.post.prid.fetch` (constant `FIELDS_TO_RETAIN_ON_PRID_FETCH` in RegistrationConstants.java) is the standardized/expected name from the config system. Despite the "retain" naming, the implementation in `RegistrationDto.removeConfiguredFields()` removes the fields specified in this config. This naming is intentional and should not be changed.

Applied to files:

• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/dto/registration/RegistrationDto.java

🧬 Code graph analysis (1)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/dto/registration/RegistrationDto.java (1)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java (1)

• RegistrationConstants (9-151)

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0d25701 and 972627a.

📒 Files selected for processing (1)

• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/PacketServiceImpl.java

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: MadhuMosip
Repo: mosip/android-registration-client PR: 669
File: android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java:132-132
Timestamp: 2026-01-13T11:37:37.805Z
Learning: In the MOSIP registration client codebase, the configuration property `mosip.registration.fields.to.retain.post.prid.fetch` (constant `FIELDS_TO_RETAIN_ON_PRID_FETCH` in RegistrationConstants.java) is the standardized/expected name from the config system. Despite the "retain" naming, the implementation in `RegistrationDto.removeConfiguredFields()` removes the fields specified in this config. This naming is intentional and should not be changed.