MOSIP-37901 - Exclude MOSIP services from being published or released (develop)#210
Conversation
… (develop) Signed-off-by: Nidhi0201 <nidhi.k@cyberpwn.com>
WalkthroughUpdated the Maven Central Publishing plugin configuration by adding an explicit Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
biosdk-services/pom.xml (1)
315-327:⚠️ Potential issue | 🟠 MajorAdd
skipPublishingto explicitly prevent publishing at the plugin level.
<phase>none</phase>prevents this execution from running through the normal Maven lifecycle, but does not protect against external CI jobs invokingmvn deploy. Since this PR's goal is to exclude the service from publishing, add<skipPublishing>true</skipPublishing>to prevent publish attempts even if the goal is triggered:Proposed fix
<configuration> <publishingServerId>ossrh</publishingServerId> <autoPublish>false</autoPublish> + <skipPublishing>true</skipPublishing> </configuration>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@biosdk-services/pom.xml` around lines 315 - 327, The POM's plugin execution with <id>default-publish</id> and <goal>publish</goal> can still be triggered externally; update the plugin <configuration> (where <publishingServerId>ossrh</publishingServerId> and <autoPublish>false</autoPublish> are set) to include <skipPublishing>true</skipPublishing> so the publish step is explicitly disabled at the plugin level and publishing is prevented even if mvn deploy or the publish goal is invoked.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@biosdk-services/pom.xml`:
- Around line 315-327: The POM's plugin execution with <id>default-publish</id>
and <goal>publish</goal> can still be triggered externally; update the plugin
<configuration> (where <publishingServerId>ossrh</publishingServerId> and
<autoPublish>false</autoPublish> are set) to include
<skipPublishing>true</skipPublishing> so the publish step is explicitly disabled
at the plugin level and publishing is prevented even if mvn deploy or the
publish goal is invoked.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a8b2f5ef-700b-4cad-be4c-5530c4336f0c
📒 Files selected for processing (1)
biosdk-services/pom.xml
…
Summary by CodeRabbit