Skip to content

MOSIP-37901 - Exclude MOSIP services from being published or released (develop)#210

Merged
Prafulrakhade merged 1 commit into
mosip:developfrom
NidhiKumari0201:MOSIP-37901-develop-nexus
Apr 21, 2026
Merged

MOSIP-37901 - Exclude MOSIP services from being published or released (develop)#210
Prafulrakhade merged 1 commit into
mosip:developfrom
NidhiKumari0201:MOSIP-37901-develop-nexus

Conversation

@NidhiKumari0201
Copy link
Copy Markdown
Contributor

@NidhiKumari0201 NidhiKumari0201 commented Apr 21, 2026

Summary by CodeRabbit

  • Chores
    • Updated build configuration to refine plugin execution settings for the Maven publishing workflow.

… (develop)

Signed-off-by: Nidhi0201 <nidhi.k@cyberpwn.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 21, 2026

Walkthrough

Updated the Maven Central Publishing plugin configuration by adding an explicit executions block that binds the publish goal to the none phase, allowing fine-grained control over the publishing lifecycle without modifying other plugin settings.

Changes

Cohort / File(s) Summary
Maven Plugin Configuration
biosdk-services/pom.xml
Added explicit executions block to central-publishing-maven-plugin with a default-publish execution bound to the none phase and publish goal (9 lines added).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A hop, skip, and a Maven leap,
The publish phase now runs so deep,
With none bound tight and goals so clear,
The artifact will find its way from here! 📦✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title directly describes the main change: excluding MOSIP services from being published or released by modifying Maven plugin execution configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
biosdk-services/pom.xml (1)

315-327: ⚠️ Potential issue | 🟠 Major

Add skipPublishing to explicitly prevent publishing at the plugin level.

<phase>none</phase> prevents this execution from running through the normal Maven lifecycle, but does not protect against external CI jobs invoking mvn deploy. Since this PR's goal is to exclude the service from publishing, add <skipPublishing>true</skipPublishing> to prevent publish attempts even if the goal is triggered:

Proposed fix
 				<configuration>
 					<publishingServerId>ossrh</publishingServerId>
 					<autoPublish>false</autoPublish>
+					<skipPublishing>true</skipPublishing>
 				</configuration>
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@biosdk-services/pom.xml` around lines 315 - 327, The POM's plugin execution
with <id>default-publish</id> and <goal>publish</goal> can still be triggered
externally; update the plugin <configuration> (where
<publishingServerId>ossrh</publishingServerId> and
<autoPublish>false</autoPublish> are set) to include
<skipPublishing>true</skipPublishing> so the publish step is explicitly disabled
at the plugin level and publishing is prevented even if mvn deploy or the
publish goal is invoked.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@biosdk-services/pom.xml`:
- Around line 315-327: The POM's plugin execution with <id>default-publish</id>
and <goal>publish</goal> can still be triggered externally; update the plugin
<configuration> (where <publishingServerId>ossrh</publishingServerId> and
<autoPublish>false</autoPublish> are set) to include
<skipPublishing>true</skipPublishing> so the publish step is explicitly disabled
at the plugin level and publishing is prevented even if mvn deploy or the
publish goal is invoked.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a8b2f5ef-700b-4cad-be4c-5530c4336f0c

📥 Commits

Reviewing files that changed from the base of the PR and between bf38d78 and df0d313.

📒 Files selected for processing (1)
  • biosdk-services/pom.xml

@Prafulrakhade Prafulrakhade merged commit ae683cd into mosip:develop Apr 21, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants