Skip to content

[MOSIP-37808] Updated DB attributes of MOSIP esignet#1891

Merged
Prafulrakhade merged 1 commit into
mosip:developfrom
abhishek8shankar:dev
May 23, 2026
Merged

[MOSIP-37808] Updated DB attributes of MOSIP esignet#1891
Prafulrakhade merged 1 commit into
mosip:developfrom
abhishek8shankar:dev

Conversation

@abhishek8shankar
Copy link
Copy Markdown
Member

@abhishek8shankar abhishek8shankar commented May 20, 2026

Summary by CodeRabbit

  • Chores
    • Updated database configuration to use parameterized settings for improved deployment flexibility.

Review Change Stack

Signed-off-by: Abhishek S <127825992+abhishek8shankar@users.noreply.github.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4fe8fe4e-101e-4976-a143-1770ee29f9da

📥 Commits

Reviewing files that changed from the base of the PR and between 6c96063 and 4911a43.

📒 Files selected for processing (1)
  • db_scripts/mosip_esignet/db.sql

Walkthrough

The database initialization script now accepts a parameterized database name via :mosipdbname instead of hardcoding the database name mosip_esignet. This change affects the database comment and psql connection command, making the script reusable across different deployment environments.

Changes

Database Initialization Parameterization

Layer / File(s) Summary
Parameterize database name references
db_scripts/mosip_esignet/db.sql
The COMMENT ON DATABASE statement and the \c psql connection command are updated to use the :mosipdbname parameter instead of the literal mosip_esignet string, enabling flexible database naming across deployments.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • mosip/esignet#1885: Related parameterization of hardcoded mosip_esignet database name to use :mosipdbname parameter in database handling.

Suggested reviewers

  • ckm007

Poem

🐰 A little parameter hops into place,
No more hardcoded names in this space,
:mosipdbname dances with psql's sweet call,
The script is flexible for one and for all! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating database attributes in the DB script to use a parameterized database name instead of hardcoded values.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Prafulrakhade Prafulrakhade merged commit 4418395 into mosip:develop May 23, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants