Skip to content

(MOSIP-42018) Updated deploy-lamda.yml#329

Merged
Ivanmeneges merged 3 commits into
developfrom
Ivanmeneges-patch-4
May 22, 2026
Merged

(MOSIP-42018) Updated deploy-lamda.yml#329
Ivanmeneges merged 3 commits into
developfrom
Ivanmeneges-patch-4

Conversation

@Ivanmeneges
Copy link
Copy Markdown
Contributor

@Ivanmeneges Ivanmeneges commented May 22, 2026

Summary by CodeRabbit

  • Chores
    • Improved deployment process reliability for backend services.

Review Change Stack

Signed-off-by: Ivanmeneges <ivan.anil016@gmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 22, 2026

Warning

Rate limit exceeded

@Ivanmeneges has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 51 minutes and 46 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d9daf779-4e75-41e7-97da-5e272cd482ae

📥 Commits

Reviewing files that changed from the base of the PR and between 794ef81 and c84bd3f.

📒 Files selected for processing (1)
  • .github/workflows/deploy-lamda.yml

Walkthrough

The PR updates .github/workflows/deploy-lamda.yml to scope Lambda deployment build and packaging operations to the notifier-slackbot subdirectory by adding explicit working-directory parameters to the npm ci step and the zip packaging step.

Changes

Lambda Deployment Workflow Directory Scoping

Layer / File(s) Summary
Working directory scoping for notifier-slackbot
.github/workflows/deploy-lamda.yml
Workflow steps for dependency installation and package creation now execute within notifier-slackbot using explicit working-directory parameters, ensuring npm ci and zip operations target the correct subdirectory for index.js, node_modules, package.json, and package-lock.json.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

  • mosip/kattu#328: Also modifies .github/workflows/deploy-lamda.yml to align build steps around the notifier-slackbot/ directory, updating actions/setup-node caching alongside this PR's packaging changes.
  • mosip/kattu#324: Previously modified the same workflow file to set the notifier-slackbot working directory for Lambda packaging and zip creation steps.

Suggested reviewers

  • ckm007

Poem

🐰 A zip that knows its place,
In notifier-slackbot's space,
With working-directory set right,
Lambda deploys through the night!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title references a Jira ticket (MOSIP-42018) and indicates a workflow file update, which aligns with the changeset that modifies the deploy-lamda.yml workflow file to adjust build-and-package steps.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch Ivanmeneges-patch-4

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/deploy-lamda.yml:
- Around line 47-52: The step-level working-directory entries are inconsistent
with the job default and cause npm/zip/aws CLI to run in the wrong folder;
update the steps named "Zip deployment package" and the preceding "npm ci" step
(and the aws lambda update step that references --zip-file) to use the same
working-directory as the job default (or remove the step-level working-directory
so they inherit the job default), ensuring the zip is created and referenced
from the same path.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ddd89af6-bae1-46cb-93b0-1b894672a437

📥 Commits

Reviewing files that changed from the base of the PR and between 951715c and 794ef81.

📒 Files selected for processing (1)
  • .github/workflows/deploy-lamda.yml

Comment thread .github/workflows/deploy-lamda.yml Outdated
Signed-off-by: Ivanmeneges <ivan.anil016@gmail.com>
Signed-off-by: Ivanmeneges <ivan.anil016@gmail.com>
@Ivanmeneges Ivanmeneges merged commit 0a674b1 into develop May 22, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant