From 9f696171090ad73041023878975b5018cccb95df Mon Sep 17 00:00:00 2001
From: Jonas Jenwald <jonas.jenwald@gmail.com>
Date: Mon, 9 Mar 2026 18:00:11 +0100
Subject: [PATCH] Fix the `disableFontFace` and `fontExtraProperties` asserts
 in the `FontFaceObject` constructor (PR 20197 follow-up)

In PR 19548 these checks were added to ensure that the font-data sent from the worker-thread *always* include correct `disableFontFace` and `fontExtraProperties` data.

For some reason PR 20197 then changed the code such that these checks became effectively pointless, since these properties are now checked after the fact *and* the new getters provide fallback values.
---
 src/display/font_loader.js | 23 +++++++++++++----------
 1 file changed, 13 insertions(+), 10 deletions(-)

diff --git a/src/display/font_loader.js b/src/display/font_loader.js
index b7b27e6ddbfd8..0ace54eb5a559 100644
--- a/src/display/font_loader.js
+++ b/src/display/font_loader.js
@@ -355,19 +355,22 @@ class FontLoader {
 }
 
 class FontFaceObject {
+  compiledGlyphs = Object.create(null);
+
   #fontData;
 
   constructor(translatedData, inspectFont = null, extra, charProcOperatorList) {
-    this.compiledGlyphs = Object.create(null);
-    this.#fontData = translatedData;
     if (typeof PDFJSDev === "undefined" || PDFJSDev.test("TESTING")) {
-      if (typeof this.disableFontFace !== "boolean") {
-        unreachable("disableFontFace must be available.");
-      }
-      if (typeof this.fontExtraProperties !== "boolean") {
-        unreachable("fontExtraProperties must be available.");
-      }
+      assert(
+        typeof translatedData.disableFontFace === "boolean",
+        "disableFontFace must be available."
+      );
+      assert(
+        typeof translatedData.fontExtraProperties === "boolean",
+        "fontExtraProperties must be available."
+      );
     }
+    this.#fontData = translatedData;
     this._inspectFont = inspectFont;
     if (extra) {
       Object.assign(this, extra);
@@ -453,7 +456,7 @@ class FontFaceObject {
   }
 
   get disableFontFace() {
-    return this.#fontData.disableFontFace ?? false;
+    return this.#fontData.disableFontFace;
   }
 
   set disableFontFace(value) {
@@ -461,7 +464,7 @@ class FontFaceObject {
   }
 
   get fontExtraProperties() {
-    return this.#fontData.fontExtraProperties ?? false;
+    return this.#fontData.fontExtraProperties;
   }
 
   get isInvalidPDFjsFont() {