Skip to content

Prompt users with a warning when concatenating orientations with different CS/SS #2533

@PhilKro

Description

@PhilKro

Is your feature request related to a problem? Please describe.

Right now if I erroneously/unknowingly concatenate orientations of different CS/SS, the CS/SS of the concatenated orientation just get silently overwritten:

>> CS1 = crystalSymmetry('m3m')
 
CS1 = crystalSymmetry
 
  symmetry: m-3m   
  elements: 48     
  a, b, c : 1, 1, 1
 
>> CS2 = crystalSymmetry('6/mmm')
 
CS2 = crystalSymmetry
 
  symmetry       : 6/mmm             
  elements       : 24                
  a, b, c        : 1, 1, 1           
  reference frame: X||a*, Y||b, Z||c*
 
>> ori1 = orientation.byEuler(1,2,3,CS1,CS1)
 
ori1 = misorientation (m-3m → m-3m)
 
  Bunge Euler angles in degree
     phi1     Phi    phi2
  57.2958 114.592 171.887
 
>> ori2 = orientation.byEuler(3,2,1,CS2,CS2)
 
ori2 = misorientation (6/mmm → 6/mmm)
 
  Bunge Euler angles in degree
     phi1     Phi    phi2
  171.887 114.592 57.2958
 
>> [ori1, ori2]
 
ans = misorientation (m-3m → m-3m)
  size: 1 x 2
 
  Bunge Euler angles in degree
     phi1     Phi    phi2
  57.2958 114.592 171.887
  171.887 114.592 57.2958

Describe the solution you'd like

Just as with multiplications of orientations, propt a warning that the CS/SS are not matching.

Propose a Syntax

Warning: Symmetry missmatch! The following crystal frames seem to be different

m-3m
6/mmm, X||a*, Y||b, Z||c*

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions