-
-
Notifications
You must be signed in to change notification settings - Fork 59
🎨 Clean up QIR support #1619
Copy link
Copy link
Labels
MLIRAnything related to MLIRAnything related to MLIRenhancementImprovement of existing featureImprovement of existing feature
Metadata
Metadata
Assignees
Labels
MLIRAnything related to MLIRAnything related to MLIRenhancementImprovement of existing featureImprovement of existing feature
Type
Fields
Give feedbackNo fields configured for Task.
With #1580, we have started to mix the adaptive and base profiles. We should clean up a few things.
The output handling is no longer compliant with the base profile. We should re-add the simpler output recording (see #1580 (comment) and #1580 (comment)). In a related note, we might not always want to use dynamic result allocation (see #1580 (comment)).
Independent of this, the base profile technically does not support reset operations, which should be kept in mind in
QIRProgramBuilder.cppandQCToQIR.cpp(see #1580 (comment)).In general, we will need to differentiate between the two profiles during QIR creation.