Performance Improvements

[museHD]

Performance should be improved wherever it can be.

Some ways performance can be improved...

• References to static variables
• Optimising loops
• Unnecessary variables
• etc

Please add observations/errors that can make the website more efficient.

[yaki3355]

Hey,

Remove this line:

DoublePendulum/scripts/main.js

Line 55 in 89cfa9b

this,length = 150;

It does nothing.

Line 49 already does the assignment correctly.

[museHD]

Hi @yaki3355 thank you for your input!
Feel free to submit a PR for the change requested!

Cheers!

[Dun-sin]

Some variables are declared with var, instead of const or let

[museHD]

Hi @Dun-sin

Thank you for your response.
Could you please provide a bit more detail as to which function in particular you are looking at or how many changes might need to be made?
Also, how much of a performance difference will this make? I found conflicting answers on the internet regarding the performance difference between var/let/const and looks like they're also dependent on the browser they are running on.
If you think it can make a large difference, could you benchmark the app on your computer and then benchmark it again after the changes to see what the performance difference is?
Also, I'm still learning JS so please point it out if I'm wrong :)

Thanks!

[Dun-sin]

Hi @Dun-sin

Thank you for your response. Could you please provide a bit more detail as to which function in particular you are looking at or how many changes might need to be made? Also, how much of a performance difference will this make? I found conflicting answers on the internet regarding the performance difference between var/let/const and looks like they're also dependent on the browser they are running on. If you think it can make a large difference, could you benchmark the app on your computer and then benchmark it again after the changes to see what the performance difference is? Also, I'm still learning JS so please point it out if I'm wrong :)

Thanks!

With the latest Javascript version, var was replaced with let and const because they are more save(security wise) and help avoid bugs that can lead to other problems

[museHD]

Ok, are you able to benchmark it with the current version and new changes and see how the performance changes?

[Dun-sin]

Ok, are you able to benchmark it with the current version and new changes and see how the performance changes?

Nope

[museHD]

Ok if anyone else is interested in taking this up please let me know