From dad4bb6b63784cb62564f3cd6a81ea3b83e4ac38 Mon Sep 17 00:00:00 2001 From: ajuncosa Date: Wed, 24 Jun 2026 18:03:50 +0200 Subject: [PATCH 1/3] Fix: propagate the spanner's 'visible' property to the new segment being added in Spanner::add --- src/engraving/dom/spanner.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/engraving/dom/spanner.cpp b/src/engraving/dom/spanner.cpp index 864e582417a1f..70e2cfaa024a8 100644 --- a/src/engraving/dom/spanner.cpp +++ b/src/engraving/dom/spanner.cpp @@ -474,6 +474,7 @@ void Spanner::add(EngravingItem* e) ls->setTrack(track()); // ls->setAutoplace(autoplace()); ls->EngravingItem::setZ(z()); + ls->EngravingItem::setVisible(visible()); m_segments.push_back(ls); e->added(); } From c9cb8314e2a81b743c4d41c02891d54d350cf0c5 Mon Sep 17 00:00:00 2001 From: ajuncosa Date: Mon, 13 Jul 2026 09:43:10 +0200 Subject: [PATCH 2/3] Fix EditVisibility::cmdToggleVisible to get and set the VISIBLE property using getProperty and setProperty instead of getting it through visible() (to ensure that they both go through property delegates, if any) --- src/engraving/editing/editvisibility.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/engraving/editing/editvisibility.cpp b/src/engraving/editing/editvisibility.cpp index febf36d45b2bb..8498ece7ab635 100644 --- a/src/engraving/editing/editvisibility.cpp +++ b/src/engraving/editing/editvisibility.cpp @@ -60,7 +60,7 @@ void EditVisibility::toggleVisible(Transaction& tx, Score* score) bool allVisible = true; for (EngravingItem* item : score->selection().elements()) { - if (!item->visible()) { + if (!item->getProperty(Pid::VISIBLE).toBool()) { allVisible = false; break; } From e9f04bf428c713bcbb116af25db500155d5951f4 Mon Sep 17 00:00:00 2001 From: ajuncosa Date: Mon, 13 Jul 2026 17:45:59 +0200 Subject: [PATCH 3/3] Fix uninitialised variable in ExportMusicXml --- src/importexport/musicxml/internal/export/exportmusicxml.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/importexport/musicxml/internal/export/exportmusicxml.cpp b/src/importexport/musicxml/internal/export/exportmusicxml.cpp index 5997e3532549d..1511325e88695 100644 --- a/src/importexport/musicxml/internal/export/exportmusicxml.cpp +++ b/src/importexport/musicxml/internal/export/exportmusicxml.cpp @@ -440,7 +440,7 @@ class ExportMusicXml : public muse::Contextable TrillHash m_trillStart; TrillHash m_trillStop; MusicXmlInstrumentMap m_instrMap; - PlayingTechniqueType m_currPlayTechnique; + PlayingTechniqueType m_currPlayTechnique = PlayingTechniqueType::Undefined; bool m_isMxl = false; };