From 8c2fc8289980f513733e807a03b75ba6283870e1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ismael=20Venegas=20Castell=C3=B3?= Date: Mon, 27 Sep 2021 12:28:52 -0500 Subject: [PATCH 1/5] Update README.md Make convention description reflect what the plugin actually does. --- README.md | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/README.md b/README.md index 5a9f7ad..58d721b 100644 --- a/README.md +++ b/README.md @@ -15,14 +15,16 @@ If you want to have your harmonica added to the it, please contact me, or better ##Convention -* "+" = blow -* "-" = draw -* ' = halfstep bend -* " = whole step bend -* "' = 3 halfsteps bend -* +X? = overblow -* -X? = overdraw -* "<" = slide +* `+4` = blow +* `-4` = draw +* `-3b` = halfstep bend +* `-3bb` = whole step bend +* `-3bbb` = 3 halfsteps bend +* `+6o` = overblow +* `-9o` = overdraw +* `+4s` = slide (chromatic) +* `+1°` = lower register in 16 holes chromatic (1°, 2°, 3°, 4°, 1, 2, 3, 4, 5, 6, 7 , 8, 9 ,10, 11, 12) + Bends, over blow, over draw may be supported if it's the only way to play the note. If there are two holes for one note, a choice has been made (draw) From 79d78e599ec9ac80d2b4b25c97c43f52dc3f0f7e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ismael=20Venegas=20Castell=C3=B3?= Date: Mon, 27 Sep 2021 12:31:45 -0500 Subject: [PATCH 2/5] Add 16 Chromatic support. Include tuning for 16 Holes Chromatic Harmonica and special case when tuning is C as opposed to Low C (which is used as starting point), so that it uses Low C automatically if 16 Holes Chromatic tuning is selected. --- harmonica_tablature.qml | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/harmonica_tablature.qml b/harmonica_tablature.qml index a35d294..9878e3f 100644 --- a/harmonica_tablature.qml +++ b/harmonica_tablature.qml @@ -92,6 +92,7 @@ MuseScore { ListElement { text: "Power Bender (Brendan Power), valved"; tuning: 11 } ListElement { text: "Power Draw (Brendan Power), valved"; tuning: 12 } ListElement { text: "Standard Chromatic"; tuning: 4 } + ListElement { text: "16 Hole Standard Chromatic"; tuning: 13} } width: 100 onCurrentIndexChanged: { @@ -162,7 +163,15 @@ MuseScore { var standardChromatic = ["+1", '+1s', "-1", "-1s", "+2", "-2", "-2s", "+3", "+3s", "-3", "-3s","-4", "+4", "+4s", "-5", "-5s", "+6", "-6", "-6s", "+7", "+7s", "-7", "-7s", "-8", "+8", "+8s", "-9", "-9s", "+10", "-10", "-10s", "+11", "+11s", "-11", "-11s", "-12", - "+12", "+12s", "-12", "-12s" ]; + "+12", "+12s", "-12s" ]; + + var standard16Chromatic = [ + "+1°", '+1°s', "-1°", "-1°s", "+2°", "-2°", "-2°s", "+3°", "+3°s", "-3°", "-3°s","-4°", + "+1", '+1s', "-1", "-1s", "+2", "-2", "-2s", "+3", "+3s", "-3", "-3s","-4", + "+4", "+4s", "-5", "-5s", "+6", "-6", "-6s", "+7", "+7s", "-7", "-7s", "-8", + "+8", "+8s", "-9", "-9s", "+10", "-10", "-10s", "+11", "+11s", "-11", "-11s", "-12", + "+12", "+12s", "-12s" + ]; var zirkValved = ["+1", "-1b", "-1", "+2b", "+2", "-2", "+3b", "+3", "-3b", "-3", "+4", "-4b", "-4", "+5b", "+5", "-5b", "-5", "+6", "-6b", "-6", "+7b", "+7", "-7", "+8b", @@ -220,12 +229,22 @@ MuseScore { case 10: tuning = paddyRichter; break; case 11: tuning = powerBender; break; case 12: tuning = powerDraw; break; + case 13: tuning = standard16Chromatic; break; default: tuning = richter; break; } var harpkey = keylist.key console.log("harpkey set to " + keylist.key) + // For 16 Holes Standard C Chromatic + var C3 = 48; + var C4 = 60; + var chromatic16Tuning = 13; + + if (harpkey == C4 && harp.tuning == chromatic16Tuning) { + harpkey = C3; + } + for (var i = 0; i < notes.length; i++) { if ( i > 0 ) From 357a9f6b24e61163d56b8a0343e03e941c7e7755 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ismael=20Venegas=20Castell=C3=B3?= Date: Mon, 27 Sep 2021 19:00:01 -0500 Subject: [PATCH 3/5] Update harmonica_tablature.qml --- harmonica_tablature.qml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/harmonica_tablature.qml b/harmonica_tablature.qml index 9878e3f..3f321b5 100644 --- a/harmonica_tablature.qml +++ b/harmonica_tablature.qml @@ -166,7 +166,7 @@ MuseScore { "+12", "+12s", "-12s" ]; var standard16Chromatic = [ - "+1°", '+1°s', "-1°", "-1°s", "+2°", "-2°", "-2°s", "+3°", "+3°s", "-3°", "-3°s","-4°", + "+1\u00B0", '+1\u00B0s', "-1\u00B0", "-1\u00B0s", "+2\u00B0", "-2\u00B0", "-2\u00B0s", "+3\u00B0", "+3\u00B0s", "-3\u00B0", "-3\u00B0s","-4\u00B0", "+1", '+1s', "-1", "-1s", "+2", "-2", "-2s", "+3", "+3s", "-3", "-3s","-4", "+4", "+4s", "-5", "-5s", "+6", "-6", "-6s", "+7", "+7s", "-7", "-7s", "-8", "+8", "+8s", "-9", "-9s", "+10", "-10", "-10s", "+11", "+11s", "-11", "-11s", "-12", From 879be79c4285e4d30debf4b0ce8cbf5bd9e7a591 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ismael=20Venegas=20Castell=C3=B3?= Date: Mon, 27 Sep 2021 21:39:33 -0500 Subject: [PATCH 4/5] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 58d721b..46bd378 100644 --- a/README.md +++ b/README.md @@ -23,7 +23,7 @@ If you want to have your harmonica added to the it, please contact me, or better * `+6o` = overblow * `-9o` = overdraw * `+4s` = slide (chromatic) -* `+1°` = lower register in 16 holes chromatic (1°, 2°, 3°, 4°, 1, 2, 3, 4, 5, 6, 7 , 8, 9 ,10, 11, 12) +* `+1*` = lower register in 16 holes chromatic (1*, 2*, 3*, 4*, 1, 2, 3, 4, 5, 6, 7 , 8, 9 ,10, 11, 12) Bends, over blow, over draw may be supported if it's the only way to play the note. From d6698a6a03800ca2bdb25ede779cb049c21f4d8f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ismael=20Venegas=20Castell=C3=B3?= Date: Mon, 27 Sep 2021 21:41:29 -0500 Subject: [PATCH 5/5] Update harmonica_tablature.qml --- harmonica_tablature.qml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/harmonica_tablature.qml b/harmonica_tablature.qml index 3f321b5..294fb9e 100644 --- a/harmonica_tablature.qml +++ b/harmonica_tablature.qml @@ -166,7 +166,7 @@ MuseScore { "+12", "+12s", "-12s" ]; var standard16Chromatic = [ - "+1\u00B0", '+1\u00B0s', "-1\u00B0", "-1\u00B0s", "+2\u00B0", "-2\u00B0", "-2\u00B0s", "+3\u00B0", "+3\u00B0s", "-3\u00B0", "-3\u00B0s","-4\u00B0", + "+1*", '+1*s', "-1*", "-1*s", "+2*", "-2*", "-2*s", "+3*", "+3*s", "-3*", "-3*s","-4*", "+1", '+1s', "-1", "-1s", "+2", "-2", "-2s", "+3", "+3s", "-3", "-3s","-4", "+4", "+4s", "-5", "-5s", "+6", "-6", "-6s", "+7", "+7s", "-7", "-7s", "-8", "+8", "+8s", "-9", "-9s", "+10", "-10", "-10s", "+11", "+11s", "-11", "-11s", "-12",