Skip to content

Make ignore_comments not default (next major release) #74

@mverleg

Description

@mverleg

Stripping comments from files that are multiple megabytes takes an obscene amount of time, even if there are no comments.

I don't think I can make it much faster without writing a whole json parser (in something other than Python, or it can never compete).

So I'm thinking of something like:

  • Make ignore_comments=False the default
  • Ignore comments only for small files, unless ignore_comments is used to override
  • Only parse comments if the file starts with a comment, unless ignore_comments is used to override
  • Only strip comments on uncompressed files, unless ignore_comments is used to override

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions