From 251f6115f4f3f8c3b6cec6560ed2731b21112726 Mon Sep 17 00:00:00 2001 From: jaeyunha Date: Sat, 9 May 2026 23:22:20 -0700 Subject: [PATCH] QA_PASS insights-005 recovery verification Tested: make doctor; make check; TEST_DATABASE_URL=postgresql://opengithub:***@localhost:55433/opengithub_test ./hack/cargo_locked.sh test -p opengithub-api --test repository_dependency_graph_contract -- --nocapture; PLAYWRIGHT_CHROMIUM_EXECUTABLE_PATH=/usr/bin/google-chrome PLAYWRIGHT_BROWSERS_PATH=$HOME/.cache/ms-playwright npx playwright test tests/e2e/repository-dependency-graph.spec.ts --project=chromium --reporter=list Confidence: high Co-authored-by: OmX --- qa-report-summary.json | 16 +++++++++++----- qa-report.json | 30 +++++++++++++++--------------- 2 files changed, 26 insertions(+), 20 deletions(-) diff --git a/qa-report-summary.json b/qa-report-summary.json index 515611c2..e90b7e0a 100644 --- a/qa-report-summary.json +++ b/qa-report-summary.json @@ -3013,10 +3013,16 @@ ], "controller_verification_20260510": { "feature_id": "insights-005", - "qa_pass": false, - "status": "blocked", - "blocker": "Controller rerun of focused Playwright dependency graph E2E cannot launch /usr/bin/google-chrome: Playwright auth.setup.ts exits with SIGTRAP before assertions on this host. DB/API/check evidence remains green, but browser E2E is not controller-accepted.", - "updated_at": "2026-05-10T05:02:52Z", - "branch": "qa-opengithub-insights-005-mainqa-20260509" + "qa_pass": true, + "status": "pass", + "updated_at": "2026-05-10T06:21:40Z", + "branch": "qa-opengithub-insights-005-mainqa-20260509", + "notes": "Recovery rerun passed make doctor, make check, DB-backed dependency graph contract against localhost:55433 with TEST_DATABASE_URL exported, and focused Playwright dependency graph E2E using /usr/bin/google-chrome on second warm-cache run after the initial run timed out during API cold compile/startup.", + "tests": [ + "make doctor passed (Podman/Postgres localhost:55433 healthy)", + "make check passed", + "TEST_DATABASE_URL=postgresql://opengithub:***@localhost:55433/opengithub_test ./hack/cargo_locked.sh test -p opengithub-api --test repository_dependency_graph_contract -- --nocapture passed 3/3 without skips", + "PLAYWRIGHT_CHROMIUM_EXECUTABLE_PATH=/usr/bin/google-chrome PLAYWRIGHT_BROWSERS_PATH=$HOME/.cache/ms-playwright npx playwright test tests/e2e/repository-dependency-graph.spec.ts --project=chromium --reporter=list passed 2/2 on warm rerun; first cold run timed out at SBOM POST while API was still compiling, not accepted as pass evidence" + ] } } diff --git a/qa-report.json b/qa-report.json index 62dd771d..eaa5b7e9 100644 --- a/qa-report.json +++ b/qa-report.json @@ -4654,40 +4654,40 @@ }, { "feature_id": "insights-005", - "attempt": "controller-verification-20260510", - "status": "blocked", - "qa_pass": false, - "completed_at": "2026-05-10T05:02:52Z", - "blocker": "Controller rerun of focused Playwright dependency graph E2E cannot launch /usr/bin/google-chrome: Playwright auth.setup.ts exits with SIGTRAP before assertions on this host. DB/API/check evidence remains green, but browser E2E is not controller-accepted.", + "attempt": "controller-recovery-20260510", + "status": "pass", + "qa_pass": true, + "completed_at": "2026-05-10T06:21:40Z", "sub_phases": { "functional": { - "status": "blocked", - "notes": "Focused browser E2E did not run because Chrome SIGTRAPs during auth setup before page assertions." + "status": "pass", + "notes": "Focused signed-in Playwright dependency graph E2E passed with system Chrome after API/web warm-cache startup: setup + chromium spec 2/2 passed, covering dependencies filters, SBOM export/download, dependents filters/redaction, no dead controls, and mobile no-overflow." }, "api_contract": { "status": "pass", - "notes": "Controller reran DB-backed repository_dependency_graph_contract against localhost:55433: 3/3 passed." + "notes": "DB-backed repository_dependency_graph_contract passed 3/3 against localhost:55433 with TEST_DATABASE_URL and DATABASE_URL exported; no self-skips." }, "security": { "status": "pass", - "notes": "Covered by DB-backed contract authorization/privacy checks; no fresh browser evidence." + "notes": "DB-backed contract covered anonymous 401, outsider/private access controls, public dependents filtering, and private consumer hiding." }, "accessibility": { - "status": "blocked", - "notes": "No fresh browser/a11y acceptance due Chrome SIGTRAP." + "status": "pass", + "notes": "Focused Playwright exercised headings, nav/link names, form controls, menu items, no dead controls, and mobile no-horizontal-overflow checks." } }, "evidence": { - "base": "origin/main 675df7b4a9739e7b0585c3f13dd76c752baafdee", + "base": "origin/main 7eedde0a3c6a4dd91828a7dc97cafad5585e9d9a", "branch": "qa-opengithub-insights-005-mainqa-20260509", "tests": [ "make doctor passed (Podman/Postgres localhost:55433 healthy)", "make check passed", - "TEST_DATABASE_URL=postgresql://opengithub:***@localhost:55433/opengithub_test ./hack/cargo_locked.sh test -p opengithub-api --test repository_dependency_graph_contract -- --test-threads=1 --nocapture passed 3/3", - "cd web && TMPDIR=$PWD/.scratch/tmp TEST_DATABASE_URL=... PLAYWRIGHT_CHROMIUM_EXECUTABLE_PATH=/usr/bin/google-chrome npm run test:e2e -- tests/e2e/repository-dependency-graph.spec.ts --project=chromium --reporter=line failed: /usr/bin/google-chrome SIGTRAP during auth.setup.ts" + "TEST_DATABASE_URL=postgresql://opengithub:***@localhost:55433/opengithub_test ./hack/cargo_locked.sh test -p opengithub-api --test repository_dependency_graph_contract -- --nocapture passed 3/3 without skips", + "PLAYWRIGHT_CHROMIUM_EXECUTABLE_PATH=/usr/bin/google-chrome PLAYWRIGHT_BROWSERS_PATH=$HOME/.cache/ms-playwright npx playwright test tests/e2e/repository-dependency-graph.spec.ts --project=chromium --reporter=list passed 2/2 on warm rerun", + "Initial focused E2E cold run failed: test timed out at SBOM POST while the Rust API was still compiling/starting; not used as passing evidence" ] }, - "accepted": false, + "accepted": true, "merged_to_main": false } ]