Skip to content

Console "kill" button doesn't work on Windows #37

@isabelburgos

Description

@isabelburgos

Sorry, Windows users.
The console interface added in #29 uses QProcess.start() and QProcess.terminate() to start and stop processes. On Unix systems, QProcess.terminate() sends SIGTERM and this works great. On Windows system, QProcess.terminate() raises WM_CLOSE, and that does nothing to stop the server or GUI processes (both are running asyncio event loops).

I don't want to use QProcess.kill() instead because I want graceful shutdowns. Killing the server without giving it time to shut down means that Glasgow won't necessarily be returned to a neutral state, which for some setups means that control of the microscope's scan system is not returned.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingenhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions