🟡 [Medium] nansen quote --help exits with code 1 instead of 0

[askeluv]

Summary

nansen quote --help successfully displays help text but exits with code 1. All other --help outputs exit 0.

Steps to reproduce

nansen quote --help; echo $?
# → (displays help)
# → 1

Impact

Any script using set -e or checking exit codes will fail when checking trade help. Inconsistent with the rest of the CLI.

Expected

Exit 0 on successful --help display.

Discovered via

Clawfooding — The Lapsed User and Scripter personas (v1.10.0)

[dobbydobap]

Picking this up. Root cause: for commands with a handler (quote/execute), the --help flag doesn't match any branch in the help block, so it falls through to executing the command, which errors on the missing required args and exits 1. Fixing it in the shared help path so quote --help, trade quote --help, and execute --help all print usage and exit 0. PR incoming.