From e67d25f08dbcadecdb1b6a13166f3f963dd5fb5c Mon Sep 17 00:00:00 2001 From: Mark David Date: Mon, 23 Dec 2024 01:24:59 +0200 Subject: [PATCH 1/2] Do not stop checking DataView properties on first failure --- src/linkManager.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/linkManager.ts b/src/linkManager.ts index cc9d1d6..75435ef 100644 --- a/src/linkManager.ts +++ b/src/linkManager.ts @@ -459,10 +459,11 @@ export class LinkManager { } break; default: - //metadata is not a link, return null - return null; + // We will continue to check other DataView properties + continue } } + // If no DataView properties match, we consider that metadata key does not exist return null; } From 7e1346badeabbb6c3c9547e10e4e9b9de9952c4f Mon Sep 17 00:00:00 2001 From: MarkCDavid <40147713+MarkCDavid@users.noreply.github.com> Date: Fri, 7 Mar 2025 19:52:59 +0200 Subject: [PATCH 2/2] Update src/linkManager.ts Instead of continuing, break out of the switch context and allow the loop to continue "naturally". Co-authored-by: Lukas Waslowski --- src/linkManager.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/linkManager.ts b/src/linkManager.ts index 75435ef..a627a78 100644 --- a/src/linkManager.ts +++ b/src/linkManager.ts @@ -460,7 +460,7 @@ export class LinkManager { break; default: // We will continue to check other DataView properties - continue + break; } } // If no DataView properties match, we consider that metadata key does not exist