disable email field

- Practice of accepting user input for email accounts has accumulated a large number of non-ncsu emails that cannot be reliably verified
- Email normalization to unity@ncsu emails, with field set to read-only / pre-populated to deal with undesired data in other applications
- Fixes #51

Author: flashadvocate

application/modules/ot/controllers/AccountController.php

@@ -381,7 +381,12 @@ public function editAction()
         $me = (Zend_Auth::getInstance()->getIdentity()->accountId == $this->_userData['accountId']);
 
         $formData = $this->_userData;
-              
+
+        // override email, populate with unity
+        if (isset($formData['username'])) {
+            // @TODO: Move string portion to config
+            $formData['emailAddress'] = $formData['username'] . "@ncsu.edu";
+        }
 
         if (isset($formData['accountAttributes'])) {
             foreach ($formData['accountAttributes'] as $key => $a) {

application/modules/ot/forms/Account.php

@@ -50,9 +50,8 @@ public function __construct($new = false, $me = false, $options = array())
 
         // Email address field
         $email = $this->createElement('text', 'emailAddress', array('label' => 'model-account-emailAddress'));
-        $email->setRequired(true)
-              ->addFilter('StringTrim')
-              ->addValidator('EmailAddress');
+        $email->addFilter('StringTrim')
+            ->setAttrib('readonly', 'readonly');
 
         $timezone = $this->createElement('select', 'timezone', array('label' => 'model-account-timezone'));
         $timezone->addMultiOptions(Ot_Model_Timezone::getTimezoneList());
@@ -101,14 +100,14 @@ public function __construct($new = false, $me = false, $options = array())
         if (is_null($thisHost)) {
             throw new Ot_Exception_Data('msg-error-objectNotSetup');
         }
-        
+
         $customAttributes = $thisHost->getAttributes();
-        
+
         foreach ($customAttributes as $a) {
             $elm = $a['var']->renderFormElement();
             $elm->clearDecorators();
             $elm->setBelongsTo('customAttributes');
-            
+
             $this->addElement($elm);
         }