Fix: Narrow version regex to only update Identity Version, not MinVersion#8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed the version update regex in release.yml to only target the Identity tag's Version attribute, preventing unintended replacement of TargetDeviceFamily MinVersion values.
Related Issue
Fixes winget validation error: "Inconsistent value in the manifest. [MinimumOSVersion] Value: 0.1.0.0"
Related: microsoft/winget-pkgs#333453
Type of Change
How Has This Been Tested?
Tested the regex pattern with actual Package.appxmanifest file:
BEFORE:
AFTER:
Identity Version="0.1.0.0" ✅ (correctly updated)
Windows.Universal MinVersion="10.0.17763.0" ✅ (unchanged)
Windows.Desktop MinVersion="10.0.17763.0" ✅ (unchanged)
Manual testing of regex pattern
Manual testing on Windows x64 (will be tested after release)
Manual testing on Windows ARM64 (will be tested after release)
Test Configuration:
Screenshots (if applicable)
N/A
Checklist
Breaking Changes
N/A
Additional Notes
This fixes the root cause of winget validation failures. The previous regex
Version="[0-9]+\.[0-9]+\.[0-9]+\.[0-9]+"was too broad and replaced all Version attributes, including MinVersion in TargetDeviceFamily tags.The new regex
(<Identity[^>]*Version=")[0-9]+\.[0-9]+\.[0-9]+\.[0-9]+"specifically targets only the Identity tag's Version attribute.After this PR is merged, v0.1.0 will need to be re-released for the third time to generate correct MSIX packages.