Skip to content

Fix: Narrow version regex to only update Identity Version, not MinVersion#8

Merged
nek0der merged 1 commit into
mainfrom
fix/msix-minversion-regex
Jan 24, 2026
Merged

Fix: Narrow version regex to only update Identity Version, not MinVersion#8
nek0der merged 1 commit into
mainfrom
fix/msix-minversion-regex

Conversation

@nek0der
Copy link
Copy Markdown
Owner

@nek0der nek0der commented Jan 24, 2026

Description

Fixed the version update regex in release.yml to only target the Identity tag's Version attribute, preventing unintended replacement of TargetDeviceFamily MinVersion values.

Related Issue

Fixes winget validation error: "Inconsistent value in the manifest. [MinimumOSVersion] Value: 0.1.0.0"

Related: microsoft/winget-pkgs#333453

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring (no functional changes)
  • Build/CI changes

How Has This Been Tested?

Tested the regex pattern with actual Package.appxmanifest file:

BEFORE:

  • Identity Version="0.0.0.0"
  • Windows.Universal MinVersion="10.0.17763.0"
  • Windows.Desktop MinVersion="10.0.17763.0"

AFTER:

  • Identity Version="0.1.0.0" ✅ (correctly updated)

  • Windows.Universal MinVersion="10.0.17763.0" ✅ (unchanged)

  • Windows.Desktop MinVersion="10.0.17763.0" ✅ (unchanged)

  • Manual testing of regex pattern

  • Manual testing on Windows x64 (will be tested after release)

  • Manual testing on Windows ARM64 (will be tested after release)

Test Configuration:

  • Windows Version: 11 Build 26220
  • PowerShell Version: 7.x

Screenshots (if applicable)

N/A

Checklist

  • My code follows the project's coding style
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • I have added entries to CHANGELOG.md (if applicable)
  • My changes generate no new warnings
  • I have tested my changes locally
  • Any dependent changes have been merged and published

Breaking Changes

N/A

Additional Notes

This fixes the root cause of winget validation failures. The previous regex Version="[0-9]+\.[0-9]+\.[0-9]+\.[0-9]+" was too broad and replaced all Version attributes, including MinVersion in TargetDeviceFamily tags.

The new regex (<Identity[^>]*Version=")[0-9]+\.[0-9]+\.[0-9]+\.[0-9]+" specifically targets only the Identity tag's Version attribute.

After this PR is merged, v0.1.0 will need to be re-released for the third time to generate correct MSIX packages.

@nek0der nek0der merged commit b4773ca into main Jan 24, 2026
5 checks passed
@nek0der nek0der deleted the fix/msix-minversion-regex branch January 24, 2026 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant