Fix PhpHelpers::checkCode crash when PHP binary path contains spaces (#415)

* Dedent: fixed inline content and atLineStart tracking [Closes #412, #413]

* fixed dedent

* improved TagParser::parseType()

* added length to Position

* StatementNode: added tagPositions

* updated github actions

* wip

* Fix PhpHelpers::checkCode crash when PHP binary path contains spaces

proc_open with a string command goes through the shell, which splits
the path at spaces. This breaks on macOS with Laravel Herd where
PHP_BINARY is e.g. /Users/.../Application Support/Herd/bin/php84.

Using an array bypasses the shell entirely, which is also what the
existing bypass_shell option was intended to do (but only works on
Windows).

---------

Co-authored-by: David Grudl <david@grudl.com>

Author: davidkvasnovsky

src/Latte/Compiler/PhpHelpers.php

@@ -251,7 +251,7 @@ private static function codePointToUtf8(int $num): string
 	public static function checkCode(string $phpBinary, string $code, string $name): void
 	{
 		$process = proc_open(
-			$phpBinary . ' -l -n',
+			[$phpBinary, '-l', '-n'],
 			[['pipe', 'r'], ['pipe', 'w'], ['pipe', 'w']],
 			$pipes,
 			null,

src/Latte/Compiler/TemplateParser.php

@@ -215,7 +215,11 @@ public function parseLatteStatement(?\Closure $resolver = null): ?Node
 					$this->lookFor[$startTag] = $res->current() ?: null;
 					$content = $this->parseFragment($resolver ?? $this->lastResolver);
 					if ($this->dedent) {
+<<<<<<< fix/php-binary-space-in-path
+						$this->applyDedent($content, $startTag);
+=======
 						Dedent::apply($content, $startTag);
+>>>>>>> master
 					}
 
 					if (!$this->stream->is(Token::Latte_TagOpen)) {
@@ -506,4 +510,86 @@ public function isTagAllowed(string $name): bool
 	{
 		return !$this->policy || $this->policy->isTagAllowed($name);
 	}
+<<<<<<< fix/php-binary-space-in-path
+
+
+	private function applyDedent(FragmentNode $fragment, Tag $startTag): void
+	{
+		$baseIndent = null;
+		$atLineStart = true;
+		$inlineChecked = false;
+		// When the tag is inside an HTML element, preserve indent up to the tag's column
+		// (structural indent). When top-level, strip to column 1.
+		$tagIndentLen = $startTag->htmlElement !== null ? $startTag->position->column - 1 : 0;
+
+		foreach ($fragment->children as $i => $child) {
+			if ($child instanceof Nodes\TextNode && $child->content === '') {
+				continue;
+
+			} elseif (!$inlineChecked) {
+				$inlineChecked = true;
+				if ($child->position?->line === $startTag->position->line) {
+					return;
+				}
+			}
+			if (!$child instanceof Nodes\TextNode) {
+				continue;
+			}
+
+			$lines = explode("\n", $child->content);
+			$lineCount = count($lines);
+			$lastContinues = !str_ends_with($child->content, "\n") && $i + 1 < count($fragment->children);
+
+			foreach ($lines as $j => &$line) {
+				$isLineStart = $j === 0 ? $atLineStart : true;
+				if (!$isLineStart || $line === '') {
+					continue;
+				}
+
+				$hasContent = trim($line) !== '';
+				$continuesWithExpr = !$hasContent && $j === $lineCount - 1 && $lastContinues;
+
+				if ($baseIndent === null) {
+					if ($hasContent) {
+						preg_match('/^(\t+| +)/', $line, $m);
+						$baseIndent = $m[1] ?? null;
+						if ($baseIndent === null || strlen($baseIndent) <= $tagIndentLen) {
+							return; // first content line has no indent beyond tag level
+						}
+
+					} elseif ($continuesWithExpr) {
+						// Top-level tag whose first child is an HTML element: leave structural
+						// HTML indentation untouched.
+						if ($startTag->htmlElement === null
+							&& ($fragment->children[$i + 1] ?? null) instanceof Nodes\Html\ElementNode
+						) {
+							return;
+						}
+						$baseIndent = $line;
+						if (strlen($baseIndent) <= $tagIndentLen) {
+							return;
+						}
+
+					} else {
+						continue; // blank line before detection
+					}
+
+				} elseif (!str_starts_with($line, $baseIndent)) {
+					if ($hasContent || $continuesWithExpr) {
+						throw new CompileException('Inconsistent indentation.', $child->position ? new Position($child->position->line + $j, 1) : null);
+					}
+
+					continue; // blank line, strip silently
+				}
+
+				$line = substr($line, 0, $tagIndentLen) . substr($line, strlen((string) $baseIndent));
+			}
+
+			unset($line);
+			$child->content = implode("\n", $lines);
+			$atLineStart = str_ends_with($child->content, "\n");
+		}
+	}
+=======
+>>>>>>> master
 }