crypto: fix Argon2 validation errors

Report the correct parameter name for invalid optional inputs.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>

Author: panva

lib/internal/crypto/argon2.js

@@ -169,15 +169,15 @@ function check(algorithm, parameters) {
   if (parameters.secret === undefined) {
     secret = new Uint8Array(0);
   } else {
-    secret = getArrayBufferOrView(parameters.secret);
+    secret = getArrayBufferOrView(parameters.secret, 'parameters.secret');
     validateInteger(secret.byteLength, 'parameters.secret.byteLength', 0, MAX_POSITIVE_UINT_32);
   }
 
   let associatedData;
   if (parameters.associatedData === undefined) {
     associatedData = new Uint8Array(0);
   } else {
-    associatedData = getArrayBufferOrView(parameters.associatedData);
+    associatedData = getArrayBufferOrView(parameters.associatedData, 'parameters.associatedData');
     validateInteger(associatedData.byteLength, 'parameters.associatedData.byteLength', 0, MAX_POSITIVE_UINT_32);
   }
 

test/parallel/test-crypto-argon2.js

@@ -140,6 +140,18 @@ for (const key of Object.keys(defaults)) {
   assert.throws(() => crypto.argon2Sync('argon2id', parameters), expected);
 }
 
+for (const key of ['secret', 'associatedData']) {
+  const expected = {
+    code: 'ERR_INVALID_ARG_TYPE',
+    message: new RegExp(`"parameters\\.${key}"`),
+  };
+  for (const value of [123, null, true, {}, []]) {
+    const parameters = { ...defaults, [key]: value };
+    assert.throws(() => crypto.argon2('argon2id', parameters, () => {}), expected);
+    assert.throws(() => crypto.argon2Sync('argon2id', parameters), expected);
+  }
+}
+
 {
   const expected = { code: 'ERR_INVALID_ARG_TYPE' };
   assert.throws(() => crypto.argon2(), expected);