http: runtime deprecate instantiating without new

Promote DEP0195 from documentation-only to a runtime deprecation.
Calling node:http constructors without `new` now emits DEP0195 via
deprecateInstantiation. This covers Agent, Server, OutgoingMessage,
IncomingMessage, ServerResponse, and ClientRequest.

Update in-tree tests that called Server/Agent without `new` to use
the keyword, and add a dedicated DEP0195 coverage test.

Refs: #58518
Assisted-by: Grok
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>

Author: anonrig

doc/api/deprecations.md

@@ -4281,18 +4281,21 @@ The support for priority signaling has been removed following its deprecation in
 
 <!-- YAML
 changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/0
+    description: Runtime deprecation.
   - version:
       - v24.2.0
       - v22.17.0
     pr-url: https://github.com/nodejs/node/pull/58518
     description: Documentation-only deprecation.
 -->
 
-Type: Documentation-only
+Type: Runtime
 
 Instantiating classes without the `new` qualifier exported by the `node:http` module is deprecated.
 It is recommended to use the `new` qualifier instead. This applies to all http classes, such as
-`OutgoingMessage`, `IncomingMessage`, `ServerResponse` and `ClientRequest`.
+`OutgoingMessage`, `IncomingMessage`, `ServerResponse`, `ClientRequest`, `Server`, and `Agent`.
 
 An automated migration is available ([source](https://github.com/nodejs/userland-migrations/tree/main/recipes/http-classes-with-new)):
 

lib/_http_agent.js

@@ -45,6 +45,7 @@ const {
 const { AsyncResource } = require('async_hooks');
 const { async_id_symbol } = require('internal/async_hooks').symbols;
 const {
+  deprecateInstantiation,
   getLazy,
   kEmptyObject,
   once,
@@ -88,8 +89,9 @@ function freeSocketErrorListener(err) {
 }
 
 function Agent(options) {
-  if (!(this instanceof Agent))
-    return new Agent(options);
+  if (!(this instanceof Agent)) {
+    return deprecateInstantiation(Agent, 'DEP0195', options);
+  }
 
   EventEmitter.call(this);
 

lib/_http_client.js

@@ -38,6 +38,7 @@ const {
 const net = require('net');
 const assert = require('internal/assert');
 const {
+  deprecateInstantiation,
   kEmptyObject,
   once,
 } = require('internal/util');
@@ -190,6 +191,10 @@ function rewriteForProxiedHttp(req, reqOptions) {
 };
 
 function ClientRequest(input, options, cb) {
+  if (!(this instanceof ClientRequest)) {
+    return deprecateInstantiation(ClientRequest, 'DEP0195', input, options, cb);
+  }
+
   OutgoingMessage.call(this);
 
   if (typeof input === 'string') {

lib/_http_incoming.js

@@ -28,6 +28,9 @@ const {
 } = primordials;
 
 const { Readable, finished } = require('stream');
+const {
+  deprecateInstantiation,
+} = require('internal/util');
 
 const { AbortController } = require('internal/abort_controller');
 
@@ -51,6 +54,10 @@ function readStop(socket) {
 
 /* Abstract base class for ServerRequest and ClientResponse. */
 function IncomingMessage(socket) {
+  if (!(this instanceof IncomingMessage)) {
+    return deprecateInstantiation(IncomingMessage, 'DEP0195', socket);
+  }
+
   let streamOptions;
 
   if (socket) {

lib/_http_outgoing.js

@@ -71,7 +71,10 @@ const {
   hideStackFrames,
 } = require('internal/errors');
 const { validateString } = require('internal/validators');
-const { assignFunctionName } = require('internal/util');
+const {
+  assignFunctionName,
+  deprecateInstantiation,
+} = require('internal/util');
 const { isUint8Array } = require('internal/util/types');
 
 let debug = require('internal/util/debuglog').debuglog('http', (fn) => {
@@ -104,6 +107,10 @@ function isContentDispositionField(s) {
 }
 
 function OutgoingMessage(options) {
+  if (!(this instanceof OutgoingMessage)) {
+    return deprecateInstantiation(OutgoingMessage, 'DEP0195', options);
+  }
+
   Stream.call(this);
 
   // Queue that holds all currently pending data, until the response will be

lib/_http_server.js

@@ -86,6 +86,7 @@ const {
 } = require('internal/errors');
 const {
   assignFunctionName,
+  deprecateInstantiation,
   kEmptyObject,
   promisify,
 } = require('internal/util');
@@ -202,6 +203,10 @@ class HTTPServerAsyncResource {
 }
 
 function ServerResponse(req, options) {
+  if (!(this instanceof ServerResponse)) {
+    return deprecateInstantiation(ServerResponse, 'DEP0195', req, options);
+  }
+
   OutgoingMessage.call(this, options);
 
   if (req.method === 'HEAD') this._hasBody = false;
@@ -627,7 +632,9 @@ function httpServerPreClose(server) {
 }
 
 function Server(options, requestListener) {
-  if (!(this instanceof Server)) return new Server(options, requestListener);
+  if (!(this instanceof Server)) {
+    return deprecateInstantiation(Server, 'DEP0195', options, requestListener);
+  }
 
   if (typeof options === 'function') {
     requestListener = options;

test/parallel/test-cluster-primary-error.js

@@ -29,7 +29,7 @@ const totalWorkers = 2;
 // Cluster setup
 if (cluster.isWorker) {
   const http = require('http');
-  http.Server(() => {}).listen(0, '127.0.0.1');
+  new http.Server(() => {}).listen(0, '127.0.0.1');
 } else if (process.argv[2] === 'cluster') {
   // Send PID to testcase process
   let forkNum = 0;

test/parallel/test-cluster-primary-kill.js

@@ -28,7 +28,7 @@ if (cluster.isWorker) {
 
   // Keep the worker alive
   const http = require('http');
-  http.Server().listen(0, '127.0.0.1');
+  new http.Server().listen(0, '127.0.0.1');
 
 } else if (process.argv[2] === 'cluster') {
 

test/parallel/test-cluster-rr-domain-listen.js

@@ -32,7 +32,7 @@ if (cluster.isWorker) {
   d.run(() => {});
 
   const http = require('http');
-  http.Server(() => {}).listen(0, '127.0.0.1');
+  new http.Server(() => {}).listen(0, '127.0.0.1');
 
 } else if (cluster.isPrimary) {
 

test/parallel/test-cluster-worker-disconnect.js

@@ -26,7 +26,7 @@ const cluster = require('cluster');
 
 if (cluster.isWorker) {
   const http = require('http');
-  http.Server(() => {
+  new http.Server(() => {
 
   }).listen(0, '127.0.0.1');