Skip to content

Precise seek missing #189

@yaroslavlvov

Description

@yaroslavlvov

Sometimes there are cases where you need precise seeking which is called like this

player.seek(to: CMTime(seconds: 100, preferredTimescale: CMTimeScale(NSEC_PER_SEC)), toleranceBefore: .zero, toleranceAfter: .zero)

Screenshot 2020-12-23 at 14 30 44

currently seeking is not precise which is fine in most cases, however it would be nice to have precise seek

proposed solution extend current seek methods with another one with additional parameter isPrecise or isAccurate to not introduce breaking changes, example:

existing:
public func seek(position: Double) {
        context.seek(position: position, isPrecise: false)
}

new:
public func seek(position: Double, isPrecise: Bool) {
        context.seek(position: position, isPrecise: isPrecise)
}

would you approve this type of PR if I do? @raphrel

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions