Skip to content

Gate/CI parity: mirror clippy + cross-platform + feature-matrix lanes in the Pre-PR gate (gate-green PRs land red on consumer CI) #338

Description

@norrietaylor

Context. In the consumer pilot, the Pre-PR gate passed PRs that then failed consumer CI twice: build-macos + clippy on one merged PR, and a KVM e2e lane on another — both reaching already-open PRs. Commitlint also bit a human-reworded commit (tracked in #312). Cargo.lock --locked drift is already fixed (#318). The gate mirrors a subset of consumer lanes, so gate-green PRs still land red downstream.

Problem. Gate/consumer-CI parity is partial. #318 (lock drift) is done and #312 (commitlint) is open, but the cross-platform build (build-macos), lint (clippy), and feature-matrix lanes are not represented in the Pre-PR gate; the KVM e2e lane can't run in-gate at all yet its red still surfaces on open PRs as if actionable.

Fix.

  • Enumerate consumer CI lanes; mirror the deterministic ones in the Pre-PR gate: clippy, the cross-platform build matrix (incl. build-macos), feature-matrix builds, --locked.
  • Hardware-gated lanes (KVM e2e) that cannot run in-gate are documented as out-of-gate, so their failure is expected — and must not strand or needs-human an already-open PR.

Acceptance criteria:

  • Pre-PR gate runs clippy + cross-platform build matrix + feature-matrix + --locked.
  • Hardware-gated lanes are explicitly out-of-gate; their failures don't strand/needs-human an open PR.
  • A gate-green PR that later fails a deterministic consumer lane is treated as a gate bug (tracked), not noise.

Relates to: #312 (commitlint — open), #318 (lock drift — closed/done), #310 (misleading cancelled-run checks). Closes the residual gate/CI-parity gap from the retro's P2.9.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions