From b6aed61038f5f3b0fd8862b87f4529f35115213f Mon Sep 17 00:00:00 2001 From: Alex Ghiculescu Date: Wed, 12 Jul 2017 16:47:35 +1000 Subject: [PATCH 1/3] missing require --- lib/activehook.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/activehook.rb b/lib/activehook.rb index 2c13943..02cab54 100644 --- a/lib/activehook.rb +++ b/lib/activehook.rb @@ -1,4 +1,5 @@ require 'activehook/version' +require 'securerandom' module ActiveHook class << self From 54ee1af09d41b5ec715088cbd4ed6692078e14a1 Mon Sep 17 00:00:00 2001 From: Alex Ghiculescu Date: Wed, 12 Jul 2017 17:03:14 +1000 Subject: [PATCH 2/3] use httparty so we can send over https --- activehook.gemspec | 1 + lib/activehook.rb | 1 - lib/activehook/hook.rb | 2 ++ lib/activehook/server/send.rb | 8 +++++--- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/activehook.gemspec b/activehook.gemspec index a86f87a..221b165 100644 --- a/activehook.gemspec +++ b/activehook.gemspec @@ -21,6 +21,7 @@ Gem::Specification.new do |spec| spec.add_runtime_dependency "connection_pool", "~> 2.2" spec.add_runtime_dependency "puma", "~> 3.4" spec.add_runtime_dependency "rack" + spec.add_runtime_dependency "httparty" spec.add_development_dependency "bundler", "~> 1.12" spec.add_development_dependency "rake", "~> 10.0" spec.add_development_dependency "minitest", "~> 5.0" diff --git a/lib/activehook.rb b/lib/activehook.rb index 02cab54..2c13943 100644 --- a/lib/activehook.rb +++ b/lib/activehook.rb @@ -1,5 +1,4 @@ require 'activehook/version' -require 'securerandom' module ActiveHook class << self diff --git a/lib/activehook/hook.rb b/lib/activehook/hook.rb index ce9a54c..5f7781d 100644 --- a/lib/activehook/hook.rb +++ b/lib/activehook/hook.rb @@ -1,3 +1,5 @@ +require 'securerandom' + module ActiveHook class Hook attr_accessor :token, :uri, :id, :key, :retry_max, :retry_time, :created_at diff --git a/lib/activehook/server/send.rb b/lib/activehook/server/send.rb index 31909d7..cba7c26 100644 --- a/lib/activehook/server/send.rb +++ b/lib/activehook/server/send.rb @@ -1,3 +1,5 @@ +require 'httparty' + module ActiveHook REQUEST_HEADERS = { "Content-Type" => "application/json", @@ -30,12 +32,12 @@ def success? private def post_hook - http = Net::HTTP.new(uri.host, uri.port) measure_response_time do - @response = http.post(uri.path, @hook.final_payload, final_headers) + @response = HTTParty.post(uri.to_s, body: @hook.final_payload, headers: final_headers) end response_status(@response) - rescue + rescue e + puts(e) :error end From b248281e5125678ad6e04d4b2231757d166a4eaf Mon Sep 17 00:00:00 2001 From: Alex Ghiculescu Date: Sat, 12 Aug 2017 19:50:11 +1000 Subject: [PATCH 3/3] Update launcher.rb --- lib/activehook/server/launcher.rb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/activehook/server/launcher.rb b/lib/activehook/server/launcher.rb index 99cca82..c6fafca 100644 --- a/lib/activehook/server/launcher.rb +++ b/lib/activehook/server/launcher.rb @@ -1,3 +1,5 @@ +require 'optparse' + module ActiveHook module Server # Handles the start of the ActiveHook server via command line