Fixed a bug in connection class that was creating an invalid connection

rkhaotix · rkhaotix · commit 7ffb9b65e073 · 2025-10-23T09:05:05.000-03:00
string when other params were manually specificed (issue #2032)
diff --git a/libs/libconnector/src/connection.cpp b/libs/libconnector/src/connection.cpp
@@ -146,7 +146,7 @@ void Connection::generateConnectionString()
 		value.replace("'","\\'");
 
 		if(itr.first==ParamPassword && (value.contains(' ') || value.isEmpty()))
-			value=QString("'%1'").arg(value);
+			value = QString("'%1'").arg(value);
 
 		if(!value.isEmpty())
 		{
@@ -155,7 +155,7 @@ void Connection::generateConnectionString()
 			else if(itr.first != ParamOthers)
 				connection_str += param_str.arg(itr.first, value);
 			else
-				connection_str += value;
+				connection_str += value + " ";
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,7 @@ void Connection::generateConnectionString()`
`146`	`146`	`value.replace("'","\\'");`
`147`	`147`
`148`	`148`	`if(itr.first==ParamPassword && (value.contains(' ') \|\| value.isEmpty()))`
`149`		`- value=QString("'%1'").arg(value);`
	`149`	`+ value = QString("'%1'").arg(value);`
`150`	`150`
`151`	`151`	`if(!value.isEmpty())`
`152`	`152`	`{`
`@@ -155,7 +155,7 @@ void Connection::generateConnectionString()`
`155`	`155`	`else if(itr.first != ParamOthers)`
`156`	`156`	`connection_str += param_str.arg(itr.first, value);`
`157`	`157`	`else`
`158`		`- connection_str += value;`
	`158`	`+ connection_str += value + " ";`
`159`	`159`	`}`
`160`	`160`	`}`
`161`	`161`