Skip to content

📝 fix mypy instructions in contributing guide#595

Merged
jorenham merged 2 commits into
numpy:mainfrom
Jeitan:doc-typo-fix
Jul 31, 2025
Merged

📝 fix mypy instructions in contributing guide#595
jorenham merged 2 commits into
numpy:mainfrom
Jeitan:doc-typo-fix

Conversation

@Jeitan
Copy link
Copy Markdown
Contributor

@Jeitan Jeitan commented Jul 30, 2025

Fixes #594.

Rather than drop the instructions for the now-unnecessary script, I moved it down and labeled it a previous issue. Although ideally a fresh setup would for sure be using mypy 1.16+, so if you'd prefer to drop the entire instruction I can do that too.

@jorenham
Copy link
Copy Markdown
Member

Hmm, I suppose that since the script itself is gone, there's not really any value in keeping it. And since we're using git, it's pretty easy to look at previous versions, in case anyone is interested 🤷🏻

@Jeitan
Copy link
Copy Markdown
Contributor Author

Jeitan commented Jul 30, 2025

Okay, I'll just eliminate it then. Do you want me to remove the script, too? I left the actual script alone, but I can take out the whole shebang and all the references to it if it's truly not needed anymore.

@jorenham
Copy link
Copy Markdown
Member

Oh I somehow thought that the script was already gone. Sorry for the confusion.

Do you want me to remove the script, too?

Yea that would help!

@Jeitan
Copy link
Copy Markdown
Contributor Author

Jeitan commented Jul 30, 2025

I squashed the doc commits and kept the deletion commit separate, not sure if that makes a difference

@jorenham
Copy link
Copy Markdown
Member

I squashed the doc commits and kept the deletion commit separate, not sure if that makes a difference

Chique 👌🏻

@jorenham jorenham merged commit 8d961cc into numpy:main Jul 31, 2025
16 checks passed
@jorenham
Copy link
Copy Markdown
Member

Thanks Andrea! And welcome aboard :)

@Jeitan Jeitan deleted the doc-typo-fix branch July 31, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Super tiny typo in contributor's guide, maybe?

2 participants