bsdtar hangs during build with pkgsrc

[PapillonAll]

During build of bsdtar with pkgsrc, it hangs at:

grep -h '^DEFINE_TEST(' | LC_COLLATE=C sort > libarchive/test/list.h

[michaelforney]

I'm not able to reproduce this but just looking at that command-line, grep is reading from stdin, so makes sense that it'd hang.

Looking at the libarchive Makefile, I see

# The "list.h" file just lists all of the tests defined in all of the sources.
# Building it automatically provides a sanity-check on libarchive_test_SOURCES
# above.
libarchive/test/list.h: $(libarchive_test_SOURCES)
        $(MKDIR_P) libarchive/test
        grep -h '^DEFINE_TEST(' $^ | LC_COLLATE=C sort > $@

So maybe $(libarchive_test_SOURCES) is expanding to the empty string somehow? Not really sure how that could happen.

Is this during pkgsrc bootstrap, or a regular package build?

[PapillonAll]

@michaelforney This is during a regular package build. bsdtar is built as a dependency for other packages. Even when moving to the bsdtar directory and building it, the same error occurs.

[michaelforney]

I suggest you do some debugging to figure out why $^ is expanding to the empty string. Maybe you are using the wrong make? For pkgsrc you need to use bmake it built during the bootstrap.

[PapillonAll]

@michaelforney It turned out that /bin/sort is the culprit. It seems that it cannot handle locale environment variables before it. Instructing bmake to use /pkg/bin/gsort (from sysutils/coreutils) in /pkg/etc/mk.conf solves it. At least, that's the case for archives/bsdtar (which contains its own libarchive) and archives/libarchive.

[michaelforney]

Could you try to track down this further? The initial command you posted indicated that grep was passed no files, so it was waiting on stdin.

If it is a bug in sbase sort, we should try to fix it.

[PapillonAll]

@michaelforney

The initial command you posted indicated that grep was passed no files, so it was waiting on stdin.

It seems to be that the make command did not recognize $^, so it left it empty causing grep to expect input from stdin.

If it is a bug in sbase sort, we should try to fix it.

/bin/sort has no bug in this context.

Earlier you posted that you were not able to reproduce the issue, I don't know why I am getting this issue with libarchive? I am using a mk.conf produced from bootstraping bmake as documented in oasislinux wiki. And why adding TOOLS_PLATFORM.sort=/pkg/bin/gsort seems to finish the build, despite the issue seeming to be GNU Make v bmake (which is confusing bacause if it were the case, gmake would have been added as a requirement to bsdtar and libarchive)!

[michaelforney]

If it is a bug in sbase sort, we should try to fix it.

/bin/sort has no bug in this context.

Earlier you posted that you were not able to reproduce the issue, I don't know why I am getting this issue with libarchive? I am using a mk.conf produced from bootstraping bmake as documented in oasislinux wiki. And why adding TOOLS_PLATFORM.sort=/pkg/bin/gsort seems to finish the build, despite the issue seeming to be GNU Make v bmake (which is confusing bacause if it were the case, gmake would have been added as a requirement to bsdtar and libarchive)!

I'm also a bit confused. bmake doesn't support '$^', but as you say, libarchive doesn't use gmake. However, libarchive/test/test.h is already prebuilt in files/, so another question is why is it being built in the first place? Maybe something is off with your system time?

If I manually remove that file after unpacking, I still can't reproduce that exact failure, instead I get bmake[1]: bmake[1]: don't know how to make libarchive/test/test.h. Stop. I'm not sure why, since there is clearly a rule in the Makefile to build it. But it's also automake generated so who knows what's going on.

I think it is likely that sort is related, but I can't explain why, or why I don't see the same issue.

Edit: I was looking at the wrong file, but the same applies to libarchive/test/list.h. When I remove this, I do see the same bogus command (grep -h '^DEFINE_TEST(' | LC_COLLATE=C sort > libarchive/test/list.h), but it doesn't hang, just writes an empty file. Maybe pkgsrc runs bmake with /dev/null on stdin?

[angry-otter]

I think it is likely that sort is related, but I can't explain why, or why I don't see the same issue.`

I've tried to replicate with both /bin/sort and /pkg/bin/gsort after removing files/libarchive/test/list.h, work/libarchive/test/list.h is empty in both cases.

@PapillonAll I suggest investigating why files/libarchive/test/list.h is not used in your case