fix(pkg): allow locking relative path outside the workspace

Signed-off-by: Shun Ueda <me@shu.nu>

Author: shunueda

src/dune_pkg/opamUrl0.ml

@@ -33,7 +33,7 @@ let is_supported_archive t = Option.is_some (Archive_driver.choose_for_filename
 
 let classify url loc =
   match (url : t).backend with
-  | `rsync when is_local url -> `Path (Path.of_string url.path)
+  | `rsync when is_local url -> `Path (Path.of_string_allow_outside_workspace url.path)
   | `git -> `Git
   | `http when is_supported_archive url -> `Archive
   | `rsync | `http | `darcs | `hg ->

src/dune_rules/lock_dir.ml

@@ -308,7 +308,11 @@ let source_kind (source : Dune_pkg.Source.t) =
   let loc, url = source.url in
   if OpamUrl.is_local url && url.backend = `rsync
   then (
-    let path = Path.External.of_string url.path in
+    let path =
+      Path.of_string_allow_outside_workspace url.path
+      |> Path.to_absolute_filename
+      |> Path.External.of_string
+    in
     Fs_memo.path_kind (External path)
     >>| function
     | Error (ENOENT, _, _) ->

test/blackbox-tests/test-cases/pkg/pin-stanza/relative-path-outside-workspace.t

@@ -1,5 +1,4 @@
-Demonstrate that you can't use a relative path referring outside the workspace
-in the pin stanza:
+Demonstrate that relative paths outside the workspace work in pin stanzas:
 
 Make a package containing a library:
   $ mkdir foo
@@ -49,7 +48,7 @@ Lock and build the second package to demonstrate that everything works so far:
   $ dune exec ./bar.exe
   foo
 
-Now change the pin to use a relative path:
+Now change the pin to use a relative path (this should also work):
   $ cat > dune-project <<EOF
   > (lang dune 3.14)
   > (pin
@@ -60,10 +59,10 @@ Now change the pin to use a relative path:
   >  (depends foo))
   > EOF
 
-Solving the project now results in an error, though it's still possible to build the project:
+Solving the project works with relative paths outside the workspace:
   $ dune clean
   $ dune_pkg_lock_normalized
-  Error: path outside the workspace: ../foo from .
-  [1]
+  Solution for dune.lock:
+  - foo.dev
   $ dune exec ./bar.exe
   foo