Problem
Two optional features have test failures:
1. persist feature — 36 compilation errors
- Missing
use khive_hnsw::NodeId; in persist/tests.rs
khive_db::SqliteStore referenced but doesn't exist in current API
- Files:
src/persist/tests.rs:47, src/replay/engine_replay.rs:847, src/weights/engine_weights.rs:301
2. storage-adapters feature — 5 runtime panics
- Tests require
sqlite-vec extension loaded at runtime
StorageBackend::memory() doesn't load it
- Tests should be
#[ignore] with comment explaining runtime dependency
- File:
src/adapters/mod.rs:203
Impact
Default feature set (148 tests) is unaffected. These only matter when features are explicitly enabled.
Fix
- Add missing imports for
persist
- Either mock
VectorStore or #[ignore] tests that need sqlite-vec
Source
Critic review of PR #302.
Problem
Two optional features have test failures:
1.
persistfeature — 36 compilation errorsuse khive_hnsw::NodeId;inpersist/tests.rskhive_db::SqliteStorereferenced but doesn't exist in current APIsrc/persist/tests.rs:47,src/replay/engine_replay.rs:847,src/weights/engine_weights.rs:3012.
storage-adaptersfeature — 5 runtime panicssqlite-vecextension loaded at runtimeStorageBackend::memory()doesn't load it#[ignore]with comment explaining runtime dependencysrc/adapters/mod.rs:203Impact
Default feature set (148 tests) is unaffected. These only matter when features are explicitly enabled.
Fix
persistVectorStoreor#[ignore]tests that need sqlite-vecSource
Critic review of PR #302.