Lit tests for target_compile_features and cuda_add_cufft_to_target CMake

macros

Author: TejaX-Alaghari

clang/test/dpct/cmake_migation/case_011/case_011_target_compile_features.cpp

@@ -0,0 +1,10 @@
+// RUN: rm -rf %T && mkdir -p %T
+// RUN: cd %T
+// RUN: cp %S/input.cmake ./input.cmake
+// RUN: dpct -in-root ./ -out-root out  ./input.cmake --rule-file=%S/../../../../tools/dpct/DpctOptRules/cmake_script_migration_rule.yaml --migrate-cmake-script-only --cuda-include-path="%cuda-path/include"
+// RUN: echo "begin" > %T/diff.txt
+// RUN: diff --strip-trailing-cr %S/expected.txt %T/out/input.cmake >> %T/diff.txt
+// RUN: echo "end" >> %T/diff.txt
+
+// CHECK: begin
+// CHECK-NEXT: end

clang/test/dpct/cmake_migation/case_011/expected.txt

@@ -0,0 +1,25 @@
+add_library(culib)
+add_executable(cuexe)
+target_compile_features(culib PUBLIC c_std_11)
+target_compile_features(culib PRIVATE cxx_std_17)
+target_compile_features(culib 
+  PUBLIC 
+  cxx_std_17)
+
+target_compile_features(culib PUBLIC c_std_17)
+target_compile_features(culib PRIVATE cxx_std_17)
+target_compile_features(culib 
+  PUBLIC 
+  cxx_std_17)
+
+target_compile_features(cuexe PUBLIC c_std_20)
+target_compile_features(cuexe PRIVATE cxx_std_17)
+target_compile_features(cuexe 
+  PUBLIC 
+  cxx_std_17)
+
+target_compile_features(cuexe PUBLIC c_std_23)
+target_compile_features(cuexe PRIVATE cxx_std_17)
+target_compile_features(cuexe 
+  PUBLIC 
+  cxx_std_17)

clang/test/dpct/cmake_migation/case_011/input.cmake

@@ -0,0 +1,25 @@
+add_library(culib)
+add_executable(cuexe)
+TARGET_COMPILE_FEATURES(culib PUBLIC c_std_11)
+target_compile_features(culib PRIVATE cxx_std_11)
+target_compile_features(culib 
+  PUBLIC 
+  cuda_std_11)
+
+TARGET_COMPILE_FEATURES(culib PUBLIC c_std_17)
+target_compile_features(culib PRIVATE cxx_std_17)
+target_compile_features(culib 
+  PUBLIC 
+  cuda_std_17)
+
+TARGET_COMPILE_FEATURES(cuexe PUBLIC c_std_20)
+target_compile_features(cuexe PRIVATE cxx_std_20)
+target_compile_features(cuexe 
+  PUBLIC 
+  cuda_std_20)
+
+TARGET_COMPILE_FEATURES(cuexe PUBLIC c_std_23)
+target_compile_features(cuexe PRIVATE cxx_std_23)
+target_compile_features(cuexe 
+  PUBLIC 
+  cuda_std_23)

clang/test/dpct/cmake_migation/case_012/case_012_cuda_add_cufft_to_target.cpp

@@ -0,0 +1,10 @@
+// RUN: rm -rf %T && mkdir -p %T
+// RUN: cd %T
+// RUN: cp %S/input.cmake ./input.cmake
+// RUN: dpct -in-root ./ -out-root out  ./input.cmake --rule-file=%S/../../../../tools/dpct/DpctOptRules/cmake_script_migration_rule.yaml --migrate-cmake-script-only --cuda-include-path="%cuda-path/include"
+// RUN: echo "begin" > %T/diff.txt
+// RUN: diff --strip-trailing-cr %S/expected.txt %T/out/input.cmake >> %T/diff.txt
+// RUN: echo "end" >> %T/diff.txt
+
+// CHECK: begin
+// CHECK-NEXT: end

clang/test/dpct/cmake_migation/case_012/expected.txt

@@ -0,0 +1,18 @@
+project(foo-bar LANGUAGES CXX )
+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsycl")
+find_program(dpct_bin_path NAMES dpct PATHS)
+get_filename_component(bin_path_of_dpct ${dpct_bin_path} DIRECTORY)
+set(dpct_cmake_file_path "${bin_path_of_dpct}/../cmake/dpct.cmake")
+include(${dpct_cmake_file_path})
+
+add_library(culib)
+add_executable(cuexe)
+dpct_add_mkl_to_target(culib)
+dpct_add_mkl_to_target(
+  culib
+)
+
+dpct_add_mkl_to_target(cuexe)
+dpct_add_mkl_to_target(
+  cuexe
+)

clang/test/dpct/cmake_migation/case_012/input.cmake

@@ -0,0 +1,13 @@
+project(foo-bar LANGUAGES CXX CUDA)
+
+add_library(culib)
+add_executable(cuexe)
+CUDA_ADD_CUFFT_TO_TARGET(culib)
+cuda_add_cufft_to_target(
+  culib
+)
+
+CUDA_ADD_CUFFT_TO_TARGET(cuexe)
+cuda_add_cufft_to_target(
+  cuexe
+)

clang/tools/dpct/DpctOptRules/cmake_script_migration_rule.yaml

@@ -138,3 +138,41 @@
       In: ${arg}.cu
       Out: ${arg}.dp.cpp
 
+- Rule: rule_cuda_add_cufft_to_target
+  Kind: CMakeRule
+  Priority: Fallback
+  CmakeSyntax: cuda_add_cufft_to_target
+  MatchMode: Partial
+  In: cuda_add_cufft_to_target(${value})
+  Out: dpct_add_mkl_to_target(${value})
+
+# Current Yaml based rule hard-code to map "cxx_std_xx" to "cxx_std_17"
+# A more flexible mapping logic should be implemented in implicit rules
+- Rule: rule_cxx_target_compile_features
+  Kind: CMakeRule
+  Priority: Fallback
+  CmakeSyntax: cxx_target_compile_features
+  MatchMode: Partial
+  In: target_compile_features(${value})
+  Out: target_compile_features(${value})
+  Subrules:
+    value:
+      In: cxx_std_${ver}
+      Out: cxx_std_17
+      RuleId: "adjust cxx_ver"
+
+# Current Yaml based rule hard-code to map "cuda_std_xx" to "cxx_std_17"
+# A more flexible mapping logic should be implemented in implicit rules
+- Rule: rule_cuda_target_compile_features
+  Kind: CMakeRule
+  Priority: Fallback
+  CmakeSyntax: cuda_target_compile_features
+  MatchMode: Partial
+  In: target_compile_features(${value})
+  Out: target_compile_features(${value})
+  Subrules:
+    value:
+      In: cuda_std_${ver}
+      Out: cxx_std_17
+      RuleId: "adjust cuda_ver"
+

clang/tools/dpct/cmake/dpct.cmake

@@ -74,3 +74,14 @@ endmacro()
 macro(DPCT_COMPILE_SYCL_CODE generated_files)
   DPCT_COMPILE_SYCL_CODE_IMP(sycl_device ${generated_files} ${ARGN})
 endmacro()
+
+# Link MKL library to target
+macro(DPCT_ADD_MKL_TO_TARGET target)
+    if(WIN32)
+        target_link_libraries(${target} mkl_sycl_dll.lib mkl_intel_ilp64_dll.lib mkl_tbb_thread_dll.lib mkl_core_dll.lib OpenCL.lib)
+    elseif(UNIX AND NOT APPLE)
+        target_link_libraries(${target} -L${MKLROOT}/lib/intel64 -lmkl_intel_ilp64 -lmkl_tbb_thread -lmkl_core -lOpenCL -lmkl_sycl -lpthread -ldl)
+    else()
+        message(FATAL_ERROR "Unsupported platform")
+    endif()
+endfunction()