Add function to find if hostboot has transitioned control to host#63
Open
deepakala-k wants to merge 1 commit into
Open
Add function to find if hostboot has transitioned control to host#63deepakala-k wants to merge 1 commit into
deepakala-k wants to merge 1 commit into
Conversation
deepakala-k
force-pushed
the
transitioned_to_phyp
branch
from
614d607 to
b9935fd
Compare
dhruvibm
reviewed
Sep 27, 2023
Swarnendu-R-C
suggested changes
Sep 27, 2023
deepakala-k
force-pushed
the
transitioned_to_phyp
branch
from
b9935fd to
ad962e5
Compare
deepakala-k
changed the title
Contributor
Swarnendu-R-C
left a comment
Swarnendu-R-C
left a comment
There was a problem hiding this comment.
A query and a suggestion
Swarnendu-R-C
approved these changes
Oct 4, 2023
deepakala-k
force-pushed
the
transitioned_to_phyp
branch
2 times, most recently
from
657ad2c to
3ff22f0
Compare
Utilizing the xyz.openbmc_project.State.Host interface to ascertain the host's operational status becomes less accurate when transitioning from hostboot to host. During the period when host is initializing and not yet fully operational, the host state is erroneously presumed to be in hostboot. In situations where host encounters initial boot difficulties, and the watchdog time is hit as the boot up process has not completed within a specific time, this watchdog misinterprets the issue as a problem with hostboot. To address this, there exists a core scratch register that undergoes an update by hostboot just before transferring control to host. We have devised a method that leverages this register to determine whether the transition to host has already occurred. By implementing this functionality we can determine which booting subsystem is failed or stopped responding, and the dump can be extracted from the right subsystem. Signed-off-by: Deepa Karthikeyan <deepakala.karthikeyan@ibm.com>
deepakala-k
force-pushed
the
transitioned_to_phyp
branch
from
3ff22f0 to
eb51677
Compare
Swarnendu-R-C
approved these changes
Oct 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Utilizing the xyz.openbmc_project.State.Host interface to ascertain the host's operational status becomes less accurate when transitioning from hostboot to PHYP. During the period when PHYP is initializing and not yet fully operational, the host state is erroneously presumed to be in hostboot. In situations where PHYP encounters initial boot difficulties and activates a watchdog timer, this watchdog misinterprets the issue as a problem with hostboot.
To address this, there exists a core scratch register that undergoes an update by hostboot just before transferring control to PHYP. We have devised a method that leverages this register to determine whether the transition to PHYP has already occurred.
By implementing this functionality, we can accurately determine whether control has transitioned to PHYP, allowing for more precise reporting of the host's state.