From 63480e8137d189a22b907d7cfc9c762353717858 Mon Sep 17 00:00:00 2001 From: Trask Stalnaker Date: Tue, 19 Aug 2025 11:12:48 -0700 Subject: [PATCH] Add slightly more strict test verifiction --- .../testing/internal/AbstractGrpcTelemetryExporterTest.java | 2 ++ .../testing/internal/AbstractHttpTelemetryExporterTest.java | 2 ++ .../test/java/io/opentelemetry/sdk/logs/LogLimitsTest.java | 5 ++++- .../sdk/metrics/internal/view/ViewRegistryTest.java | 2 ++ .../io/opentelemetry/sdk/trace/config/SpanLimitsTest.java | 5 ++++- 5 files changed, 14 insertions(+), 2 deletions(-) diff --git a/exporters/otlp/testing-internal/src/main/java/io/opentelemetry/exporter/otlp/testing/internal/AbstractGrpcTelemetryExporterTest.java b/exporters/otlp/testing-internal/src/main/java/io/opentelemetry/exporter/otlp/testing/internal/AbstractGrpcTelemetryExporterTest.java index 4070b565bf7..908dd454631 100644 --- a/exporters/otlp/testing-internal/src/main/java/io/opentelemetry/exporter/otlp/testing/internal/AbstractGrpcTelemetryExporterTest.java +++ b/exporters/otlp/testing-internal/src/main/java/io/opentelemetry/exporter/otlp/testing/internal/AbstractGrpcTelemetryExporterTest.java @@ -988,6 +988,7 @@ void toBuilderEquality() assertThat(copy.unwrap()) .extracting("builder") .usingRecursiveComparison() + .withStrictTypeChecking() .ignoringFields("tlsConfigHelper") .isEqualTo(builderField.get(unwrapped)); } finally { @@ -1000,6 +1001,7 @@ void toBuilderEquality() assertThat(copy.unwrap()) .extracting("builder") .usingRecursiveComparison() + .withStrictTypeChecking() .ignoringFields("tlsConfigHelper") .isNotEqualTo(builderField.get(unwrapped)); } finally { diff --git a/exporters/otlp/testing-internal/src/main/java/io/opentelemetry/exporter/otlp/testing/internal/AbstractHttpTelemetryExporterTest.java b/exporters/otlp/testing-internal/src/main/java/io/opentelemetry/exporter/otlp/testing/internal/AbstractHttpTelemetryExporterTest.java index e73fb3683f8..dd3c096d113 100644 --- a/exporters/otlp/testing-internal/src/main/java/io/opentelemetry/exporter/otlp/testing/internal/AbstractHttpTelemetryExporterTest.java +++ b/exporters/otlp/testing-internal/src/main/java/io/opentelemetry/exporter/otlp/testing/internal/AbstractHttpTelemetryExporterTest.java @@ -850,6 +850,7 @@ void toBuilderEquality() assertThat(copy.unwrap()) .extracting("builder") .usingRecursiveComparison() + .withStrictTypeChecking() .ignoringFields("tlsConfigHelper") .isEqualTo(builderField.get(unwrapped)); } finally { @@ -862,6 +863,7 @@ void toBuilderEquality() assertThat(copy.unwrap()) .extracting("builder") .usingRecursiveComparison() + .withStrictTypeChecking() .ignoringFields("tlsConfigHelper") .isNotEqualTo(builderField.get(unwrapped)); } finally { diff --git a/sdk/logs/src/test/java/io/opentelemetry/sdk/logs/LogLimitsTest.java b/sdk/logs/src/test/java/io/opentelemetry/sdk/logs/LogLimitsTest.java index 4acb0666bab..06b128eeb5b 100644 --- a/sdk/logs/src/test/java/io/opentelemetry/sdk/logs/LogLimitsTest.java +++ b/sdk/logs/src/test/java/io/opentelemetry/sdk/logs/LogLimitsTest.java @@ -29,7 +29,10 @@ void updateLogLimits_All() { // Preserves values LogLimits logLimitsDupe = logLimits.toBuilder().build(); // Use reflective comparison to catch when new fields are added. - assertThat(logLimitsDupe).usingRecursiveComparison().isEqualTo(logLimits); + assertThat(logLimitsDupe) + .usingRecursiveComparison() + .withStrictTypeChecking() + .isEqualTo(logLimits); } @Test diff --git a/sdk/metrics/src/test/java/io/opentelemetry/sdk/metrics/internal/view/ViewRegistryTest.java b/sdk/metrics/src/test/java/io/opentelemetry/sdk/metrics/internal/view/ViewRegistryTest.java index ee1a61d1d35..72361b36ef1 100644 --- a/sdk/metrics/src/test/java/io/opentelemetry/sdk/metrics/internal/view/ViewRegistryTest.java +++ b/sdk/metrics/src/test/java/io/opentelemetry/sdk/metrics/internal/view/ViewRegistryTest.java @@ -488,6 +488,7 @@ void findViews_ApplyAdvice() { assertThat(view) .as("is the same as the default view, except the attributes processor") .usingRecursiveComparison() + .withStrictTypeChecking() .ignoringFields("viewAttributesProcessor") .isEqualTo(DEFAULT_REGISTERED_VIEW); assertThat(view) @@ -520,6 +521,7 @@ void findViews_ApplyAdvice() { assertThat(view) .as("is the same as the default view, except the attributes processor") .usingRecursiveComparison() + .withStrictTypeChecking() .ignoringFields("viewAttributesProcessor") .isEqualTo(DEFAULT_REGISTERED_VIEW); assertThat(view) diff --git a/sdk/trace/src/test/java/io/opentelemetry/sdk/trace/config/SpanLimitsTest.java b/sdk/trace/src/test/java/io/opentelemetry/sdk/trace/config/SpanLimitsTest.java index 73d9ac2e842..309bdf398c1 100644 --- a/sdk/trace/src/test/java/io/opentelemetry/sdk/trace/config/SpanLimitsTest.java +++ b/sdk/trace/src/test/java/io/opentelemetry/sdk/trace/config/SpanLimitsTest.java @@ -42,7 +42,10 @@ void updateSpanLimits_All() { // Preserves values SpanLimits spanLimitsDupe = spanLimits.toBuilder().build(); // Use reflective comparison to catch when new fields are added. - assertThat(spanLimitsDupe).usingRecursiveComparison().isEqualTo(spanLimits); + assertThat(spanLimitsDupe) + .usingRecursiveComparison() + .withStrictTypeChecking() + .isEqualTo(spanLimits); } @Test