From 9c7131249f01b2ba678dcb18035768447cb8bb32 Mon Sep 17 00:00:00 2001 From: Anuraag Agrawal Date: Fri, 23 Jan 2026 14:28:48 +0900 Subject: [PATCH 1/3] pyramid: use test_base to fetch metrics for assertions --- .../tests/test_automatic.py | 34 ++++++++----------- 1 file changed, 14 insertions(+), 20 deletions(-) diff --git a/instrumentation/opentelemetry-instrumentation-pyramid/tests/test_automatic.py b/instrumentation/opentelemetry-instrumentation-pyramid/tests/test_automatic.py index b40cf3355a..6425c4827a 100644 --- a/instrumentation/opentelemetry-instrumentation-pyramid/tests/test_automatic.py +++ b/instrumentation/opentelemetry-instrumentation-pyramid/tests/test_automatic.py @@ -180,28 +180,22 @@ def test_pyramid_metric(self): self.client.get("/hello/756") self.client.get("/hello/756") self.client.get("/hello/756") - metrics_list = self.memory_metrics_reader.get_metrics_data() + metrics = self.get_sorted_metrics() number_data_point_seen = False histogram_data_point_seen = False - self.assertTrue(len(metrics_list.resource_metrics) == 1) - for resource_metric in metrics_list.resource_metrics: - self.assertTrue(len(resource_metric.scope_metrics) == 1) - for scope_metric in resource_metric.scope_metrics: - self.assertTrue(len(scope_metric.metrics) == 2) - for metric in scope_metric.metrics: - self.assertIn(metric.name, _expected_metric_names) - data_points = list(metric.data.data_points) - self.assertEqual(len(data_points), 1) - for point in data_points: - if isinstance(point, HistogramDataPoint): - self.assertEqual(point.count, 3) - histogram_data_point_seen = True - if isinstance(point, NumberDataPoint): - number_data_point_seen = True - for attr in point.attributes: - self.assertIn( - attr, _recommended_attrs[metric.name] - ) + self.assertTrue(len(metrics) == 1) + for metric in metrics: + self.assertIn(metric.name, _expected_metric_names) + data_points = list(metric.data.data_points) + self.assertEqual(len(data_points), 1) + for point in data_points: + if isinstance(point, HistogramDataPoint): + self.assertEqual(point.count, 3) + histogram_data_point_seen = True + if isinstance(point, NumberDataPoint): + number_data_point_seen = True + for attr in point.attributes: + self.assertIn(attr, _recommended_attrs[metric.name]) self.assertTrue(number_data_point_seen and histogram_data_point_seen) def test_basic_metric_success(self): From 559ff35e5d63a26758ecf3f7b6ccb26cde4f6960 Mon Sep 17 00:00:00 2001 From: Anuraag Agrawal Date: Fri, 23 Jan 2026 15:29:37 +0900 Subject: [PATCH 2/3] Fix assertion --- .../tests/test_automatic.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/instrumentation/opentelemetry-instrumentation-pyramid/tests/test_automatic.py b/instrumentation/opentelemetry-instrumentation-pyramid/tests/test_automatic.py index 6425c4827a..fa0f6f8b20 100644 --- a/instrumentation/opentelemetry-instrumentation-pyramid/tests/test_automatic.py +++ b/instrumentation/opentelemetry-instrumentation-pyramid/tests/test_automatic.py @@ -183,7 +183,7 @@ def test_pyramid_metric(self): metrics = self.get_sorted_metrics() number_data_point_seen = False histogram_data_point_seen = False - self.assertTrue(len(metrics) == 1) + self.assertTrue(len(metrics) > 0) for metric in metrics: self.assertIn(metric.name, _expected_metric_names) data_points = list(metric.data.data_points) From a5b597bf6abc6daec1d5f976d4fb49ea5601b161 Mon Sep 17 00:00:00 2001 From: Riccardo Magliocchetti Date: Fri, 23 Jan 2026 16:02:21 +0100 Subject: [PATCH 3/3] Update instrumentation/opentelemetry-instrumentation-pyramid/tests/test_automatic.py --- .../tests/test_automatic.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/instrumentation/opentelemetry-instrumentation-pyramid/tests/test_automatic.py b/instrumentation/opentelemetry-instrumentation-pyramid/tests/test_automatic.py index fa0f6f8b20..4123c16f9f 100644 --- a/instrumentation/opentelemetry-instrumentation-pyramid/tests/test_automatic.py +++ b/instrumentation/opentelemetry-instrumentation-pyramid/tests/test_automatic.py @@ -183,7 +183,7 @@ def test_pyramid_metric(self): metrics = self.get_sorted_metrics() number_data_point_seen = False histogram_data_point_seen = False - self.assertTrue(len(metrics) > 0) + self.assertEqual(len(metrics), 2) for metric in metrics: self.assertIn(metric.name, _expected_metric_names) data_points = list(metric.data.data_points)