From 169b98b218e6267db6c1023aef328802bb6486af Mon Sep 17 00:00:00 2001
From: Pascal ST-LAURENT <pstlaurent@gmail.com>
Date: Tue, 26 May 2026 08:29:34 -0400
Subject: [PATCH] fix: allow OAuth popups to open inside Electron webview

---
 src/main/index.ts | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/src/main/index.ts b/src/main/index.ts
index ca8e43792..fb2fb0431 100644
--- a/src/main/index.ts
+++ b/src/main/index.ts
@@ -1313,7 +1313,20 @@ if (!gotTheLock) {
 
       if (contents.getType() === 'webview') {
         // ── Popups (target="_blank" links) → open in default browser ──
+        // OAuth popup windows (Google, Microsoft, GitHub, etc.) must open
+        // inside Electron so the opener page can receive the postMessage
+        // callback. All other popups go to the system browser.
+        const OAUTH_HOSTS = [
+          'accounts.google.com',
+          'login.microsoftonline.com',
+          'github.com/login',
+          'github.com/oauth',
+        ]
         contents.setWindowOpenHandler(({ url }) => {
+          const isOAuth = OAUTH_HOSTS.some((h) => url.includes(h))
+          if (isOAuth) {
+            return { action: 'allow' }
+          }
           openUrl(url)
           return { action: 'deny' }
         })