From 533c8be6e72c4fc547d114d06e22b0443ca5c075 Mon Sep 17 00:00:00 2001 From: Sebastian Serth Date: Thu, 26 Jun 2025 09:43:46 +0200 Subject: [PATCH] Migrate .js.erb files to .js --- .../javascripts/{labels.coffee.erb => labels.coffee} | 9 ++++++--- app/views/labels/index.html.slim | 1 + app/views/tasks/_form.html.slim | 1 + 3 files changed, 8 insertions(+), 3 deletions(-) rename app/assets/javascripts/{labels.coffee.erb => labels.coffee} (91%) diff --git a/app/assets/javascripts/labels.coffee.erb b/app/assets/javascripts/labels.coffee similarity index 91% rename from app/assets/javascripts/labels.coffee.erb rename to app/assets/javascripts/labels.coffee index 311c0790f..e5edb9e00 100644 --- a/app/assets/javascripts/labels.coffee.erb +++ b/app/assets/javascripts/labels.coffee @@ -1,9 +1,12 @@ -max_label_length = <%= Label::MAX_LENGTH %> +get_max_label_length = -> + if (this._max_label_length == undefined) + this._max_label_length = $('#label-settings').data('max-length'); + return this._max_label_length; verify_label_name = (label_name) -> if label_name == '' return I18n.t('labels.javascripts.cannot_be_empty'); - if label_name.length > max_label_length + if label_name.length > get_max_label_length() return I18n.t('labels.javascripts.too_long'); return I18n.t('labels.javascripts.ok'); @@ -20,7 +23,7 @@ ready = -> tags: true multiple: true maximumSelectionLength: 10 - maximumInputLength: max_label_length + maximumInputLength: get_max_label_length() closeOnSelect: false tokenSeparators: [','] diff --git a/app/views/labels/index.html.slim b/app/views/labels/index.html.slim index 3f22bd320..0a10ed090 100644 --- a/app/views/labels/index.html.slim +++ b/app/views/labels/index.html.slim @@ -17,6 +17,7 @@ .col-md-5 div .input-group + #label-settings.d-none data-max-length=Label::MAX_LENGTH = button_tag t('.merge'), type: 'button', id: 'merge-labels-button', disabled: true, class: 'btn btn-primary' input.form-control#merge-labels-input type='text' placeholder=t('.new_name') diff --git a/app/views/tasks/_form.html.slim b/app/views/tasks/_form.html.slim index 7ca978b45..e1caa783f 100644 --- a/app/views/tasks/_form.html.slim +++ b/app/views/tasks/_form.html.slim @@ -82,6 +82,7 @@ = group.name .field-element + #label-settings.d-none data-max-length=Label::MAX_LENGTH = f.label :labels, Label.model_name.human(count: :many), class: 'form-label' = f.select :label_names, options_for_select(@task.labels.map {|l| [l.name, l.name, {label_color: l.color, label_font_color: l.font_color}] }, @task.labels.map(&:name)), {}, {class: 'labels-select2-tag form-control', multiple: 'multiple'}