From 3599da6a7a1c019b33e15c31e76d08f1c15a12a6 Mon Sep 17 00:00:00 2001
From: Armin Kirchner <post.armin@gmail.com>
Date: Fri, 13 Jun 2025 22:30:49 +0200
Subject: [PATCH 1/4] chore: Remove erb templete requirments from editor

Configurations can be suppied to JavaScript with data attributes.
This simplifies the JavaScript migration to Webpack.
---
 app/assets/javascripts/editor/editor.js.erb              | 2 +-
 .../{participantsupport.js.erb => participantsupport.js} | 4 ++--
 app/helpers/application_helper.rb                        | 9 +++++++++
 app/views/layouts/application.html.slim                  | 2 +-
 4 files changed, 13 insertions(+), 4 deletions(-)
 rename app/assets/javascripts/editor/{participantsupport.js.erb => participantsupport.js} (97%)

diff --git a/app/assets/javascripts/editor/editor.js.erb b/app/assets/javascripts/editor/editor.js.erb
index e5f65eea8..b49f63457 100644
--- a/app/assets/javascripts/editor/editor.js.erb
+++ b/app/assets/javascripts/editor/editor.js.erb
@@ -33,7 +33,7 @@ var CodeOceanEditor = {
 
     lastCopyText: null,
 
-    sendEvents: <%= config_file.read['codeocean_events'] ? config_file.read['codeocean_events']['enabled'] : false %>,
+    sendEvents: document.documentElement.dataset.eventsEnabled === 'true',
     eventURL: Routes.events_path(),
     fileTypeURL: Routes.file_types_path(),
 
diff --git a/app/assets/javascripts/editor/participantsupport.js.erb b/app/assets/javascripts/editor/participantsupport.js
similarity index 97%
rename from app/assets/javascripts/editor/participantsupport.js.erb
rename to app/assets/javascripts/editor/participantsupport.js
index a2d6a3f2d..9cb8c3e3c 100644
--- a/app/assets/javascripts/editor/participantsupport.js.erb
+++ b/app/assets/javascripts/editor/participantsupport.js
@@ -1,5 +1,5 @@
 CodeOceanEditorFlowr = {
-  isFlowrEnabled: <%= CodeOcean::Config.new(:code_ocean).read[:flowr][:enabled] %>,
+  isFlowrEnabled: document.documentElement.dataset.flowrEnabled === 'true',
   flowrResultHtml:
     '<div class="card mb-2">' +
       '<div id="{{headingId}}" role="tab" class="card-header">' +
@@ -29,7 +29,7 @@ CodeOceanEditorFlowr = {
       var stackoverflowRequests = _.map(insights, function (insight) {
         var queryParams = {
           accepted: true,
-          pagesize: <%= CodeOcean::Config.new(:code_ocean).read[:flowr][:answers_per_query] or 3 %>,
+          pagesize: Number(document.documentElement.dataset.flowrAnswersPerQuery),
           order: 'desc',
           sort: 'relevance',
           site: 'stackoverflow',
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
index 0512a5b15..d9af6455a 100644
--- a/app/helpers/application_helper.rb
+++ b/app/helpers/application_helper.rb
@@ -91,4 +91,13 @@ def value_column(value)
   def yes
     tag.i(nil, class: 'fa-solid fa-check')
   end
+
+  def html_data_attributes
+    {
+      'data-default-locale' => I18n.default_locale,
+      'data-events-enabled' => CodeOcean::Config.new(:code_ocean).read.dig('codeocean_events', 'enabled'),
+      'data-flowr-enabled' => CodeOcean::Config.new(:code_ocean).read.dig(:flowr, :enabled),
+      'data-flowr-answers-per-query' => CodeOcean::Config.new(:code_ocean).read[:flowranswers_per_query] || 3,
+    }
+  end
 end
diff --git a/app/views/layouts/application.html.slim b/app/views/layouts/application.html.slim
index 94e33a523..8bf1c245c 100644
--- a/app/views/layouts/application.html.slim
+++ b/app/views/layouts/application.html.slim
@@ -1,5 +1,5 @@
 doctype html
-html lang=I18n.locale data-default-locale=I18n.default_locale
+html lang=I18n.locale *html_data_attributes
   head
     meta charset='utf-8'
     meta name='viewport' content='width=device-width, initial-scale=1'

From 2daae12232c9f87a1dd569a6d146057f98db4aee Mon Sep 17 00:00:00 2001
From: Armin Kirchner <post.armin@gmail.com>
Date: Mon, 16 Jun 2025 14:12:22 +0200
Subject: [PATCH 2/4] Add memorisation

---
 app/helpers/application_helper.rb | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
index d9af6455a..a4ad9bb43 100644
--- a/app/helpers/application_helper.rb
+++ b/app/helpers/application_helper.rb
@@ -93,11 +93,13 @@ def yes
   end
 
   def html_data_attributes
+    config = CodeOcean::Config.new(:code_ocean).read
+
     {
       'data-default-locale' => I18n.default_locale,
-      'data-events-enabled' => CodeOcean::Config.new(:code_ocean).read.dig('codeocean_events', 'enabled'),
-      'data-flowr-enabled' => CodeOcean::Config.new(:code_ocean).read.dig(:flowr, :enabled),
-      'data-flowr-answers-per-query' => CodeOcean::Config.new(:code_ocean).read[:flowranswers_per_query] || 3,
+      'data-events-enabled' => config.dig('codeocean_events', 'enabled'),
+      'data-flowr-enabled' => config.dig(:flowr, :enabled),
+      'data-flowr-answers-per-query' => config.fetch(:flowranswers_per_query, 3),
     }
   end
 end

From 8dc7663e9abfd5f95590d89ba9c7d52d3d6e8117 Mon Sep 17 00:00:00 2001
From: Armin Kirchner <post.armin@gmail.com>
Date: Mon, 16 Jun 2025 14:16:16 +0200
Subject: [PATCH 3/4] remove last editor js.erb file.

---
 app/assets/javascripts/editor/{editor.js.erb => editor.js} | 6 ------
 1 file changed, 6 deletions(-)
 rename app/assets/javascripts/editor/{editor.js.erb => editor.js} (99%)

diff --git a/app/assets/javascripts/editor/editor.js.erb b/app/assets/javascripts/editor/editor.js
similarity index 99%
rename from app/assets/javascripts/editor/editor.js.erb
rename to app/assets/javascripts/editor/editor.js
index b49f63457..a8e305bd1 100644
--- a/app/assets/javascripts/editor/editor.js.erb
+++ b/app/assets/javascripts/editor/editor.js
@@ -1,9 +1,3 @@
-// Note: Directives are only processed if they come before any application code.
-// Once you have a line that does not include a comment or whitespace then Sprockets will stop looking for directives.
-// If you use a directive outside of the "header" of the document it will not do anything, and won't raise any errors.
-// <% config_file = CodeOcean::Config.new(:code_ocean, erb: false) %>
-//= depend_on <%= config_file.path.basename %>
-
 var CodeOceanEditor = {
     THEME: window.getCurrentTheme() === 'dark' ? 'ace/theme/tomorrow_night' : 'ace/theme/tomorrow',
 

From f14cdff961e81ff79dc8342d6affa47c03527742 Mon Sep 17 00:00:00 2001
From: Armin Kirchner <post.armin@gmail.com>
Date: Mon, 16 Jun 2025 16:24:30 +0200
Subject: [PATCH 4/4] Fix parameter typo

---
 app/helpers/application_helper.rb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
index a4ad9bb43..645f7a00a 100644
--- a/app/helpers/application_helper.rb
+++ b/app/helpers/application_helper.rb
@@ -97,9 +97,9 @@ def html_data_attributes
 
     {
       'data-default-locale' => I18n.default_locale,
-      'data-events-enabled' => config.dig('codeocean_events', 'enabled'),
+      'data-events-enabled' => config.dig(:codeocean_events, :enabled),
       'data-flowr-enabled' => config.dig(:flowr, :enabled),
-      'data-flowr-answers-per-query' => config.fetch(:flowranswers_per_query, 3),
+      'data-flowr-answers-per-query' => config.dig(:flowr, :answers_per_query) || 3,
     }
   end
 end