From 73bb7fa2e61342bc7ff35b398e5869a8fd85cb44 Mon Sep 17 00:00:00 2001 From: Armin Kirchner Date: Tue, 29 Jul 2025 11:43:31 +0200 Subject: [PATCH] chore: Enable Rubocop for migrations Rubocop gives valuable information about issues in migration. New migrations should be checked by the linter. --- .rubocop.yml | 1 + .rubocop_todo.yml | 17 ----------------- 2 files changed, 1 insertion(+), 17 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index f306664b8..efa748bdc 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -19,6 +19,7 @@ inherit_from: AllCops: UseCache: True NewCops: enable + MigratedSchemaVersion: 20240930231316 Exclude: - 'bin/*' - 'db/*schema.rb' diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index f40bca665..73f5edcb9 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -22,23 +22,6 @@ Metrics/CyclomaticComplexity: Metrics/PerceivedComplexity: Max: 25 -# We don't want to change previous migrations... -# -Rails/CreateTableWithTimestamps: - Enabled: false - -Rails/BulkChangeTable: - Enabled: false - -Rails/ReversibleMigration: - Enabled: false - -Rails/NotNullColumn: - Enabled: false - -Rails/ThreeStateBooleanColumn: - Enabled: false - # The models need to be fixed anyway # Rails/UniqueValidationWithoutIndex: