From 16523e9f9ceedaf195df70e019a57911ca3c2c75 Mon Sep 17 00:00:00 2001 From: Armin Kirchner Date: Tue, 29 Jul 2025 12:16:20 +0200 Subject: [PATCH] chore: Enable inverse_of Rubocop rule --- .rubocop_todo.yml | 3 --- app/models/submission.rb | 6 +++--- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index f40bca665..fb4f3bd4c 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -50,9 +50,6 @@ Rails/HasManyOrHasOneDependent: Rails/HasAndBelongsToMany: Enabled: false -Rails/InverseOf: - Enabled: false - # We have too many specs with too many lets # RSpec/MultipleMemoizedHelpers: diff --git a/app/models/submission.rb b/app/models/submission.rb index 83b2da2be..f63e2ab4c 100644 --- a/app/models/submission.rb +++ b/app/models/submission.rb @@ -22,13 +22,13 @@ class Submission < ApplicationRecord belongs_to :external_users, lambda { where(submissions: {contributor_type: 'ExternalUser'}).includes(:submissions) - }, foreign_key: :contributor_id, class_name: 'ExternalUser', optional: true + }, foreign_key: :contributor_id, class_name: 'ExternalUser', optional: true, inverse_of: :submissions belongs_to :internal_users, lambda { where(submissions: {contributor_type: 'InternalUser'}).includes(:submissions) - }, foreign_key: :contributor_id, class_name: 'InternalUser', optional: true + }, foreign_key: :contributor_id, class_name: 'InternalUser', optional: true, inverse_of: :submissions belongs_to :programming_groups, lambda { where(submissions: {contributor_type: 'ProgrammingGroup'}).includes(:submissions) - }, foreign_key: :contributor_id, class_name: 'ProgrammingGroup', optional: true + }, foreign_key: :contributor_id, class_name: 'ProgrammingGroup', optional: true, inverse_of: :submissions delegate :execution_environment, to: :exercise scope :final, -> { where(cause: %w[submit remoteSubmit]) }