Relax strictness of configuration schema validation

[franzliedke]

It's fine that the video player raises an error when required configuration attributes / sub-property are missing. IMO, it is unnecessarily strict with the values of certain properties, though.

We recently had multiple reports about the player speed selector not working for users. The root of the problem was an invalid value stored in our system preferences (1.25 in this case) - this probably stemmed from our previous video player, which offered this value.

In line with Postel's Law, the video player should just fallback to the default value if an unsupported value is provided for such a relatively unimportant property.

[franzliedke]

(I accidentally submitted the report too early, I edited the description now.)

[franzliedke]

How this could be implemented: change the ConfigurationValidator to warn instead of error on at least some of the current checks. For example:

• video-player/src/services/configuration-validator.js

  Line 89 in 545cf27

  this._error(`Option "${propertyPath}" must be one of ${JSON.stringify(schema[key].options)}.`);

• video-player/src/services/configuration-validator.js

  Line 94 in 545cf27

  this._error(`Option "${propertyPath}" must be at least ${schema[key].min}.`);

• video-player/src/services/configuration-validator.js

  Line 99 in 545cf27

  this._error(`Option "${propertyPath}" must be not greater than ${schema[key].max}.`);

• video-player/src/services/configuration-validator.js

  Line 104 in 545cf27

  this._error(`Option "${propertyPath}" has an invalid value.`);

When the property is not required and there is a default value, then we can safely fall back to the default value.